Received: by 2002:a6b:fb09:0:0:0:0:0 with SMTP id h9csp3047988iog; Mon, 27 Jun 2022 08:07:07 -0700 (PDT) X-Google-Smtp-Source: AGRyM1tjdA9RN6gX9beiVgRrPdg0CR1ikqUvmp6ZR+iLnEMfg8O4fTJmCAyPC7XX/I/u5OBTpXU2 X-Received: by 2002:a17:902:f7d3:b0:16a:208e:b2c4 with SMTP id h19-20020a170902f7d300b0016a208eb2c4mr14741919plw.64.1656342427475; Mon, 27 Jun 2022 08:07:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1656342427; cv=none; d=google.com; s=arc-20160816; b=UhQnEPJC1IkVwoMIIoprh3IBUW+e7ASSWUuECcrBs6cSO/OM0qW44uYc4J7pe+tx8/ eowSopbgIhYm8oLvAMcvNeXxyedz6PWGZLx4raenShVV2tMkxAmgDAVMexNmhdiyw6IZ ETwAy5mvC9TNlW8GF3jEt2MgvsXMs+5jnwD8nX6ELKRSM07f/W47BAAxTltqXhgxtKBM Dfnz21Wgn+DUcVJl3AkW2t+V8l3ZC93MME7dtROi6psybvtzBHmcuKJnIG9JTRk8OGyC Z/xgBk09vL/AU0p2RmgiNkxzZaoTBZw1qjLA/cqOWuwnf44/XGhAV1fPKCdDSh1IFxSJ WhMw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:references:in-reply-to:subject:cc:to:dkim-signature :from; bh=JnShx9ff+v/hZ//UO2vtlobKE4RR79JV1bBbsW0LTzY=; b=MiuyuD/EJ+QFjol2r3cQTdJQe7YtdAitDaVffhPLUUFCWW9yGeIYkE/qjrtYhmXBI9 PhEYx/KUj5DPF7XQsIGSu4m1lS1Un5FGmaDHDCMg2T7TjS6qfczrtmogfRbMhO3OeQEy tFEfgjP7yvjJMI6ZBI1BP02xBg+oqw2szSCNUoXznZfAVYNgpcl2wvKnxXwHC7tBqzq0 Vw0NcFHgLSXFElm4EzENkJO01MdaT1EZLsrF4/g9yTvVI5tZbrfVx54mcQWhzNUzSLtW T1M0PCwaqia0vKuWt+iO0Vw/0bKl6K39E9N4+nHSXmaBpusvqxbejfJGa/j7Elitdqnt ipXw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@toke.dk header.s=20161023 header.b="tDWHVre/"; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=toke.dk Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id 185-20020a6302c2000000b0040dd6d54504si7381174pgc.511.2022.06.27.08.06.59; Mon, 27 Jun 2022 08:07:07 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@toke.dk header.s=20161023 header.b="tDWHVre/"; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=toke.dk Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231131AbiF0PEK (ORCPT + 64 others); Mon, 27 Jun 2022 11:04:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43190 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236588AbiF0PEH (ORCPT ); Mon, 27 Jun 2022 11:04:07 -0400 Received: from mail.toke.dk (mail.toke.dk [IPv6:2a0c:4d80:42:2001::664]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6C78A1707D for ; Mon, 27 Jun 2022 08:04:07 -0700 (PDT) From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=toke.dk; s=20161023; t=1656342245; bh=JnShx9ff+v/hZ//UO2vtlobKE4RR79JV1bBbsW0LTzY=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=tDWHVre/Y/Dc4gOHHBQPCoSPam7mHsTqIgd1+nGML+o4Es7DlMRS7jv2qdbPzmoHy KMqLQxj7+3+B9har4FhsK5IQqL9fIGGq7GPzedjhBEpIYWg4/inS2qcl6JmPDsB+OS jtNMq07XCSG0YhXLAtp8pjghI8sYyeeOv1aKZuErrUhpBQZGCvIhWnubkb5Lzo7H8o 4mDIAd8g68RKZesiwVrDP0SB7BMN3ZRgifwYRLB5zbEWCOqaOyQ6QM0E/1OnqTR5VT sv0/M+eJm8KqmnXxC5GNscBE9VJ2PweBEbThjwel2OpoPdodGkWH7M+6tXa5N/eMhK G9b7O/CB2PMQA== To: Felix Fietkau , linux-wireless@vger.kernel.org Cc: johannes@sipsolutions.net Subject: Re: [PATCH 5/7] mac80211: add a per-PHY AQL limit to improve fairness In-Reply-To: <20220625212411.36675-5-nbd@nbd.name> References: <20220625212411.36675-1-nbd@nbd.name> <20220625212411.36675-5-nbd@nbd.name> Date: Mon, 27 Jun 2022 17:04:05 +0200 X-Clacks-Overhead: GNU Terry Pratchett Message-ID: <87czeub122.fsf@toke.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Felix Fietkau writes: > In order to maintain fairness, the amount of queueing needs to be limited > beyond the simple per-station AQL budget, otherwise the driver can simply > repeatedly do scheduling rounds until all queues that have not used their > AQL budget become eligble. > > To be conservative, use the high AQL limit for the first txq and add half > of the low AQL for each subsequent queue. > > Signed-off-by: Felix Fietkau Acked-by: Toke H=C3=B8iland-J=C3=B8rgensen