Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <4dac4c5c118aab5a7f55a2e38b1e7f61dd94e008.camel@sipsolutions.net>
Subject: Re: [PATCH] mac80211 : Add support to track mesh peer beacon miss
 event
From:   Johannes Berg <johannes@sipsolutions.net>
To:     quic_haric@quicinc.com
Cc:     linux-wireless@vger.kernel.org
Date:   Fri, 01 Jul 2022 11:47:08 +0200
In-Reply-To: <1653893292-11092-1-git-send-email-quic_haric@quicinc.com>
References: <1653893292-11092-1-git-send-email-quic_haric@quicinc.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.44.2 (3.44.2-1.fc36) 
MIME-Version: 1.0
Precedence: bulk

On Mon, 2022-05-30 at 12:18 +0530, quic_haric@quicinc.com wrote:
>=20
> +++ b/include/net/mac80211.h
> @@ -1732,6 +1732,9 @@ enum ieee80211_offload_flags {
>   *	for read access.
>   * @color_change_color: the bss color that will be used after the change=
.
>   * @mbssid_tx_vif: Pointer to the transmitting interface if MBSSID is en=
abled.
> + * @bmiss_threshold: beacon miss threshold that is used to change the be=
acon miss
> + * timer value
> + *
>   */
>  struct ieee80211_vif {
>  	enum nl80211_iftype type;
> @@ -1764,6 +1767,7 @@ struct ieee80211_vif {
>  	u8 color_change_color;
> =20
>  	struct ieee80211_vif *mbssid_tx_vif;
> +	u8 bmiss_threshold;
>=20
>=20

Why should this be visible to the driver?

> @@ -2495,6 +2499,19 @@ enum ieee80211_hw_flags {
>  };
> =20
>  /**
> + * enum ieee80211_dbg_mask - Debug mask to enable and disable logs
> + * in runtime
> + *
> + * @IEEE80211_HW_DBG_BMISS_LOG - To enable/disable mesh beacon miss logs
> + *
> + * @IEEE80211_HW_MAX_DBG_MASK - Max debug mask value
> + */

same here

> @@ -2656,6 +2675,7 @@ struct ieee80211_hw {
>  	u8 tx_sk_pacing_shift;
>  	u8 weight_multiplier;
>  	u32 max_mtu;
> +	u32 dbg_mask;

and here.

>  /*
> + * mesh_bmiss_update - update beacon miss parameters such as

/** I guess, based on the comment formatting

You also have a bunch of robot comments.

johannes