Received: by 2002:ac0:c50a:0:0:0:0:0 with SMTP id y10csp1091436imi; Fri, 1 Jul 2022 02:57:13 -0700 (PDT) X-Google-Smtp-Source: AGRyM1v8koarYgKmU2AtNqJapt2n4Idnt7JxqQAIphv7NVJs716/VDq16nva4MPi14d6d8SaOX8m X-Received: by 2002:a17:907:72ce:b0:722:e1a5:164c with SMTP id du14-20020a17090772ce00b00722e1a5164cmr13663187ejc.111.1656669432829; Fri, 01 Jul 2022 02:57:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1656669432; cv=none; d=google.com; s=arc-20160816; b=OWrwUH2xn6Gr5TVaIlQGRcV2YNQIaIq1Bo4YnvEzk7OeuSjiEcAhNsJVemoBWmogVR sU6XHTRdwD8qPFr7e0/XJLgh0bMuSfG8GUs/D2RQ73I4FoiVtVauNZaRdxMgThUcjy4n DZaIFvhJlcPmtBwc1pKf9fvxEVmdssRtAesSdmgbH98LAeAkxzVYxTURZTQRM3U9KyY2 xGiik26z+IinVPij+o4ugS6kVF2zc1mwQg+DGfUKi4TGTljc8o5cTe+KNVJWo91s29ux 0IF49HBiDYrx4PITT5pdtf6dgU7e3QShSps+GKJ50RTyrukbwlPH+ESWveS+sSk0zLWl MX9Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:user-agent :content-transfer-encoding:references:in-reply-to:date:to:from :subject:message-id:dkim-signature; bh=pePzQ70O3qF1BbrHwbaYS/YJeXplHbDhGHZky1QkMIw=; b=GUA2gzj4mOYTViYP/PDoohoOs9fAMkEhFiukQY8iFihYDwlWyFGu7F2XEmto2ht0lJ f/Ss79WtxBYHNDKuhBBTmVKJbKLMk+eHrENLG0VEN6p2cNoIKjsXN5G+2acQainkG41b RReem5vSl2w1pEP0Vns90fePhFu2/9L7EhLoeH7/s9fiXVeTrwuSBFqJKI2X0yuhj7KC w/h74qj7VF63R/qxJaJX2TbwdN5CMCmd3sknE530ptsvEnb6k+Ue0elTXzD2WGk8wiyv UWXhM07LppiC3xBeqPPQ0ShUs5pRyYv3iFSQZDKB7g4Isdo1Fk+OV0fZV7OYfyjyi0aW nUTA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@sipsolutions.net header.s=mail header.b=uAiovKPL; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=REJECT dis=NONE) header.from=sipsolutions.net Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id dd4-20020a1709069b8400b00711ca931feasi2225967ejc.998.2022.07.01.02.56.55; Fri, 01 Jul 2022 02:57:12 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@sipsolutions.net header.s=mail header.b=uAiovKPL; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=REJECT dis=NONE) header.from=sipsolutions.net Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233773AbiGAJzK (ORCPT + 66 others); Fri, 1 Jul 2022 05:55:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47806 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233002AbiGAJzJ (ORCPT ); Fri, 1 Jul 2022 05:55:09 -0400 Received: from sipsolutions.net (s3.sipsolutions.net [IPv6:2a01:4f8:191:4433::2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DF39D7479E for ; Fri, 1 Jul 2022 02:55:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sipsolutions.net; s=mail; h=MIME-Version:Content-Transfer-Encoding: Content-Type:References:In-Reply-To:Date:To:From:Subject:Message-ID:Sender: Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-To: Resent-Cc:Resent-Message-ID; bh=pePzQ70O3qF1BbrHwbaYS/YJeXplHbDhGHZky1QkMIw=; t=1656669308; x=1657878908; b=uAiovKPLrSW9l+YPDxobqiVbftjqXC/5gdN1JX4c1PptqbH R2sMiutxvuMspAqv5QXYi0olTJM+ldG/kUzysm9gagXSX5opt2rNSsPBGLppxPbi1j3ngv5Ve20vz uYrumRzOKYucZk7q99YpGWbxEmMQmmwnUfmaHABwvAqGK7QlcoXEzstOxvJR+qdKHYVLuXaZ4e0ai 8Y6m4NELO6K/flNiTKQdC2hMnx6sszHlBgCzTxAxA2oR2tGl1aY6gY5Kwl/zwVo9def4uroIb3CJH ZYgjiHd7BU8z3MICZvT32aBPXwy6wCJA4uUz3k8X73deG/3v4nNkFgiLC1RyKuRg==; Received: by sipsolutions.net with esmtpsa (TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.95) (envelope-from ) id 1o7DMh-003QuP-7i; Fri, 01 Jul 2022 11:55:07 +0200 Message-ID: <8542c3eac729563fef1bc78d28c740453fba88bd.camel@sipsolutions.net> Subject: Re: [PATCH] mac80211: report per-chain signal values through ethtool. From: Johannes Berg To: greearb@candelatech.com, linux-wireless@vger.kernel.org Date: Fri, 01 Jul 2022 11:55:06 +0200 In-Reply-To: <20220329210228.8137-1-greearb@candelatech.com> References: <20220329210228.8137-1-greearb@candelatech.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.44.2 (3.44.2-1.fc36) MIME-Version: 1.0 X-malware-bazaar: not-scanned X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Tue, 2022-03-29 at 14:02 -0700, greearb@candelatech.com wrote: > From: Ben Greear >=20 > Combine them into a u64, each byte is one chain. This only works up to 4 chains, but the specs at least support 8. I don't think we have any drivers for that, but ... And it's also rather ugly, IMHO. We're reporting these through nl80211 anyway though, no? Why should we prefer ethtool, which fundamentally limits to a single value for the AP rather than giving the full per-station view. > Re-work the way that APs averaged stats to be more > efficient. Isn't that completely unrelated? johannes