Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <aa0f3770698f4a9a3ec62d7b898838726af4f82e.camel@sipsolutions.net>
Subject: Re: [PATCH] wifi: mac80211: fix get inactive time for station mode
From:   Johannes Berg <johannes@sipsolutions.net>
To:     Issam Hamdi <ih@simonwunderlich.de>
Cc:     linux-wireless@vger.kernel.org, sw@simonwunderlich.de
Date:   Fri, 01 Jul 2022 11:58:11 +0200
In-Reply-To: <20220628150511.1185132-1-ih@simonwunderlich.de>
References: <20220628150511.1185132-1-ih@simonwunderlich.de>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.44.2 (3.44.2-1.fc36) 
MIME-Version: 1.0
Precedence: bulk

On Tue, 2022-06-28 at 17:05 +0200, Issam Hamdi wrote:
> In station mode, the value last_rx is not updated often.
> Therefore the calculation of the inactive time will be wrong (will give
> values between 1000 ms to 30000 ms).
> To fix this add the update of "sta->deflink.rx_stats.last_rx" for
> station mode in the response of the packets process
> (ieee80211_rx_h_sta_process).

Not really sure I understand that.

> +++ b/net/mac80211/rx.c
> @@ -1756,6 +1756,9 @@ ieee80211_rx_h_sta_process(struct ieee80211_rx_data=
 *rx)
>  			sta->deflink.rx_stats.last_rate =3D sta_stats_encode_rate(status);
>  	}
> =20
> +	if (rx->sdata->vif.type =3D=3D NL80211_IFTYPE_STATION)
> +		sta->deflink.rx_stats.last_rx =3D jiffies;

Why the interface type check? It's a per-station thing, so why would it
not apply here for other types?

>  	sinfo->inactive_time =3D
> -		jiffies_to_msecs(jiffies - ieee80211_sta_last_active(sta));
> +		jiffies_to_msecs(abs(jiffies - ieee80211_sta_last_active(sta)));
>=20

That seems ... rather questionable.

johannes