Received: by 2002:ac0:de83:0:0:0:0:0 with SMTP id b3csp1376739imk; Mon, 4 Jul 2022 01:39:30 -0700 (PDT) X-Google-Smtp-Source: AGRyM1sQYxHIiOYcK0Eep2+b0+9bTXxiY5oEA616yrxyaBe4nhlkfZdpQfZ/0u+97iwZdIH6ZfiP X-Received: by 2002:a17:907:6d8b:b0:72a:b3bc:2ab2 with SMTP id sb11-20020a1709076d8b00b0072ab3bc2ab2mr9514212ejc.67.1656923970669; Mon, 04 Jul 2022 01:39:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1656923970; cv=none; d=google.com; s=arc-20160816; b=g31TKcnBgxRrWSymOQ3JLAU0IdV+KbV0bZshzwh0jYwB5ZgnQMN54mtn9w5aDhnav6 PKdC+UHW2O7E+8L7ArvW2uad2Ymy1NuFUOY2rG5T/PvAKG+bdFifLryqAX0LRl7QrFHF LX/f6OXxfPKpTW5i+3zWE/z8ez3V7bKQY9WGhgnp1yTLk1R6PJEmwogGlII5ALRVldwD DL+ciNHeVnKZ8gPUntJID78pNaWYUSakAGmQEql0G3YYa46xtDh7T5/VpD75ZLK4lAz/ zUfT2EKUedWbM6m8U6XuC8bmjfJnI8e2AFEXzk1gcpZcW02/2NDSErgmlsuRrjobGh7d 6kKQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:to:from:dkim-signature; bh=FJG6V4jph5sUNRiak7lEZgEto/bDbMAVj1LGzxQ4h9A=; b=EqQMdPfu6NeUjleEvhfqsFnLtjIpR/piKdywCNxdh/Bs0PfoTOy7UFNZ4/cRaOVU2r p/3A8odo1NMP4cXpOSPYj4HNksFGqB/ii4exjDd/R5ZP6ePMVNCb37HlVR0JydeDP6Cd xcdWO6REjoR785GATUfuqZmhf1brmKMyEaSuy7ETk8pkHw361bMpj7++5VAy8jGB8EtJ wc6iEE6LU4j8TFs2K8kEgGIZn64fxdhBPKqKTnCHytJ0yph4A3MNXyq/1TZLi8EOrFDB YaxNgXJDAE0HI/63TnMU14Wd8HzQNbcNU7Xddz8fuY3wx2jS9J9dLVQy0hi3gzQ721FF Ye0Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@126.com header.s=s110527 header.b="iN5ba/iD"; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=126.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id dz17-20020a0564021d5100b00435705f2c71si12369660edb.439.2022.07.04.01.39.14; Mon, 04 Jul 2022 01:39:30 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@126.com header.s=s110527 header.b="iN5ba/iD"; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=126.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231771AbiGDIfh (ORCPT + 66 others); Mon, 4 Jul 2022 04:35:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42316 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229967AbiGDIfg (ORCPT ); Mon, 4 Jul 2022 04:35:36 -0400 Received: from mail-m963.mail.126.com (mail-m963.mail.126.com [123.126.96.3]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id EA8D3B493 for ; Mon, 4 Jul 2022 01:35:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=126.com; s=s110527; h=From:Subject:Date:Message-Id:MIME-Version; bh=FJG6V 4jph5sUNRiak7lEZgEto/bDbMAVj1LGzxQ4h9A=; b=iN5ba/iD0D7W2aUp0RxvL 6JY/aLphkeo4i3b/rILBYLodVQf4zg73ZUrkcoEioeNPjgBYMMc/Lx+KTaqgI2c2 zSCf3zwWrP6tc7/PKg8SZ7/tPX700mdkuu61vKQWJBHjN6ROUheCu6xFvVoWgW1N qL5lpp6oO3dgPa1mNOabE0= Received: from localhost.localdomain (unknown [124.16.139.61]) by smtp8 (Coremail) with SMTP id NORpCgAHZZkSpsJidprJHA--.17231S2; Mon, 04 Jul 2022 16:34:27 +0800 (CST) From: Liang He To: nbd@nbd.name, lorenzo@kernel.org, ryder.lee@mediatek.com, shayne.chen@mediatek.com, sean.wang@mediatek.com, linux-wireless@vger.kernel.org, windhl@126.com Subject: [PATCH 1/2] mediatek: mt76: mac80211: Fix missing of_node_put() in mt76_led_init() Date: Mon, 4 Jul 2022 16:34:20 +0800 Message-Id: <20220704083421.276727-1-windhl@126.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CM-TRANSID: NORpCgAHZZkSpsJidprJHA--.17231S2 X-Coremail-Antispam: 1Uf129KBjvdXoWruw17XrWkGw48tw4kXw1fJFb_yoWfKrg_Wr n29r17XFyktw1Ykr42yr4a93yFkFWkWrWxJFZaqryfW3y7WFZ8Gr4FvryDJry7uws293y5 Gw1DGF98AayrZjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7sRJGYdJUUUUU== X-Originating-IP: [124.16.139.61] X-CM-SenderInfo: hzlqvxbo6rjloofrz/1tbi7RM0F1pEAVUTQgAAsG X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org We should use of_node_put() for the reference 'np' returned by of_get_child_by_name() which will increase the refcount. Fixes: 17f1de56df05 ("mt76: add common code shared between multiple chipsets") Signed-off-by: Liang He --- drivers/net/wireless/mediatek/mt76/mac80211.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/wireless/mediatek/mt76/mac80211.c b/drivers/net/wireless/mediatek/mt76/mac80211.c index 18b5de55334c..e1708eff9186 100644 --- a/drivers/net/wireless/mediatek/mt76/mac80211.c +++ b/drivers/net/wireless/mediatek/mt76/mac80211.c @@ -210,6 +210,7 @@ static int mt76_led_init(struct mt76_dev *dev) if (!of_property_read_u32(np, "led-sources", &led_pin)) dev->led_pin = led_pin; dev->led_al = of_property_read_bool(np, "led-active-low"); + of_node_put(np); } return led_classdev_register(dev->dev, &dev->led_cdev); -- 2.25.1