Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 6 Jul 2022 13:39:01 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Kalle Valo <kvalo@kernel.org>, Jiri Slaby <jirislaby@kernel.org>
Cc:     Paolo Abeni <pabeni@redhat.com>,
        Johannes Berg <johannes.berg@intel.com>,
        linux-wireless@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 2/2] wil6210: debugfs: replace in wil_link_stats_write()
 in wil_link_stats_write()
Message-ID: <20220706103901.GD2316@kadam>
References: <YsUx6tbR5jhJc/UH@kili>
 <YsUydUx6FEz1ETq5@kili>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <YsUydUx6FEz1ETq5@kili>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?7UUWyHdxx9FYWZX/G/sN16WSr6kDw1NgfbcG2LfuqdC0anOFprtaXEawt8Bf?=
 =?us-ascii?Q?LOVbaDLyMzZqEnGz9Y3NnDFSZNdi2JSl7OBCWYlfcOaQmDvePrzRXD4iaBDR?=
 =?us-ascii?Q?xw82KkOOG2UdVPmfn9bEYcg/ON/u0nvfaLw1gmplCw+PlfXl8qDXGMHxmdJK?=
 =?us-ascii?Q?ELUvafN4AaLxZYDXBZvIBSfjngzxwOFlvl0b+eCQyCPL4UxNrkIfO5YvffFt?=
 =?us-ascii?Q?HlkMite/nUpEPlx50IGrY2h7FbSe+XA5wRYoih2JnWacqJzz55YtAHY6YCt2?=
 =?us-ascii?Q?YWfISsGqPyqJqMwOTwURFZBrE5Nqbnt0OceBeqSDvhBFLhbdkn8+7x1Xrpyi?=
 =?us-ascii?Q?i2wCDSPrgUbT/HdD8lhG/NLvMYvr/C2xTX0RxrhvTtI9PzL093nNsao/YzAO?=
 =?us-ascii?Q?rFcBDmoL5R3Eoj0G8DOboBqxGVYP7Mh/jdT3LAhedwzgedabMWjwBFcV75sB?=
 =?us-ascii?Q?CEwiJIxUwshY3CriiIsyFMv3sJaKu+Dut4Bc9VQSTK+cMq8QC0w7B0i981op?=
 =?us-ascii?Q?2vdSTU0bARoz+FeqeYftnNg3yJtBw23tsqSm+X/5WVu69dyIlt2NgD1CkZpp?=
 =?us-ascii?Q?gGS6lq5d0AacoYpv+UbQh2G0x0Kzj6Lqa/MkvTpNyxDCIZFKgj55K+xDhx1R?=
 =?us-ascii?Q?+YYW0Hdu9xvHA/t4UvbG38ZF5EtyVNFxccc0bNAx6engwwyBdcDWn2CqpEVc?=
 =?us-ascii?Q?tXSsL1V63qUDIBqEnLXWnbYHuKWkV64VgKYQb4gM8Eix2BWlnu6GE5sy3aqZ?=
 =?us-ascii?Q?P7JDz2rSx60YVdWm99UXMAou8powsNP7LovLFN4G1EU1S8yzk3uy1L1x40fU?=
 =?us-ascii?Q?gy0V/WpdVxQSHs/ZsthXxuG2I7Cqe5/TZKuNhvULsQKGPv48MOYpg1djqbHt?=
 =?us-ascii?Q?YX4/x6oyXxjC3wCmjh51OcOFgu0HMHZA3Gzv2U9LAvVJynm1OB9wi+yMt1Lx?=
 =?us-ascii?Q?DAYLov6gg0FRGwv2fpZPCS9NHuhcOx25aB2Nu+BKeWWJIIKdtWtd6tJKKCJs?=
 =?us-ascii?Q?ysg+8tNJD47t9PifmZZW3TQIUk4Aw2q0YBZyw/QhKs09x0f2sV885OpRkpYV?=
 =?us-ascii?Q?keXwTOCikt2qv/HQCdT+zNRXsH3x9IC+B9jsFlEWs+1AhbZycVeFbwXXQDon?=
 =?us-ascii?Q?1Wii/Qc7QbSPRMphkMBizFQ5OTZ10EoiBySAIwMcZy6YISPYnaWoNkLiuvBz?=
 =?us-ascii?Q?fMsn3RNK6DoDigkGNbXZ3KG0KTHaLta+KNpHacl2UnywMpIA4mgxHxEcJ66J?=
 =?us-ascii?Q?rQwboUECm1enkDIeL90WMqwdtFbjzxhauD+mUYNc2bB13c342HbspcnQnGhg?=
 =?us-ascii?Q?/qefVtMC6DPNYdqSlTC+PSRgkT9M+ZdbM2JnN9zuAYauz1DyPWlCaJSjnJG4?=
 =?us-ascii?Q?6YI/k2qaLnM7+EjPlYeOlqPHApvyCMQx08+/ETD4C7Tgbq9LWwYIuYI4FfL6?=
 =?us-ascii?Q?F8TX1++/3PsWYvIXY0GWFh/WCwKZBO5yF3Yg1KE/9Sq9G9PeSi+z0oWgtKYA?=
 =?us-ascii?Q?pk2VlI2yXWLGhC0CGZVStam2u2IoWHxfY3Nb3iKFuSQ5CaIa1FVAiiECsWcc?=
 =?us-ascii?Q?yPz1nU4MP/toQcmGjLjRWzuGCocJnjiVyllwehPutubLCoh1sozKd6buT9yq?=
 =?us-ascii?Q?xA=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 16826982-79e2-4e9f-1f8d-08da5f3bc79e
X-MS-Exchange-CrossTenant-AuthSource: CY4PR1001MB2358.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jul 2022 10:39:19.2927
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: LkjJAX8GsmxKJ8vQBxFkBqD7gzkoqle4hFnnqbBgusX3EhXF4M5Lzz3JZCiWVCrF6thj9/Ap1MM+TLWfpTuEnOhNE5p3t6ET5Zdm7UWYU10=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR10MB3920
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.517,18.0.883
 definitions=2022-07-06_06:2022-06-28,2022-07-06 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 adultscore=0 spamscore=0
 phishscore=0 malwarescore=0 mlxscore=0 mlxlogscore=999 bulkscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2206140000
 definitions=main-2207060040
X-Proofpoint-GUID: -NmzE3keN89-KS0RZf-bNN54KnaT9UnI
X-Proofpoint-ORIG-GUID: -NmzE3keN89-KS0RZf-bNN54KnaT9UnI
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-wireless.vger.kernel.org>
X-Mailing-List: linux-wireless@vger.kernel.org

On Wed, Jul 06, 2022 at 09:57:57AM +0300, Dan Carpenter wrote:
> This code has a check for "if (rc != len) {" so it will fail if the
> simple_write_to_buffer() does not completely fill the buffer.  In
> particular it will fail if "*ppos != 0". Although this code works, it is
> more complicated than necessary.  Just use strndup_user() instead.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

NAK.  This one is buggy.  strndup_user() is too strict.  This will break
stuff.

regards,
dan carpenter