Received: by 2002:ad5:4acb:0:0:0:0:0 with SMTP id n11csp95114imw; Thu, 7 Jul 2022 22:12:19 -0700 (PDT) X-Google-Smtp-Source: AGRyM1vYRlQf0kUSV9QJlMUXUQIDRYNlwnNXbLuW1TCzZtmhsoYl+4ekxVumxg047dYxvmiZ2T2g X-Received: by 2002:a05:6402:34c8:b0:437:74d5:f8df with SMTP id w8-20020a05640234c800b0043774d5f8dfmr2328402edc.274.1657257139240; Thu, 07 Jul 2022 22:12:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1657257139; cv=none; d=google.com; s=arc-20160816; b=y31rKo9MphzWLoDIQksQ+GX3Mskxz9Mw6LjWXiIlqvzvjngRVY8zq00Xzcs52ageAa +PGjqowQNXNp75HgHfdRpK3hcUPNvHXGAJ7hEM6L6FPbFju0rHHsXEVgmxD+jiA7JTIS iWk+ek/IIE6coeYmFU+/Hf7vLWQ/upOxqUyPdWEIVtlK/jtyyw3gT52+8GLofYCcbJFi tiFkEROU49wKmrc3om+JmpTJYKgHAkJEeTZUDHv6xsu+QtXOpocKWLPrGzWkNR3Oecr6 L30OpqagrxXmJJwoRe9wndAUQEkfy7xeQTklHFMFpp5n6LCZKgyTm2f7UjvO3COB1nSD jwSQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:user-agent:message-id:in-reply-to :date:references:subject:cc:to:from:dkim-signature; bh=r93yZM02o+xzzycT7fK/Ef59CYc/pjYHr6GfTuKFzN4=; b=gBshXlVvcwZxhwVX5unf2peM9NNvzOmhJDAr1g+I/C8hjHxbnc8MkC8bJ8ieVfdRGx dZl6nrsngncUigYmwstoySYP4I0ZYzDi+pBPoqnug4O/NFf6lqoCY7hVcwktsw9+9BxO yK9dEe0JW4oB+N8g9JtZnXYYG2cvMAIUMkkPPg9htHqmRl9aPNf/wvhLalijn2SFKM1i ZG0BT3v4LTI4Yszv/KyNg5u5T4/jUh157D17VEeBPjlRWdnKG+Oq2TZj0E8s5EdDCD+U lTcwSk4wjlekpm7133KdSVjtcd+7eTgniB6NIkJHT+Y0iljticG+Hp0L8K3YSvyuOq3S 1N4Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=YhTMSFf3; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id i14-20020a1709064fce00b00726abd9108bsi5659514ejw.168.2022.07.07.22.12.00; Thu, 07 Jul 2022 22:12:19 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=YhTMSFf3; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237302AbiGHFCk (ORCPT + 66 others); Fri, 8 Jul 2022 01:02:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33106 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236471AbiGHFCi (ORCPT ); Fri, 8 Jul 2022 01:02:38 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EDEA479693; Thu, 7 Jul 2022 22:02:37 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 8A0E562441; Fri, 8 Jul 2022 05:02:37 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B847AC341C0; Fri, 8 Jul 2022 05:02:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1657256556; bh=MkIE5dQrmQrhvk/c5OSQ7HJoMDKtQ9XiTEE+7rfbTYY=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=YhTMSFf3j0X4ZDTsxkuKfiIaSBMtslBQ2bhggLtYbGaX5rCdsIiVVUIHydP1X9s/p YtXt7RSM0YcjMccVRXqewMu+kmwRwuuwh8r6/O0m9CD0eCroUL2nOaIYCZBbxjn4gu H+Sj6SenwX3B0Y92AbgL10+vA2dP25GCms4ja1PIoKRyyWZROo+GzQblCdiS4j/4yE VL2MmHw3sFRtKo94ZDRrM2BVCTi+UIyyEbZD3paXpBfPGL++tLIwBONEs06oH9VEvx iHgB+hNjYTzYxnOBgoGA/2tOYQrKr5xqNfxq1g13nWG4O4C/SsTJwYenqhSENYtSsn SYJDvvucXzDcA== From: Kalle Valo To: Steven Rostedt Cc: linux-kernel@vger.kernel.org, Ingo Molnar , Andrew Morton , Arend van Spriel , Franky Lin , Hante Meuleman , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , linux-wireless@vger.kernel.org, brcm80211-dev-list.pdl@broadcom.com, SHA-cyfmac-dev-list@infineon.com, netdev@vger.kernel.org Subject: Re: [PATCH 04/13] tracing/brcm: Use the new __vstring() helper References: <20220705224453.120955146@goodmis.org> <20220705224749.622796175@goodmis.org> Date: Fri, 08 Jul 2022 08:02:31 +0300 In-Reply-To: <20220705224749.622796175@goodmis.org> (Steven Rostedt's message of "Tue, 05 Jul 2022 18:44:57 -0400") Message-ID: <87mtdktcwo.fsf@kernel.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-7.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Steven Rostedt writes: > From: "Steven Rostedt (Google)" > > Instead of open coding a __dynamic_array() with a fixed length (which > defeats the purpose of the dynamic array in the first place). Use the new > __vstring() helper that will use a va_list and only write enough of the > string into the ring buffer that is needed. > > Cc: Arend van Spriel > Cc: Franky Lin > Cc: Hante Meuleman > Cc: Kalle Valo > Cc: "David S. Miller" > Cc: Eric Dumazet > Cc: Jakub Kicinski > Cc: Paolo Abeni > Cc: linux-wireless@vger.kernel.org > Cc: brcm80211-dev-list.pdl@broadcom.com > Cc: SHA-cyfmac-dev-list@infineon.com > Cc: netdev@vger.kernel.org > Signed-off-by: Steven Rostedt (Google) > --- > .../broadcom/brcm80211/brcmfmac/tracepoint.h | 12 ++++-------- > .../brcm80211/brcmsmac/brcms_trace_brcmsmac_msg.h | 12 ++++-------- > 2 files changed, 8 insertions(+), 16 deletions(-) Feel free to take this via your tree: Acked-by: Kalle Valo -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches