Received: by 2002:ad5:4acb:0:0:0:0:0 with SMTP id n11csp3005127imw; Sun, 10 Jul 2022 22:35:44 -0700 (PDT) X-Google-Smtp-Source: AGRyM1uDCjRB/pKqE9Gv0TNPo2j2lgq1L+eA1nMTrJKiDYJgIlbVu4kamZEAflxb5B5XQiaBNj2r X-Received: by 2002:a17:906:a10e:b0:6f3:e70b:b572 with SMTP id t14-20020a170906a10e00b006f3e70bb572mr17175214ejy.546.1657517744466; Sun, 10 Jul 2022 22:35:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1657517744; cv=none; d=google.com; s=arc-20160816; b=q2FMT5BB3nPylHrUOJxc7Hb7HJ8eMZJkSXdJ3pcTHFBySPOiP/GmUNNxnCJ3Ro62VB Q4jNVhQFkqsPXVA8rf0CzH2/621v7rJYnJQkyhjrH9Hu4KsAGiNyl62F3c3DmHgzlDC8 l82Y0e60i94G+Kryl0Hitg486kmjEfUBkBFsZ7ttbxZ5XS7QVK0OkuEYjhT3xt9bePRO pPamo+Z9Tv5fEyGfYxrGTO7YlHVmmto+ERxvAFJu35kkwA9M3mYhcLDUqh8v5+TyNKxY 8FlzcIEeh72JQKHmbqEzOe2XGzpqk0UHDU+1VsBLc5zY3edr8nOoOMrVXo8AmrYb/akU FUtw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:message-id:date:subject:cc:to:from :dkim-signature; bh=Mp9UY6WqfK6Uxd5E/L9N04iAoqnttmY2terDReIMJ3c=; b=yLwGMJx4o4psuNxFz/gfU5vAM14b36zeMgL4UpmcSKtB4nvWmFKhcFSLjtKhvQGSIC I1OL6kYZKnODn76yh30OTc7kwn8SIbCx/Tf2rb0yZ6cHVOzOIpp6IOcQUpWKU6+UF+oS GA3EqJWXKFCmw5RjFKQAAANckSCu2U490j3PeOsuK4EdTCcexoTfKTbm/XP1TtTQwT5o UHb7W+eHJ5LY2HunYyxuKwuFMHUWRoBXHGvAndg+PYCFHopL2yNNYNcaNLht6mrZw7jJ 8tFjxHbFhvjEZ4YVX6wzXp75I4MzEVlQHnTgB8TPDBjBNA0cQduHgv3iSW2HyOwMi/ht XW9Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcdkim header.b=qO9jyf+k; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id j20-20020a05640211d400b0043ad7970b9fsi2795986edw.192.2022.07.10.22.35.22; Sun, 10 Jul 2022 22:35:44 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcdkim header.b=qO9jyf+k; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229470AbiGKFfA (ORCPT + 65 others); Mon, 11 Jul 2022 01:35:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34186 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229450AbiGKFe7 (ORCPT ); Mon, 11 Jul 2022 01:34:59 -0400 Received: from alexa-out-sd-02.qualcomm.com (alexa-out-sd-02.qualcomm.com [199.106.114.39]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 43B8E101F5 for ; Sun, 10 Jul 2022 22:34:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; i=@quicinc.com; q=dns/txt; s=qcdkim; t=1657517698; x=1689053698; h=from:to:cc:subject:date:message-id:mime-version; bh=Mp9UY6WqfK6Uxd5E/L9N04iAoqnttmY2terDReIMJ3c=; b=qO9jyf+kEc/HHiK3rTdC2aJkISlNwTrUl49P5pOYmRnRmFgUIC0NxcV9 loWEWQy62a4iBSWgpKGvRunjioxIR91CUhr6hZRUKsiVmeLY96w56aO8k bGsbx86lEcoOgXAUcccomWteCjj0qjKYl/519mMcuIdAh4hO21LbyaUmc w=; Received: from unknown (HELO ironmsg05-sd.qualcomm.com) ([10.53.140.145]) by alexa-out-sd-02.qualcomm.com with ESMTP; 10 Jul 2022 22:34:57 -0700 X-QCInternal: smtphost Received: from nasanex01c.na.qualcomm.com ([10.47.97.222]) by ironmsg05-sd.qualcomm.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Jul 2022 22:34:57 -0700 Received: from nalasex01a.na.qualcomm.com (10.47.209.196) by nasanex01c.na.qualcomm.com (10.47.97.222) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.22; Sun, 10 Jul 2022 22:34:57 -0700 Received: from hu-vjakkam-hyd.qualcomm.com (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.22; Sun, 10 Jul 2022 22:34:55 -0700 From: Veerendranath Jakkam To: CC: Subject: [PATCH] nl80211: Fix reading NL80211_ATTR_MLO_LINK_ID in nl80211_pre_doit Date: Mon, 11 Jul 2022 11:04:43 +0530 Message-ID: <1657517683-5724-1-git-send-email-quic_vjakkam@quicinc.com> X-Mailer: git-send-email 2.7.4 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nalasex01a.na.qualcomm.com (10.47.209.196) X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org nl80211_pre_doit() using nla_get_u16() to read u8 attribute NL80211_ATTR_MLO_LINK_ID. Fix this by using nla_get_u8() to read NL80211_ATTR_MLO_LINK_ID attribute. Signed-off-by: Veerendranath Jakkam --- net/wireless/nl80211.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/wireless/nl80211.c b/net/wireless/nl80211.c index eda2ad0..e20d0fc 100644 --- a/net/wireless/nl80211.c +++ b/net/wireless/nl80211.c @@ -15835,7 +15835,7 @@ static int nl80211_pre_doit(const struct genl_ops *ops, struct sk_buff *skb, /* MLO -> require valid link ID */ if (wdev->valid_links && (!link_id || - !(wdev->valid_links & BIT(nla_get_u16(link_id))))) { + !(wdev->valid_links & BIT(nla_get_u8(link_id))))) { err = -EINVAL; goto out_unlock; } -- 2.7.4