Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Viktor Barna <viktor.barna@celeno.com>
To:     kvalo@kernel.org
Cc:     aviad.brikman@celeno.com, davem@davemloft.net,
        eliav.farber@gmail.com, johannes@sipsolutions.net, kuba@kernel.org,
        linux-wireless@vger.kernel.org, maksym.kokhan@celeno.com,
        oleksandr.savchenko@celeno.com, shay.bar@celeno.com,
        viktor.barna@celeno.com
Subject: Re: [RFC v2 03/96] cl8k: add Kconfig
Date:   Tue, 12 Jul 2022 02:04:01 +0300
Message-Id: <20220711230401.2949860-1-viktor.barna@celeno.com>
In-Reply-To: <87a6b3wlps.fsf@kernel.org>
References: <87a6b3wlps.fsf@kernel.org>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?JsOTZTGAg/3p+hTEIfBM5OSKIRP7DUOvq/BHkbW0kPHB4ukPSr8yk9X0bLN0?=
 =?us-ascii?Q?Hz4VU4Md6bEb7C48THtLYYEMhWgJUYEbIzh56RPImWP/HN88r3OeAyGzLco/?=
 =?us-ascii?Q?5+sFWYZDTDJZK82DFWrmzneo5tJwnyUXC/0mQcz2dC9CelzerxRhVsanKyvK?=
 =?us-ascii?Q?0inERgHHEGSfU+dqrvFxDLS4WMkM1N0bZJgwqlwKcyswgajbPipeHusVrsxG?=
 =?us-ascii?Q?7qqb6fWCB5r6sOxm0ImsR0+EVvwtojeKr9eRTPC7GPFHn1e2rgtZ6yvqU6Ph?=
 =?us-ascii?Q?jxbhdo1+rrurQfKngbHU+FH9Ya19EA/+uOmYGaqeBJru+63FfQdLgevPJFmB?=
 =?us-ascii?Q?bMs3+rovtZkyKwErBttUw6ni8OGL2D+JpMMFbYk7/4andniK8ICWwhZZmb7t?=
 =?us-ascii?Q?RhdhZRIZHnOKRZxpSllgRV6gSgbnWAwlGIyqTsGzV4EAZ2zfEo3u+1Jj8vdz?=
 =?us-ascii?Q?KQJsVN+PKfCz/BnngjqV1xhtp4LF7mHgacMeApGpmbPCHsBjpO7IrtR7Z2VH?=
 =?us-ascii?Q?iBdiH9piNgKXwSSVhE9nIRBzQyBTd78moGzfC3HGtEFNaFVHNgIf3xc0vuX8?=
 =?us-ascii?Q?aTvR9U3Yn2mTgq+oR5nk6EmqOH7svlkSRAK3U183Ep545uwmu9+3rDrh7dUU?=
 =?us-ascii?Q?DZ6IxwKi+5n532HqyqMXVrmZSYS7ClmyRFnjyLDyVinmeEwJg/2YnhrAa+LE?=
 =?us-ascii?Q?HE+btGSGaZXzi9UOEXbYT/QkOj7xxh1VFhLVFit5QhTNspTpuxRDAswcT5/9?=
 =?us-ascii?Q?/3NiHQeMat/pjdHqkTqc5DIxRa5ALBK6uWdWTGDDiXIk1aNB2c7PGNCYzL0F?=
 =?us-ascii?Q?S7tmMFXqMYf7oXBlT+GbrITTCdBEIeCW178MO6rxAh344S0fENYdG889JVLK?=
 =?us-ascii?Q?FEK3YwlYspTY3ZpOoKiRvUzCkKNAqJwGIHb9/WlzXr9xI5cBcUPN1Rj4/U7b?=
 =?us-ascii?Q?AigduOzSqmRglj5OUc73CDvjGvID+rMpNMacMKVmwQkquMcj+YH/v+r2+R22?=
 =?us-ascii?Q?rzvFycRFeD5R43xQRvYsup17dYjiUOAnj4OISfXDyRUsA9J/pgU8n7X6ADVW?=
 =?us-ascii?Q?8Xewc6ivbomBGGGl5EH7Rhy6kyjh35FKZhShnEw62nUvvGxD1aT/cMFR17cN?=
 =?us-ascii?Q?x1/Cd+M+LCKFkWywVkJBPj9ytWdtx1soXq0GU1TFp6IPnwlCZQ2fMEF9PYqk?=
 =?us-ascii?Q?VzYvJ+dbO1BySpkBhjPIAHHO3WkAYrf7PIIsJOcWwDovUizhfOdM6Sjivhvp?=
 =?us-ascii?Q?HL1/RO2lHhfIiTpq7x7KrHzz7ZTm9B3eYS9VeK3b/KyQ711gUTorR61i8fMD?=
 =?us-ascii?Q?wOWIyqrOcg6figtaMf3aIc9D21XsIH8DSHtBOl7Nu0Wtj6f1aFnrnNmIJXTz?=
 =?us-ascii?Q?xlA0h1kPHDQDIqRBMVLZlW2Big5kOnoHJOGPQT0ioaBSOJy13+xjILb5qDfs?=
 =?us-ascii?Q?Q2hOQcpFLJgcjlQoGB2SAsfwHhSmLYryNzzoyEpNdWg5VyXWcLw+7OUxAFmU?=
 =?us-ascii?Q?2i9Z9WVPVxNB97w2KflId5s5fy0s17PfEfvXLVi7abXesajwEc2hO0V6NInj?=
 =?us-ascii?Q?6rZNLWGwYpBEnerneZvxPbe8907f6bMssCrG/kCfC5JcxBl2QTIbNxVXzQrT?=
 =?us-ascii?Q?4g=3D=3D?=
X-OriginatorOrg: celeno.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b5900552-e13b-4602-33c6-08da6391c5fe
X-MS-Exchange-CrossTenant-AuthSource: AM9P192MB1412.EURP192.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jul 2022 23:04:57.1868
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f313103b-4c9f-4fd3-b5cf-b97f91c4afa8
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: x6NEuXbWN+5aoclXzWFAm/3lXeho9y0WTJJKzIxqw0I6XOs3mmQm9iP7Q0mrCZIDswEX4Jl5oplqEven+KjmLA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0P192MB1889
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-wireless.vger.kernel.org>
X-Mailing-List: linux-wireless@vger.kernel.org

On Fri, 27 May 2022 09:09:19 +0300, kvalo@kernel.org wrote:
>
>> On Thu, 26 May 2022 20:18:35 +0200, johannes@sipsolutions.net wrote:
>> 
>> This, along with the def.h stuff using it, and MODULE_VERSION(), is all
>> rather pointless, I think you should remove it.
>
> s/should/need to/ :)
>

That is an unexpected comment:) Can you please clarify what is wrong with that
place and why it is pointless (regarding the fact that it can be used to keep
track of versions of the code, that were upstreamed)? I can see multiple
drivers with that macro and related defines.

Best regards,
Viktor Barna