Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Viktor Barna <viktor.barna@celeno.com>
To:     johannes@sipsolutions.net
Cc:     aviad.brikman@celeno.com, davem@davemloft.net,
        eliav.farber@gmail.com, kuba@kernel.org, kvalo@codeaurora.org,
        linux-wireless@vger.kernel.org, maksym.kokhan@celeno.com,
        oleksandr.savchenko@celeno.com, shay.bar@celeno.com,
        viktor.barna@celeno.com
Subject: Re: [RFC v2 38/96] cl8k: add mac80211.c
Date:   Tue, 12 Jul 2022 02:13:59 +0300
Message-Id: <20220711231359.2954157-1-viktor.barna@celeno.com>
In-Reply-To: <200a74dbed0ec37b4d374d963bcd0961a249b0ed.camel@sipsolutions.net>
References: <200a74dbed0ec37b4d374d963bcd0961a249b0ed.camel@sipsolutions.net>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZFAxdFY2bW01cXVYOTdGWUtMdWNnc2drd2lNTjNDcXp5QXVoVDE2RFArODVh?=
 =?utf-8?B?Z3l2eVFTQXJ2bTJLV0dNNVNTd2pxTktQdm1wVjRmYW10MERSWnBkam1ZVFll?=
 =?utf-8?B?VVcwMDZ5WE5CTTBQN1Z3SWxnL2VhbGdVZEhlK1F6cW9mSktpSXFSTFBxbEhm?=
 =?utf-8?B?Q0dsdEYrUldXWXlKdmNOQVFCQ1F0OU1xOCtaVXdjMlhlZXpyVlhwbjhpRDNN?=
 =?utf-8?B?N004aDlkR3FkaEVZdGdFMzA3R0oxZldOSVB1eitnTzc3OUlmdW93dWZJOUth?=
 =?utf-8?B?cmtXQy9CZkQ4dGFkNndCaUloOW8wR1JPaCtiWkM4alBsYU5lMTdpNkFRVFlM?=
 =?utf-8?B?OERTMlJ6MTVBZWg5V3h3UUJEVFFXS05oL3VCWE9wQlNUR0I5VWIzSVp1OGpu?=
 =?utf-8?B?YlBJV2grTGo4Q1VmRGpUNFgvdFlGZURoWFRLMGx6TFBhcllrTUpvTDZocTR0?=
 =?utf-8?B?cW9hNmZjMHFmRWQzTVIzZ0ZEY2NjQlRYZjZZQ24vUFB2dzFsYzlOaGFnZmxH?=
 =?utf-8?B?RDg0d05mbWpxeEp0MmM3T3dFQWptNFlwOWRLTmMzQ3JkYXZ6VzNQZFR1bjBh?=
 =?utf-8?B?Unl4cFh4YU0zMEN6cWVJcWxpd2ljMWNIU1Q0S1NsN3lCVG1UeGZzbFR5RGQ4?=
 =?utf-8?B?Ui9jUkZSeVV0NzNTdndjcG1iaVppemlNUjhkRjFlZjZUNmtUNkJudWFITkZH?=
 =?utf-8?B?UnowbkMzZWdMYjVPRGxTaWlxVDVvODA3Q1lBT2x6Q3BYR3g0eG5zNDdmeVdO?=
 =?utf-8?B?VUl6OE9SdXZBWHlFZ0E2MHE5TWRqZDNYWnRoaExvUHRpK0VaWkhBNWMwRURL?=
 =?utf-8?B?Wnh6bTU1R2w4RFZTZ0o4V1lqUTB5cER0anBpa1ZvbnhSY095YmhuVlJlUk5t?=
 =?utf-8?B?amVLbktqSnQxTml3ekI1MG14cHl4ZFBBMnZzdm00aCsrVzdSWTJaYjhiTm1Q?=
 =?utf-8?B?S0czZzdkcDRhWUQ1dzBPUkxkY2RLRHJ4RzdpY2xBdXA4ZEtrSnhreWcxc2tw?=
 =?utf-8?B?bTV0L01Ta2ZialBRYk03Y3FnNnFwck5QdnhtaVhkZlhqVjI1VEVpR094N1JS?=
 =?utf-8?B?RktUMFQwSXhXdEJtbDBqKy9vMnBiVHJnUWVlZ1VEZFVKMzJSRDQrR1hRd3Nr?=
 =?utf-8?B?ZmZVdjg5OTZGZ3NtT0RjVEJkeXRkVTh4SFV3SEgzTUhiUEppRGhOS1dLRHVM?=
 =?utf-8?B?dStETUloY3Myc1h6eTBnU2tsQ1RGVUxCOVVGQlFYWjJRKytEWE1Ob2JVNVNY?=
 =?utf-8?B?MUJybWtHc1JzMmdpRG1ZOXozdzBBQ1ArYmhRaFl6OXlWMkpVZGhsS3lmS0xK?=
 =?utf-8?B?ak9OZU5uMS9aTUVkTXVpb0Q3MDVmV2x3ZFE2bW8rdVRKTlZTaGhDcWFvczBn?=
 =?utf-8?B?dndFWkY4SjZudHMycklaKytZLzhZWENsNHpkY0U1RkxXT0h6QVBhT3JteWNv?=
 =?utf-8?B?ZGpkSW5FRkF5KytKeGRWL0hJZW5QQkhiUFNCM3FwempUY0Zrd1Qzem5SdjBE?=
 =?utf-8?B?ZGsrZlZqQkVKck15a3JEdEpWaEhlSTZTN2JGQ1F1Nnc5NlIyNHBOaUJFMjdk?=
 =?utf-8?B?TWIrdGlJS01FRmczTFV2NFFDamU5cFR2OEtmbnNIMm0ycWZwOGw2UXppOWNj?=
 =?utf-8?B?Z2V6RlBGcVZ6YW5yaVB4dEwyM2dQd0lRUURTdTUxSjdST3dJek5NVVNiMkQ1?=
 =?utf-8?B?OXZDMzBodVFNMzRoWjN2NGh3M2ZKSjdBWE9USWdSNXFZekNTNEM0Uko1MFVh?=
 =?utf-8?B?Q2RSYnRwVnp3UThkNEU4UTNzb2VOYWw0czVBZjZhYjQvZGYyUTMyNlMxRkdz?=
 =?utf-8?B?QkFGV2JReTkwemw3V1JWeis0SXFFYTFlSk93eFFuSGlBZ2hNQ3dhNWJoRGdK?=
 =?utf-8?B?SlNZL085aGZoSEpTWFpLZXduUFFBdTdWUGpRQnROd2dIRlAyL0xLdklHMW4w?=
 =?utf-8?B?bENiMDUyM2ZwdmdUY28yNmNUT21TQlIyQ0xmS0JKSkhJRkpYMWdPQWVqRkVF?=
 =?utf-8?B?TUhENFVybVVMS0xEQzhpemQwaHFnV0s5UzdZZUZqTmk1OXJZRDFqT2ZTMGRM?=
 =?utf-8?B?NWNwOHd4SUU3WlovM3JOOWFpMm9qbC9XTTZCdzJzZ1VRV29UUnRVUVBPejJ4?=
 =?utf-8?B?UUJPdUZSVWNVenZoWTF5azFzT2FvRTNnY2ozWm95d1ZRVVg5TFhyWjNHdlRD?=
 =?utf-8?B?dWc9PQ==?=
X-OriginatorOrg: celeno.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2952aac7-4f11-414f-0bc7-08da63932add
X-MS-Exchange-CrossTenant-AuthSource: AM9P192MB1412.EURP192.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jul 2022 23:14:55.8536
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f313103b-4c9f-4fd3-b5cf-b97f91c4afa8
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 4LZzLuqBTDqvEKsNR19O1OjR5HeHO962O0kk1W0rl1qisCqZWnlAw5T217yP9MbP3BU5Mw8SJDk/U/m1ulSsMg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8P192MB0849
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-wireless.vger.kernel.org>
X-Mailing-List: linux-wireless@vger.kernel.org

On Thu, 26 May 2022 21:49:17 +0200, johannes@sipsolutions.net wrote:
> I'm really surprised to see this callback in a modern driver - wouldn't
> you want to support some form of multi-channel operation? Even just
> using the chanctx callbacks might make some of the DFS things you have
> there easier?

That is a good point. We picked the “old” channel API, which took less time to
implement – the benefits of channel context were not clear enough during that
time.

> This feels ... odd. You really shouldn't have to look into the beacon to
> figure out these things?
> 
> And SGI etc. are per-STA rate control parameters anyway? Hmm.

Information from this dynamic parsing is required for our driver and FW to
function properly.

> You have all this hardware/firmware and you implement this? Interesting
> design choice. One that I'm sure you'll revisit for WiFi 7 ;-)

Actually, the driver is doing that in cl_tx_handle_beacon_tim function as a
result of TBTT interrupt. However, the next version of the RFC will be without
that code – we are moving the routine to the FW side due to timing issues in
the multiclient setup.

Best regards,
Viktor Barna