Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Viktor Barna <viktor.barna@celeno.com>
To:     quic_jjohnson@quicinc.com
Cc:     aviad.brikman@celeno.com, davem@davemloft.net,
        eliav.farber@gmail.com, kuba@kernel.org, kvalo@codeaurora.org,
        linux-wireless@vger.kernel.org, maksym.kokhan@celeno.com,
        oleksandr.savchenko@celeno.com, shay.bar@celeno.com,
        viktor.barna@celeno.com
Subject: Re: [RFC v2 67/96] cl8k: add rfic.h
Date:   Tue, 12 Jul 2022 02:18:52 +0300
Message-Id: <20220711231852.2956502-1-viktor.barna@celeno.com>
In-Reply-To: <8bf132e6-9a31-075a-c592-0f4025425cb8@quicinc.com>
References: <8bf132e6-9a31-075a-c592-0f4025425cb8@quicinc.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?xC8Yq6fRh64yKxxv0S7gQSj5lv7ypezCeMYkSlCOuj9WisIDc5nRubsT5Gff?=
 =?us-ascii?Q?Dzi4myTHA4bTR8pR1AmJPrwpxQghTD50IuRXNfCDe0h8bhaKIDAAH4fCDs4a?=
 =?us-ascii?Q?p790PG+kCrKYMc0nanvMgWws//Wmkhsw8HB6pHss7kCYVFTJvTXhP0eAaO7e?=
 =?us-ascii?Q?y0zEOi+qv+Q5f4t4+QxAtmDYJ1Cht1MbHREGPN5MIL0V0Yq5X7DnQmVfF/Z6?=
 =?us-ascii?Q?fl55V3YiFxVkR+vszGvt3eME2kFFmfI0xhNDgRY24jtT7lX3MHHjlnb+VfRt?=
 =?us-ascii?Q?zBWZIhsErRv5mfdcGuUdN9KC/06nsXi5Q1EkqxZBRHgu0v54mPSuCYHHClcQ?=
 =?us-ascii?Q?qZ2sUZpUYIVqQXxvizrFd7T+Az+kT7wvdwPKQOiXUeOv0LXTIXI6YvVzS849?=
 =?us-ascii?Q?SVSC1gOv6jSUdDr0s2wVFYv5tE0iVm2RcomfianEexdbtkGifLOtijEunUjD?=
 =?us-ascii?Q?7N+oHpFT+lvG9BdSskENhogYkYvi7/WVgeRhS3bF/yS7MuUigfT6P+r/sVhN?=
 =?us-ascii?Q?0OEtzZ0t5PJTFiJZzHcJADN5RJeVrlsalGC8PkZvlsc6fsdxMNfR954f02T9?=
 =?us-ascii?Q?sBs+lgx9a3AxsRIbjIwbJ2rPcQhNj/pYVGgm3qmuFSrIPTST7SvkF4abSGN6?=
 =?us-ascii?Q?QZc13jo/5EapVDEws8Jecg39Riuom8roqfW/Zx488vsU/7eqHCV4UwG1z7pP?=
 =?us-ascii?Q?0aFEBbsrHYerlH18PLV7YS6daIk5037p3X5MMYghP8Qbu0SQxNZIiHwYZwcd?=
 =?us-ascii?Q?8LGppA6eQY3o0ICaaEVpgguiXF6bHkqTLaBNmFioeN3wV7oSDrKblpkfiq+g?=
 =?us-ascii?Q?NJ9cHJD9NAqUqM2W2GhNUvrxIZMLXEKLIEUisQmA69Gu7HADT2TWpT8TnB8X?=
 =?us-ascii?Q?XmRlkCOAue+DAR01pXlX4/zobix34O0P+hILXCDeZ/6yFy8lY5usVtDAmwOz?=
 =?us-ascii?Q?5jrJHdxr+HO1YycZyvF5WIkiqlRq9xlTNccVt7hCqIxFeEhdNx/hqu1+CB3o?=
 =?us-ascii?Q?eTW8kD0g7GRll6hGs7n6Gv1g4OvnpMNv7elK0XAsMuyYRmHykZncZHxJsJeh?=
 =?us-ascii?Q?EhhqXsP5t4PkuCcaluabFXbsykq+WRC5DQyON5CoaUVO8sbQGLxPPiQsNb7h?=
 =?us-ascii?Q?1O/egaozo95A73DD6IUNJm4qUXHAcJ2K4A8RWkT0TBZKwp/UJoPa7VpHq+dy?=
 =?us-ascii?Q?4Y87J0Mn/6FV1KOlvg3709a0g0RWxTwpwaEhX0tHn0MD25EUlCDVb3zJw5wA?=
 =?us-ascii?Q?SR136SQm1znQzGkxBhpr/ZwTYf8aD/AfJzhotHF6yTXN1MmXQK6SIphaxjCI?=
 =?us-ascii?Q?sPqk1HRazbhmWi9cIK8j0wmfr/9v/4KTGhUFxVNvnd9KjGZ92E06ZKlNQ69I?=
 =?us-ascii?Q?v05l4AedImIZwlHQsvGEKIDxH4PiAFR3IbxOq6zYkdq7WdQHOw6WSu4JhrKV?=
 =?us-ascii?Q?xAy3cJD+aXPP+kqyphDB75riMAIEH13p80tJ+QyvabFIYTsqm04UWs0VgJoe?=
 =?us-ascii?Q?qOMKAAY9tYj8z4vPxLuceI7bpOdV7SKKECajX+P3bozaSriuUHGwUS5OFPL6?=
 =?us-ascii?Q?pw8FdrgOqY1aOi7kHrVmltzfcxm2a60YgY4B71qBhchxjCPirovfYIwVzuEY?=
 =?us-ascii?Q?ew=3D=3D?=
X-OriginatorOrg: celeno.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a27ca0fb-c151-42b8-6f7e-08da6393d966
X-MS-Exchange-CrossTenant-AuthSource: AM9P192MB1412.EURP192.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jul 2022 23:19:48.7234
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f313103b-4c9f-4fd3-b5cf-b97f91c4afa8
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 9DmECpYhHgMxK6oBy8eb6nRZ/NkbFv04zrTfFitlu/JHS3Qxqe9Y57YF+YjF+0gO64vIFuS/GzNCe0K25HeQYA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0P192MB0388
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-wireless.vger.kernel.org>
X-Mailing-List: linux-wireless@vger.kernel.org

On Thu, 2 Jun 2022 13:40:23 -0700, quic_jjohnson@quicinc.com wrote:
> consider adding CL_ prefix to the enumerators to avoid namespace collision.

Yes, thanks.

> why is OVERWRITE_DONE the max command? that doesn't seem to make sense 
> since other enumerators are defined after it.

Agree, that is an odd place. We likely will remove that in the next version of
the code.

Best regards,
Viktor Barna