Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Viktor Barna <viktor.barna@celeno.com>
To:     quic_jjohnson@quicinc.com
Cc:     aviad.brikman@celeno.com, davem@davemloft.net,
        eliav.farber@gmail.com, kuba@kernel.org, kvalo@codeaurora.org,
        linux-wireless@vger.kernel.org, maksym.kokhan@celeno.com,
        oleksandr.savchenko@celeno.com, shay.bar@celeno.com,
        viktor.barna@celeno.com
Subject: Re: [RFC v2 50/96] cl8k: add phy.c
Date:   Tue, 12 Jul 2022 02:16:30 +0300
Message-Id: <20220711231630.2955379-1-viktor.barna@celeno.com>
In-Reply-To: <51843710-a1ec-b1f6-8d1a-972ca5b40af4@quicinc.com>
References: <51843710-a1ec-b1f6-8d1a-972ca5b40af4@quicinc.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?gtEqTaDPu6XuzWI5xGMDfxdE1DPu7i76evi9Se/oOnDvpulIaQ2r1jZ9c39s?=
 =?us-ascii?Q?zb5cGcy643JE9BNKtxeYc/+y037YD66ibQ4H79xdUvlrhTJmX5VbAefjs/py?=
 =?us-ascii?Q?PaiIkaXSF0zCILOPQr/fBlhmJ/6EsV3G3HpCx90vSfgZxCA04ESoKIACbOvH?=
 =?us-ascii?Q?EDSZK7wCHHzTUgkLTuMBHPHLUDi0AMDMvp1+/4Rab3faa19iBq3FNN9fGnYF?=
 =?us-ascii?Q?RPtg0MctjbC5KXYCRmGp72Je1i1UjkdZrsrhBZ8iJnwrxIQKpkWIdPfVBWKR?=
 =?us-ascii?Q?URq/0VpDkesQBzGGqnczv+LAMcvE6SAfUuyhPwqcgfN1w9Ofh3jJq1Ik3sxL?=
 =?us-ascii?Q?OLg7TvncWpIgJM5eQID0d+BpiWrIDyYxhCQckyKux1THKf5j4AKq274BQ7/w?=
 =?us-ascii?Q?9KEEe21roH9/zEXttI4Wj/76JUDspWL1DtPUDNrjDyzBIo4MzT8EflReu8Kz?=
 =?us-ascii?Q?hn9kNDNBzUGVAd0RkuurCdohrHUfkcGlz22Hwh9Tgu7wzp61Re9AkVadSVMB?=
 =?us-ascii?Q?xty/gRWQqB4lQCn7mUXmjIFotRhK1H6trFCHTDQeLla6sXu1Zc9knF97kdr5?=
 =?us-ascii?Q?yjh0mQDic2MtU08//dF6P6tbDI/pKHApJU+4v3Tpo14i71XoirZxG9iolDmq?=
 =?us-ascii?Q?ma4NdiiD+WY8gk1IrqT0dKiISvrAxleIslfP86wu/bJPwT7pKLHLdtNPm+Mv?=
 =?us-ascii?Q?dRolwredWDiw2EsJXItb9+jpMX+iTKMlVLAU0757cwO12Ef6SvC38Sg6ArPF?=
 =?us-ascii?Q?6sS1d4Hzuc7UWzBvuim9e3tjWQCR9QbhOPUj1VUKXE6+3b/xyfrxB1gqGRrl?=
 =?us-ascii?Q?4+2003Sqg9VdjmhG5KeZVLLWVtMzPyXam4gvwmDeGTzjTKMhICw1FUUABHYX?=
 =?us-ascii?Q?RZc4j+oNkPo5XsV/4krJ62VM1T2M0WKJLZEJ3+NohIJNuuhLFqwmB0oa1AJr?=
 =?us-ascii?Q?UxR1ZoY2KckBlGW7Np1GjQ8gfH4x8QaI7kG2rt8+Gw5tpVGzEdaMscQ49ODY?=
 =?us-ascii?Q?e/HsiJUkwNMovyTG8oJ6/YcNQLFtqW1TVPQcHGGieZ0/kERh6sLwYybf58sk?=
 =?us-ascii?Q?4027OBiZyZ0y1FzsamSDZgKYMH2wP+s2EjZT0KTJvNrtHrE82vBl7wgwZYes?=
 =?us-ascii?Q?qWVyh7Oia3VSJYHFVHUkM/pR+SbQpq0i/nxw7rEreryBqT8UCyupMoMv5N4D?=
 =?us-ascii?Q?0WwCUIGaNBiC70IDF0L5lp7VM+UvRRIJ7hmL4W2AQovF9fuFTcZlzutiVp9S?=
 =?us-ascii?Q?W29eZ3BkViaEHs0bhPlGrkISyfMANt5lMRnr24ALtEOmcCZ97Ob8624O+OxS?=
 =?us-ascii?Q?fcJiDiRjMgjj83jsuR5tCORcW/FCuk3SNBABiqrXN31GFksBTCl0mkXVF24y?=
 =?us-ascii?Q?il/1rt8xb03zd/oE/Z1LB0sLhe6Wn5qNJjv4fhQ1psCLcVCHGVHUeYZnoEe1?=
 =?us-ascii?Q?MCTjJoEufrkWvziv+cJGcRIXS8hc3u9FNnVFreVsyO7HmclQtzKo7/XPPmRs?=
 =?us-ascii?Q?IN+yHjkAap1Bq0c7ZUELLB/qJnrbFjbrrgolE+sPFacF/3ZcjnJVkP1Y/ua9?=
 =?us-ascii?Q?Nrsdj1jpOo3agqrtutiQJyzSFJjCT+OaT/7RbzaDh9cUtn3JlwTQ31PxX/+P?=
 =?us-ascii?Q?RA=3D=3D?=
X-OriginatorOrg: celeno.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5c489506-7515-4486-2f7c-08da639384d7
X-MS-Exchange-CrossTenant-AuthSource: AM9P192MB1412.EURP192.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jul 2022 23:17:26.8570
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f313103b-4c9f-4fd3-b5cf-b97f91c4afa8
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: OFEO06NJOOoJUiji0CYibabZsrvTJ/kmyntzNKx5EmrVSd/RUjnxbrmp4KBaRCYxHwXVSs3VM562JOFeL4wFLg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8P192MB0849
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-wireless.vger.kernel.org>
X-Mailing-List: linux-wireless@vger.kernel.org

On Tue, 31 May 2022 17:27:36 -0700, quic_jjohnson@quicinc.com wrote:
> in this file and in power.c you have multiple lookup tables that look 
> like they could/should be static to limit their scope to the current file 

Yes, thanks, it makes sense.

Best regards,
Viktor Barna