Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 11 Jul 2022 23:24:56 +0000
To:     Arend Van Spriel <aspriel@gmail.com>
From:   Danny van Heumen <danny@dannyvanheumen.nl>
Cc:     Arend van Spriel <arend.vanspriel@broadcom.com>,
        "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
        Franky Lin <franky.lin@broadcom.com>,
        Hante Meuleman <hante.meuleman@broadcom.com>,
        "ulf.hansson@linaro.org" <ulf.hansson@linaro.org>
Reply-To: Danny van Heumen <danny@dannyvanheumen.nl>
Subject: Re: [PATCH v4] brcmfmac: prevent double-free on hardware-reset
Message-ID: <LjavNS7FQVriCInc6oiPjdmmCyQgXWVsmHv_kiDNEJ1UXiSKuOpLVLEIbzhOPFY1eEza2BePSqwe7k59rNTgDPihwOdb9Kx77yb0ly0weQw=@dannyvanheumen.nl>
In-Reply-To: <768ee7d7-bbc1-b466-480d-de6390d26051@gmail.com>
References: <g_Py6bM1lfcJOWWmHwKU8x4tCFrTRdgFtoM13qYHeN441F392j_6etJnEJ8gHJMRZ6OEKxpJYuP45x3iziHqY6HNXnVwIiyvJLYjvzxT0Xk=@dannyvanheumen.nl> <a2d63d48-74bf-06e5-0b90-d046dd0966bd@gmail.com> <SpNFVBNIoAMOViIfL2pA_NfZkIX1ldRs865SC5DNvEzTfnDVAQALh3ugJVVMnWZ6XZDQI9L85yb0TEhzjKMTt8CjZuXW8mE-FY6GMSoWCs4=@dannyvanheumen.nl> <b9af59ff-d218-69d6-35b6-eedbd8a7eb6b@gmail.com> <aK4oYk4CE84W9CQcWokt10umUlVCVt4DUEHbuT1e6euFshQ5CC4Hu5svEL0qhPF6W-LYeu8-EUNMfc4odaYa-LyxofrBZt_6KhkiE0sfwp8=@dannyvanheumen.nl> <48f31e63-f4de-faf9-3c8c-eb2bdd8a2b04@broadcom.com> <Ev2sGFWgWlkty5T3AbZMd-KmLY_PJiasOdrKka6OuNmLFBSOet2lSDVUj8_x3lKuJ-lNLkAdDKwzkeS9rEIGLXb3RwDhrkBMyESbuTRcu90=@dannyvanheumen.nl> <768ee7d7-bbc1-b466-480d-de6390d26051@gmail.com>
Feedback-ID: 15073070:user:proton
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi,

------- Original Message -------
On Thursday, July 7th, 2022 at 22:25, Arend Van Spriel <aspriel@gmail.com> =
wrote:

> [..]
>
> Right. I prefer dropping the interrupt clean-up and rest of the patch is
> fine by me.

Please find patch v5 submitted. Subject: [PATCH v5] brcmfmac: prevent doubl=
e-free on hardware-reset

I have reverted the split, in-order freeing of func irqs, as discussed. No =
further changes.

During my time running with the various patches, I have not had any issues.=
 As mentioned before, repeated resets did not result in any issues. (I didn=
't count exactly, maybe 30+ resets in a scripted run.)

IIUC this should be ready for integration.

Regards,
Danny