Received: by 2002:ad5:4acb:0:0:0:0:0 with SMTP id n11csp3859106imw; Mon, 11 Jul 2022 18:02:12 -0700 (PDT) X-Google-Smtp-Source: AGRyM1viGplexqQCtaGvxGFcl/wSQvaDIAoyUPxU5kkNUSkdc+Ij89OwxtvODg+gxppOSc8k/Zbz X-Received: by 2002:a17:902:d2c1:b0:16b:f145:c5b3 with SMTP id n1-20020a170902d2c100b0016bf145c5b3mr21001928plc.4.1657587732404; Mon, 11 Jul 2022 18:02:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1657587732; cv=none; d=google.com; s=arc-20160816; b=UziHN0bIHj3INdvoTNI+JJ57i8nINl7gi6Wd+vbPM3iNOo924jvxQ3V34y8Sx9uZPR e4zQDrhz+znLOy9wlHymjEIUPxVZ4SqYXFX/l+XL2QGPj22LsJ99svwSZZU6M9zkZq75 sHbJPNHuC0/oqJxbFDyLiejqc8byLX/s957XV+lfMGBFfrOmdpYWvgV0bMp139DRqMzf frNHQoJkZB6DjYHOJ3VN8j9I34VfYDSF8DA5XaDRz+UxuzoqFWaWCLr6vSbcnyLdAC7t dOYcNjZo+0Nh0mXO8IQKQzqs9QWJgxVbVE+89MyzWGYCBG1DQXm8TUUEyekxkTrYPnJ8 gN2A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:references :cc:to:from:content-language:subject:user-agent:mime-version:date :message-id:dkim-signature; bh=0090zWVa2AslLxcfJGhjj/6B3Kyfvi31R8og1Hvh+gU=; b=z5Voz1ut08wE8wpajug12XDP+BFflFaP47uLbdmIq9EzL3WDI8JdtQ/vvGT6zGmWgJ ymxg6KtScai183l/7QF6yJdCHAmZowbk0gspkI7EO7riLllRJ5c1ekj+g7IT2QqVMgop gQG2gZN/hH9z6DkyTgn7b3HrHUJnS3emJgeaRB1S/zuBANYnGcpmbgzmggGQdwWYB/LN w2/G2YCHZjktEVdzhiXCCeWsriymVzUzvXfyoTcq6UVnheERvXPSXaurd38sD5q8UsTH tGSdJuhonHJuJoMXhqN1CMOfDh6kZMaIGxrPa1G37TfMtlA2z6KfL74gLLodtGM0v2El jGlg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcdkim header.b=NBiiF0iJ; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id f21-20020a656295000000b003fcaefeeec8si10715988pgv.115.2022.07.11.18.01.58; Mon, 11 Jul 2022 18:02:12 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcdkim header.b=NBiiF0iJ; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231490AbiGLA4F (ORCPT + 64 others); Mon, 11 Jul 2022 20:56:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55528 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229616AbiGLA4E (ORCPT ); Mon, 11 Jul 2022 20:56:04 -0400 Received: from alexa-out-sd-01.qualcomm.com (alexa-out-sd-01.qualcomm.com [199.106.114.38]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A2CD22A72C for ; Mon, 11 Jul 2022 17:56:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; i=@quicinc.com; q=dns/txt; s=qcdkim; t=1657587363; x=1689123363; h=message-id:date:mime-version:subject:from:to:cc: references:in-reply-to:content-transfer-encoding; bh=0090zWVa2AslLxcfJGhjj/6B3Kyfvi31R8og1Hvh+gU=; b=NBiiF0iJHBOmhZU8UwLkqBdXIKABiDgnDRNVfe3xL04gaQ0fH5jvAWdV Y6N0NOQZzN8+LEca5kDXAlcOODAWE1zuVfncbkMymQ6x7zFkA43H1cQM6 Mp3LcHZK1i2xPqQVfXIXxqy4h63uFtnDuTd4mkPTJqesyrbXVjlNTGvjo A=; Received: from unknown (HELO ironmsg04-sd.qualcomm.com) ([10.53.140.144]) by alexa-out-sd-01.qualcomm.com with ESMTP; 11 Jul 2022 17:56:03 -0700 X-QCInternal: smtphost Received: from nasanex01c.na.qualcomm.com ([10.47.97.222]) by ironmsg04-sd.qualcomm.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Jul 2022 17:56:03 -0700 Received: from nalasex01a.na.qualcomm.com (10.47.209.196) by nasanex01c.na.qualcomm.com (10.47.97.222) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.22; Mon, 11 Jul 2022 17:56:03 -0700 Received: from [10.110.97.41] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.22; Mon, 11 Jul 2022 17:56:02 -0700 Message-ID: Date: Mon, 11 Jul 2022 17:56:01 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH] nl80211: Fix reading NL80211_ATTR_MLO_LINK_ID in nl80211_pre_doit Content-Language: en-US From: Jeff Johnson To: Veerendranath Jakkam , CC: References: <1657517683-5724-1-git-send-email-quic_vjakkam@quicinc.com> <0d61898f-f17a-d8e5-a35d-8da85d7c973d@quicinc.com> In-Reply-To: <0d61898f-f17a-d8e5-a35d-8da85d7c973d@quicinc.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nalasex01a.na.qualcomm.com (10.47.209.196) X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On 7/11/2022 8:59 AM, Jeff Johnson wrote: > On 7/10/2022 10:34 PM, Veerendranath Jakkam wrote: >> nl80211_pre_doit() using nla_get_u16() to read u8 attribute > > I would be more explicit and say: > nl80211_pre_doit() is incorrectly using ... but I see this is already in wireless-next so nevermind :)