Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <07ad1a63-a922-aff6-75f1-4e66617602e0@quicinc.com>
Date:   Tue, 12 Jul 2022 10:41:55 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [RFC v2] ath11k: fix blocked for more than 120 seconds caused by
 reg update
Content-Language: en-US
To:     Abhishek Kumar <kuabhs@chromium.org>
CC:     <ath11k@lists.infradead.org>, <linux-wireless@vger.kernel.org>
References: <20220701072855.13655-1-quic_wgong@quicinc.com>
 <CACTWRwvispWNXAPGdUvAeRgLvUgFgb45+JTaOVX18mvhyQsQkA@mail.gmail.com>
From:   Wen Gong <quic_wgong@quicinc.com>
In-Reply-To: <CACTWRwvispWNXAPGdUvAeRgLvUgFgb45+JTaOVX18mvhyQsQkA@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 7/12/2022 1:54 AM, Abhishek Kumar wrote:
> This change will make the device come out of deadlock on rtnl_lock if
> that happens. Did you think of ways to completely avoid the race
> situation to occur ?
>
> Thanks
> Abhishek

You can see the commit log, if to completely avoid the race situation to 
occur,

then it need to change the rtnl_lock usage in many place in 
cfg80211/mac80211.

it will effect a lot things.


It has a change as below to reduce usage of rtnl_lock, but it does not 
remove the rtnl_lock in ath11k.

cfg80211: avoid holding the RTNL when calling the driver

https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git/commit/drivers/net/wireless/ath/ath11k/reg.c?id=a05829a7222e9d10c416dd2dbbf3929fe6646b89

>
> On Fri, Jul 1, 2022 at 12:29 AM Wen Gong <quic_wgong@quicinc.com> wrote:
...