Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <9803367be1f2e1a16c79dc6c413717db769941bf.camel@sipsolutions.net>
Subject: Re: [RFC v2 59/96] cl8k: add rates.h
From:   Johannes Berg <johannes@sipsolutions.net>
To:     Viktor Barna <viktor.barna@celeno.com>
Cc:     aviad.brikman@celeno.com, davem@davemloft.net,
        eliav.farber@gmail.com, kuba@kernel.org, kvalo@codeaurora.org,
        linux-wireless@vger.kernel.org, maksym.kokhan@celeno.com,
        oleksandr.savchenko@celeno.com, shay.bar@celeno.com
Date:   Tue, 12 Jul 2022 09:17:33 +0200
In-Reply-To: <20220711231755.2955984-1-viktor.barna@celeno.com>
References: <79365d0387a73baa82cf07c81637a622492ed9d6.camel@sipsolutions.net>
         <20220711231755.2955984-1-viktor.barna@celeno.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.44.3 (3.44.3-1.fc36) 
MIME-Version: 1.0
Precedence: bulk

On Tue, 2022-07-12 at 02:17 +0300, Viktor Barna wrote:
> On Thu, 26 May 2022 21:54:36 +0200, johannes@sipsolutions.net wrote:
> > that makes it sound like these are firmware things and should be endian
> > safe?=20
>=20
> Yes, it should, thanks! PS: can you, please, clarify whether it is ok to =
reply
> with =E2=80=9CACK=E2=80=9D for all comments, those does not imply anythin=
g special in response?
> Just to show, that we saw the comment and will take it into account. Or =
=E2=80=A6is it
> enough to mention that in RFCv3 changelist? We are grateful for the revie=
w!
>=20

From my POV, it's sufficient to list in the version changelog "addressed
comments from <person>" or so, not like in gerrit where you have to mark
as "ack"/"done" for each comment :-)

Of course if there's something where you disagree or want to solve it in
another way, it's probably easier to continue the discussion with that
comment instead.

johannes