Received: by 2002:ad5:4acb:0:0:0:0:0 with SMTP id n11csp430454imw; Wed, 13 Jul 2022 00:42:50 -0700 (PDT) X-Google-Smtp-Source: AGRyM1tIXuxM0mI+eEecmisYccbgi5aPwCcOU1XAoyvk4IVe6Fl9NH3rKa2lW8ThLjhhgdzyirVX X-Received: by 2002:a17:90a:7784:b0:1ef:c0fe:968c with SMTP id v4-20020a17090a778400b001efc0fe968cmr8683046pjk.26.1657698170743; Wed, 13 Jul 2022 00:42:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1657698170; cv=none; d=google.com; s=arc-20160816; b=TBInTRfumP1G1EZOtkg/4+Nf4F9F6c5Li+1so6YrArLmd02kcAcENF5ooDRBnSy/aE KKLk7JNRgEqv6q8Ycvls1B/qNz/fFk8EeQyWgHTAsJBG/rLhOUS0MhsYFVNEW104xnwC 1IOEuU/Fj71UGFxxIeW8QwWjuvkPE0XqwGiviz3uOV+X4qSQo5jsSTFOi5/XWDzaVeGO HBiHwlRbr+GpmEpU9J0N4yVPhckO/3dlQAwxWZITKK0czlpH+w6dcfs5baNtI6bCoWS8 1dtHVVyJs59aX57KrieyPAxGBuxHdv57rXW90mFvSgYHVRmmZgi7s6eyPr0eNzIGJIvj slug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:user-agent:message-id:in-reply-to :date:references:subject:cc:to:from:dkim-signature; bh=3xx8NmyN17FGIMbjJ5h+ngwDmkoxBnGlCC2QiypyI4U=; b=NBebkdcn02dxVYQlakfJN56y6IekHblhti1kUROt55s3qY6j5tHhp1+AiGf5Pqe8KY BHxvDZ69v7I16HjQAv4y4VRvpdz63RSz3UUd/Vqm/PwEpIhC4w7ZPXCWL/jZox88ZrmV r52496pPstY6DKudKfBvytSag2qGf/rWGIi4ZdujV/P85O2ciq2RMVLmExle5BOt8OGF HJ5sQsjfDZYU2prFwq7kJygPQ7QhoBatcOvOxtU6LhuZ/zs1UfHg6QjIPXpIEqzp1yMj LvxqwPj5QocWtdwXZaYYtyu9tDV5/AfJynZq2nPvgvX4W0qNIXWo7U6qQVkERzL7QcE9 LkWQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=lrP7oq6g; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id b9-20020a63d809000000b004126f260640si15310532pgh.128.2022.07.13.00.42.40; Wed, 13 Jul 2022 00:42:50 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=lrP7oq6g; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231277AbiGMHj6 (ORCPT + 65 others); Wed, 13 Jul 2022 03:39:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36098 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234695AbiGMHj4 (ORCPT ); Wed, 13 Jul 2022 03:39:56 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 33129E474F for ; Wed, 13 Jul 2022 00:39:55 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id D72EDB81D40 for ; Wed, 13 Jul 2022 07:39:53 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C4F6CC34114; Wed, 13 Jul 2022 07:39:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1657697992; bh=1LDaMlVzLp+e2V4+SwHZ0NnElrRAMcMfQgCMvL6oM9s=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=lrP7oq6gmUJTufv0oDM40COGNvnER1CsAwosA9BnnFx8SQavPNFHeuwrRjauTa2n6 4zOkOucV/kkRH6EW9ClMtMLggF+Lhw/yQ1JZZBveZsyBHTPGKC/UPSAmcIbgF/w5qU 5jk/G9jgy4Ccx4gcP8DFGSecaO6poZjTcmCYRHpW7MTXt42NlBn1A8IOrwH43s87+z 2pViqYJniNIs9AXmpL8IbGdcT7DaOWZQiRHeSlJHpu8G65RCfvI8/wRz9h7ORnUQBA ZsfiLisV8GyU4HYGi7kWuUYXkP0R2i1JpaeyNFgZ8nErrWqhf9MqsVNfXNd0eH+cGK TDNpsWnuhvSQg== From: Kalle Valo To: viktor.barna@celeno.com Cc: linux-wireless@vger.kernel.org, "David S . Miller" , Jakub Kicinski , Aviad Brikman , Eliav Farber , Maksym Kokhan , Oleksandr Savchenko , Shay Bar Subject: Re: [RFC v2 04/96] cl8k: add Makefile References: <20220524113502.1094459-1-viktor.barna@celeno.com> <20220524113502.1094459-5-viktor.barna@celeno.com> Date: Wed, 13 Jul 2022 10:39:46 +0300 In-Reply-To: <20220524113502.1094459-5-viktor.barna@celeno.com> (viktor barna's message of "Tue, 24 May 2022 14:33:30 +0300") Message-ID: <87o7xtmpfh.fsf@kernel.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-7.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org viktor.barna@celeno.com writes: > +cl-objs += \ > + wrs.o \ > + phy.o \ > + key.o \ > + sta.o \ > + hw.o \ > + chip.o \ > + fw.o \ > + utils.o \ > + channel.o \ > + rx.o \ > + tx.o \ > + main.o \ > + mac_addr.o \ > + ampdu.o \ > + dfs.o \ > + enhanced_tim.o \ > + e2p.o \ > + calib.o \ > + stats.o \ > + power.o \ > + motion_sense.o \ > + bf.o \ > + sounding.o \ > + debug.o \ > + temperature.o \ > + recovery.o \ > + rates.o \ > + radio.o \ > + config.o \ > + tcv.o \ > + traffic.o \ > + vns.o \ > + maintenance.o \ > + ela.o \ > + rfic.o \ > + vif.o \ > + dsp.o \ > + pci.o \ > + version.o \ > + regdom.o \ > + mac80211.o \ > + platform.o \ > + scan.o > + > +ifneq ($(CONFIG_CL8K),) > +cl8k-y += $(cl-objs) > +endif I don't understand why you need ifneq here. Please check how are other drivers (like iwlwifi) do it, Makefile can be really simple -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches