Received: by 2002:ad5:4acb:0:0:0:0:0 with SMTP id n11csp508263imw; Wed, 13 Jul 2022 02:48:18 -0700 (PDT) X-Google-Smtp-Source: AGRyM1ue+e2qguJPXUN+Utme3U4n3ebNzAFvONFXXd1XFgvSGiq6c3ECz6y/jpKz4mW2S1tpYoOw X-Received: by 2002:a17:902:aa82:b0:16c:4bee:1f90 with SMTP id d2-20020a170902aa8200b0016c4bee1f90mr2372120plr.69.1657705698066; Wed, 13 Jul 2022 02:48:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1657705698; cv=none; d=google.com; s=arc-20160816; b=nHplBO3xXBbKrVEWvT3Zwd2ZkF3pLGafs596VRS//yBxbzXpNci/q5m5C9RVateypS +7F6jB6///HvE7bCp1OGQVB5RWyUJBzdfqzLohXCHSQrC5tLUFawVSn7+2IRivYeT9Hz rYJ2MoSTFpTEljpqFwHUXUQk0cLgRL3zT3g0zs0RuP7t0PqTR5ohyrUL9wzF3JVK8j7d J9cmQvOfF5xibwSsbl5/sDr9rdAjsyolnHyfvlqcbvQ8meBwXKE1RKhFu/n3qFtDZDiD Wth83gqieYyauNqF37WcqcGPErpoITRlrwVWDuQjAbuKif3zkOLnuFAscGOmC+TYL1F6 bsJA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=xjpNZliAd/V9glIkDdcmRImIMhNmiwn12ErW+RTqh3w=; b=kJSKgijTMPH9po3I1PhsfVTWYXAbAIICont0tpBPLF5RPp5/m71Xm8RZfGDiHt+un8 8/oF0gLiXK5b7eMVscFcU8bcbR+dBKQ3HL5dkA2vZV1tViegayx93rXIBx+QgEWEqW0T e3BorzqZZTTPj845max/1wRSTAJ35mCCDqgbcCnYgw/sj2L3jNY2XvItGBrHB9w7/1vC 5UdrD4PjWP6ewtdoSxq1RYUlNxPUVxK7PM7g2okghnLbpt2VR9sZOqF8zda3Bn2V4+Wr 5pw0jsh/d6oKAsG7+ULJ+4nmDYHdKGPaqrA9f/A+pj2Z3QqlL/59730/+pcVZV5AdkkU CkVA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@sipsolutions.net header.s=mail header.b=CuJTEXQY; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=REJECT dis=NONE) header.from=sipsolutions.net Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id p1-20020a170902a40100b0016bee6785e3si15579128plq.35.2022.07.13.02.48.10; Wed, 13 Jul 2022 02:48:18 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@sipsolutions.net header.s=mail header.b=CuJTEXQY; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=REJECT dis=NONE) header.from=sipsolutions.net Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235800AbiGMJqP (ORCPT + 65 others); Wed, 13 Jul 2022 05:46:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36384 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235831AbiGMJp3 (ORCPT ); Wed, 13 Jul 2022 05:45:29 -0400 Received: from sipsolutions.net (s3.sipsolutions.net [IPv6:2a01:4f8:191:4433::2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DF068F6B90 for ; Wed, 13 Jul 2022 02:45:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sipsolutions.net; s=mail; h=Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Content-Type:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-To: Resent-Cc:Resent-Message-ID; bh=xjpNZliAd/V9glIkDdcmRImIMhNmiwn12ErW+RTqh3w=; t=1657705523; x=1658915123; b=CuJTEXQYYROqCze8Q0AdCyK0YDI8/wZHhAP3qQsMZVcr/eN +AS8YRpRmFUUjUN+G0lNORUhS21i5zSPqXNuScnF6Lau/lsROUivH+X0UN6XuWZBZVQbulEOdqHe7 MktBnd/3ZgWy4+ggI4nk3F+eQYF3LvJM1o5/zHEyTYBl/9To2CJLP7NUYJVA8fDyvSTsdfEoPF5gv suCG1XfjojZz6uelMyADjBu3ELx40zC/XOguwCpcGASj2hkIRdBfHbjDZsQ5RUIqfCDkAtVnSb2bK IO1fWYUSm6Hi1H7+UIaWTKwV4We06Qe+ej0LWUdLbYvN1XoDoVyrrpzdpzAwYlFA==; Received: by sipsolutions.net with esmtpsa (TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.95) (envelope-from ) id 1oBYvq-00EgvB-6J; Wed, 13 Jul 2022 11:45:22 +0200 From: Johannes Berg To: linux-wireless@vger.kernel.org Cc: Johannes Berg Subject: [PATCH 49/76] wifi: mac80211: don't set link address for station Date: Wed, 13 Jul 2022 11:44:35 +0200 Message-Id: <20220713114425.f1264fe770d8.I56a551890a5b416dc98f9e9547e75d88c6dfa744@changeid> X-Mailer: git-send-email 2.36.1 In-Reply-To: <20220713094502.163926-1-johannes@sipsolutions.net> References: <20220713094502.163926-1-johannes@sipsolutions.net> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org From: Johannes Berg We need to handle the link addresses for station differently, they will be determined by the association code, stored, and then applied when the links are actually created on success, cfg80211 will fill in the right addresses per the data we're sending back to it. Signed-off-by: Johannes Berg --- net/mac80211/iface.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/net/mac80211/iface.c b/net/mac80211/iface.c index 4b4a36692c68..fc5869f40279 100644 --- a/net/mac80211/iface.c +++ b/net/mac80211/iface.c @@ -409,9 +409,6 @@ static void ieee80211_link_init(struct ieee80211_sub_if_data *sdata, WARN_ON(!(sdata->wdev.valid_links & BIT(link_id))); break; case NL80211_IFTYPE_STATION: - eth_random_addr(link_conf->addr); - ether_addr_copy(sdata->wdev.links[link_id].addr, - link_conf->addr); break; default: WARN_ON(1); -- 2.36.1