Received: by 2002:ad5:4acb:0:0:0:0:0 with SMTP id n11csp3049372imw; Mon, 18 Jul 2022 00:39:23 -0700 (PDT) X-Google-Smtp-Source: AGRyM1vX7UYX6Qo7KEd5nzlFTUjLff0Dcn681UBkNttMKSMWrm2klpAQlSmQ1jNelbFLrOEFRb4+ X-Received: by 2002:a05:6a00:bcb:b0:52b:34e3:c043 with SMTP id x11-20020a056a000bcb00b0052b34e3c043mr17482247pfu.64.1658129963452; Mon, 18 Jul 2022 00:39:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1658129963; cv=none; d=google.com; s=arc-20160816; b=TICYjJ6Br/4uKwUprcMDlKeqxz51fwwx4yjcT47TgeQsxbJq5k+EMYAf7qPfZ2XSKm rfPmde1HSA1HDm6/BkOlZ4AsN/5sTtKzBL12jW+InPdGChKMSqE/qeN6xRTmKvTn2iB4 Z4VlZS20W6SBLGTmP4Xe8St6av7zhGOle58Cu7v1A2Jzys2R1SK9gZxHR+IRAac5s7+E GaJJEDkt+F4FPVW41DbzFkor5emsPR3IvPZj9RyucdLpiZAI6pR7HooaxCZFyBXUTxGP vT4eP869jA52jbMagKp+PbiIttZfbb+ndbl2GA99mKKuipIjvwy4VU0lS1WEmv5cVCwk 64UA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:message-id:date:user-agent :references:in-reply-to:subject:cc:to:from:dkim-signature; bh=A0m9YI3it4/go5um45qODoaPrGQ0Wg8laUaoI8n2Pqs=; b=NLrm10dZ5JJzOvc+JECprGrErtYjxkJGSIvh8jUNhoZecIb2L89fp43fmYX2gBsGv7 AqRk6Jk+4H0U9c6bjijBKMXAhsg4ltwoKDgrwHLwO2EHr1KpzRGWTb3+EVXftnAEGB+E qKItol3/f056IegnujsGboSoRpkxamfOJpeDQkHE/XEtpVQlLvRahmFrFqaTxxRj2h6z 8mHdQWKGg16amiZkcdYSHbuqslfhSiPBfMxDbGpD0QSVG9csLLJMd03MmWzp43LIJfn0 9yMa8dYLdFKMacQy4zaPGAvinHB2t8LP8yl5fcBENqvHWkqFN7dKB5jdbLRJfvRuoLBO wISQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=tLFu3ymi; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id 16-20020a630010000000b0041a1183a507si5706464pga.422.2022.07.18.00.39.11; Mon, 18 Jul 2022 00:39:23 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=tLFu3ymi; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233879AbiGRHb4 (ORCPT + 65 others); Mon, 18 Jul 2022 03:31:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56986 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233878AbiGRHbv (ORCPT ); Mon, 18 Jul 2022 03:31:51 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 25B6E1834B for ; Mon, 18 Jul 2022 00:31:51 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id B081061354 for ; Mon, 18 Jul 2022 07:31:50 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2ABD2C341CD; Mon, 18 Jul 2022 07:31:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1658129510; bh=g8HAlHQeDhXpBJg4ov/0sp2aRCVUjeBdLioC9+VWIGI=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=tLFu3ymiJ9zL/GML01HMxRJYqOS8Pz98comtGav+S9YADg0X06YVGBpmoHr8TcCmZ ltyLuJhEFaow+6yTDQrgSO5uQXg3kUhTzkb1oB6MMwxHGhQiBXuqQ33iVaEnAgavP6 0QVfb4xfVtc9CDvypuLiasCPZbi0XXnuaXBBr3tHUNsDDgKROQatxEwAECEXQbvwIn AzcOYBx/XC4rsPb71ngUGFsfmJP3LS1DJ/46bIWvPdh8aKQUE+UB9Jh41spwIcPpSf 0mVbjPIXuuPxvxsAYgR/kUq6amuXaYPaMI5LEdjcq4TA8KMnNTMftlS9XsBX2Fj1l+ Ou34IHBRbZH/Q== From: Kalle Valo To: Manikanta Pubbisetty Cc: , , "Maxime Bizon" Subject: Re: [PATCH] ath11k: Fix register write failure on QCN9074 In-Reply-To: (Manikanta Pubbisetty's message of "Fri, 15 Jul 2022 15:40:41 +0530") References: <20220608062954.27792-1-quic_mpubbise@quicinc.com> <87wncesne8.fsf@kernel.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) Date: Mon, 18 Jul 2022 10:31:46 +0300 Message-ID: <87r12iswpp.fsf@kernel.org> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-7.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Manikanta Pubbisetty writes: >> I refactored ath11k_pci_get_window_start() a bit, please check my >> changes here: >> >> https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git/commit/?h=pending&id=95094045d7f467aa8928307ea538d1fd9d15a239 >> > > Refactored code looks okay to me. Just one comment though, you may > probably remove initialization of "u32 window_start = > ATH11K_PCI_WINDOW_START;" in ath11k_pci_window_read32? It is removed > in ath11k_pci_window_write32. Good point, removed that now: https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git/commit/?h=pending&id=70fbceb8841910a2af9a392a6b1f4eb53c3a6716 -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches