Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <CAHmME9qrd25vfRYYvCWtPg+wVC5joEzzJiihCN+L4rqMfTL4Rg@mail.gmail.com>
 <20220719201108.264322-1-Jason@zx2c4.com> <87sfmwsu5l.fsf@email.froward.int.ebiederm.org>
In-Reply-To: <87sfmwsu5l.fsf@email.froward.int.ebiederm.org>
From:   "Jason A. Donenfeld" <Jason@zx2c4.com>
Date:   Tue, 19 Jul 2022 22:55:38 +0200
Message-ID: <CAHmME9r5B30Ts=DmME7A2NG31rXo77iAhSgufbxq2dY8WNJhgw@mail.gmail.com>
Subject: Re: [PATCH v10] ath9k: let sleep be interrupted when unregistering hwrng
To:     "Eric W. Biederman" <ebiederm@xmission.com>
Cc:     linux-wireless@vger.kernel.org, Kalle Valo <kvalo@kernel.org>,
        Rui Salvaterra <rsalvaterra@gmail.com>,
        Valentin Schneider <vschneid@redhat.com>,
        stable@vger.kernel.org, Gregory Erwin <gregerwin256@gmail.com>,
        =?UTF-8?B?VG9rZSBIw7hpbGFuZC1Kw7hyZ2Vuc2Vu?= <toke@toke.dk>,
        Herbert Xu <herbert@gondor.apana.org.au>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi Eric,

On Tue, Jul 19, 2022 at 10:51 PM Eric W. Biederman
<ebiederm@xmission.com> wrote:
> Acked-by: "Eric W. Biederman" <ebiederm@xmission.com>

Thank you.

> The whole design seems very strange to me.  I would think instead of
> having a current hardware random number generator the kernel would
> pull from every hardware random generator available.  Further that
> we can get a userspace read all of the way into driver code for
> a hardware random generator seems weird.    I would think in
> practice we would want all of this filtered through /dev/random,
> /dev/urandom, and the get_entropy syscall.

Yes indeed. In general, the hwrng interface is kind of badly designed
and a bit of a nuisance. I've spent the last few months reworking
random.c and that's finally nearing okay enough shape. Possibly after
I'll turn my attention to a real overhaul of hwrng too (assuming
Herbert gives me lattitude to do that, I guess; I don't maintain that
code). The main goal anyhow ought be to just non-invasively shephard
bits into random.c, with additional frills being merely additional.

Jason