Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   <Ajay.Kathat@microchip.com>
To:     <linux-wireless@vger.kernel.org>
CC:     <Claudiu.Beznea@microchip.com>, <Sripad.Balwadgi@microchip.com>,
        <Ajay.Kathat@microchip.com>
Subject: [PATCH 4/8] wifi: wilc1000: set station_info flag only when signal
 value is valid
Thread-Topic: [PATCH 4/8] wifi: wilc1000: set station_info flag only when
 signal value is valid
Thread-Index: AQHYnFIx4NLfwcl9sESOagg4tMRVTQ==
Date:   Wed, 20 Jul 2022 16:03:04 +0000
Message-ID: <20220720160302.231516-4-ajay.kathat@microchip.com>
References: <20220720160302.231516-1-ajay.kathat@microchip.com>
In-Reply-To: <20220720160302.231516-1-ajay.kathat@microchip.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?6jZNF0UNmqGHIdZIuFvyQEMhW4EusnnXiWtfzHY9rXEWOKfMFleFiDaGbn?=
 =?iso-8859-1?Q?oFsM8fJatKJuoonFodcUCoPcrFDFTI2OWUXU5sEnw9dkEk0NKvx7+c2817?=
 =?iso-8859-1?Q?Dx6FyxzGbf3KkfK8nZkWg5+y0jvjE0EkzbVJ/3zklfgSfYuj4asY+n17OR?=
 =?iso-8859-1?Q?bwaoZj1IzyeCoPlEkt9/XFBAjZL98CbzxxlXbSJqxb3zLXfWCsyKbn9UIj?=
 =?iso-8859-1?Q?mFdyxMZdSjcMKdgbfOYWkFmP74sA6ux4Ckohg1+J/Tylw3P2uL4p+Ailtz?=
 =?iso-8859-1?Q?SbEr9chhOhGwm2KIsYMwZ7816vAY0IiwfcCAGcvTLwYld0wgGQHtmejBe3?=
 =?iso-8859-1?Q?5lDUxZ2RvUnIUhaAmLXvVmeRIu4eiLxDr6Ev5yWlIbbU6E+6sEhSZKp9QX?=
 =?iso-8859-1?Q?k1CJDjXqx8t/qeHh51b3MYPp633fMLhVgW3+d+o+l+xruzAla5MYD3iIe+?=
 =?iso-8859-1?Q?d9HSjI0ExZxn8PDY+7M6ve8+X+5Os+bMeNv8627idZILTRWUvjk7ugBweN?=
 =?iso-8859-1?Q?50P1v+FSkaHWrtsv0bGoiw4ymWo/4jEVnP6f0GsA2uNLmzAJ0Zey2uB0ld?=
 =?iso-8859-1?Q?dYuJLY6xVcFMLzGDW1x6pDL4D/3rz0laW/MnZAJVskChqQLeINwcVywEht?=
 =?iso-8859-1?Q?QVwUsxVmKRCzZLWxs/Xo9yX+iu51Ris73HhjWyxTcDsDsac6p3lhwqbHG5?=
 =?iso-8859-1?Q?gHPY8Fh5wmrw5Hir8hLPbR/pxwrSn0B4Wjmy+bW/Crb4jAbPWBEFL1085d?=
 =?iso-8859-1?Q?56YyRuMuY+TVZZG97WW8MCVT3fObjPbnM/aD10pzcDUf0usmIdBUGlOxW+?=
 =?iso-8859-1?Q?aX9XHVc6ycwJeaxmctJJINMfgvpWLqanlSVduOoPZBf5qyHIuijEv6bCD2?=
 =?iso-8859-1?Q?sGSCAnsQVNUjsmsbtNTTlpc4g5SDDmd1Akx9SKYudRnCtYWSf406rScjom?=
 =?iso-8859-1?Q?CYYYOwR/2vquxqmhfSPC7f8iw9UGmemQwBqRbc2Jk+fKPC0dfHKXfHIt7n?=
 =?iso-8859-1?Q?z+8egMpHpWcqP1Zx6mKJJG4th2ECGEdLvyKunnEbv5d4cVWpQ4XWSVPSVo?=
 =?iso-8859-1?Q?/PWp5Wc5VSLEOiIZwv3ys7OtvmbGdN/1OSiDqnha0KpmYGoevHi1/IriTn?=
 =?iso-8859-1?Q?hLZKYlewxAYKvnzf18M9r/MrN6OSi4gRt4CT+SzMf9jCZGcDbKJzPFsTR8?=
 =?iso-8859-1?Q?Q8XwgJrAKqTv4vzW+aC8w9dTr2N+V+qvPaNMH7zOAx27btCuvcQJvmvAC2?=
 =?iso-8859-1?Q?OZIJ4dKcMPoQOQsmqOJPHAFDX0xzyz9ohqrm5CvkLCJ3DvnahUwNkH33/h?=
 =?iso-8859-1?Q?GPjiRZGqyKP4snhWf5FybH4CwyuHKnWL/No7pCD8NvUsB/GsYUAarGYlGE?=
 =?iso-8859-1?Q?OiZaPz3Z/3fGRbmHK+Gmg6h2cbJ4tuCKYGQPOSGN8GJ0o/fJQ8DlK748i8?=
 =?iso-8859-1?Q?kNGR62kaj2SQYObIfFYwTx6WRd+PKXkKQaz8bkkU8VvYGa9F1/qjHYaazB?=
 =?iso-8859-1?Q?GhW2zQsFt0/jZO25IcQUlXEfDOST0p74zDsSIC0YVYeo70Q4ex1t9qRSQL?=
 =?iso-8859-1?Q?GIjbdzVmnsSuBWeWT+TLsgPyegBVIfVELGd9YXdoiycGM2sjFYtOZvZeP2?=
 =?iso-8859-1?Q?HC3IMFWWpi6SxTlo40qXwwAk3D9zhZRwUQz/nd3lpVnUXdTYFZICX/7YI4?=
 =?iso-8859-1?Q?ehKNZ53KcR13K58ezSc=3D?=
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5176.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 40058d9d-938c-4703-6e05-08da6a695490
X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Jul 2022 16:03:04.2959
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 3f4057f3-b418-4d4e-ba84-d55b4e897d88
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: S28IYio57SWTrjzkRzKyUoMGyoceh2flyM+EEk5czHk8slr5TJLtbaraiqkIXoOwQrFeBhgFb78TXkXiZWeuafcEzxFOlG7duUCufjT9B6M=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB4174
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,
        SPF_PASS autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-wireless.vger.kernel.org>
X-Mailing-List: linux-wireless@vger.kernel.org

From: Ajay Singh <ajay.kathat@microchip.com>

Set station_info->filled to indicate signal level only when its value is
received successfully using wilc_get_rssi().

Signed-off-by: Ajay Singh <ajay.kathat@microchip.com>
---
 drivers/net/wireless/microchip/wilc1000/cfg80211.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/net/wireless/microchip/wilc1000/cfg80211.c b/drivers/n=
et/wireless/microchip/wilc1000/cfg80211.c
index 19862d932f1f..1e184ac93afa 100644
--- a/drivers/net/wireless/microchip/wilc1000/cfg80211.c
+++ b/drivers/net/wireless/microchip/wilc1000/cfg80211.c
@@ -1312,12 +1312,11 @@ static int dump_station(struct wiphy *wiphy, struct=
 net_device *dev,
 	if (idx !=3D 0)
 		return -ENOENT;
=20
-	sinfo->filled |=3D BIT_ULL(NL80211_STA_INFO_SIGNAL);
-
 	ret =3D wilc_get_rssi(vif, &sinfo->signal);
 	if (ret)
 		return ret;
=20
+	sinfo->filled |=3D BIT_ULL(NL80211_STA_INFO_SIGNAL);
 	memcpy(mac, vif->priv.associated_bss, ETH_ALEN);
 	return 0;
 }
--=20
2.34.1