Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Sender: Larry Finger <larry.finger@gmail.com>
Message-ID: <741dc563-4702-2004-4be0-01a578524747@lwfinger.net>
Date:   Wed, 20 Jul 2022 15:39:03 -0500
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [PATCH] b43:do not initialise statics to 0.
Content-Language: en-US
To:     Xin Gao <gaoxin@cdjrlc.com>, kvalo@kernel.org, davem@davemloft.net,
        edumazet@google.com, kuba@kernel.org, pabeni@redhat.com
Cc:     linux-wireless@vger.kernel.org, b43-dev@lists.infradead.org,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20220720194245.8442-1-gaoxin@cdjrlc.com>
From:   Larry Finger <Larry.Finger@lwfinger.net>
In-Reply-To: <20220720194245.8442-1-gaoxin@cdjrlc.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 7/20/22 14:42, Xin Gao wrote:
> do not initialise statics to 0.
> 
> Signed-off-by: Xin Gao <gaoxin@cdjrlc.com>
> ---
>   drivers/net/wireless/broadcom/b43/main.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/wireless/broadcom/b43/main.c b/drivers/net/wireless/broadcom/b43/main.c
> index 17bcec5f3ff7..5e233d0e06c0 100644
> --- a/drivers/net/wireless/broadcom/b43/main.c
> +++ b/drivers/net/wireless/broadcom/b43/main.c
> @@ -105,7 +105,7 @@ int b43_modparam_verbose = B43_VERBOSITY_DEFAULT;
>   module_param_named(verbose, b43_modparam_verbose, int, 0644);
>   MODULE_PARM_DESC(verbose, "Log message verbosity: 0=error, 1=warn, 2=info(default), 3=debug");
>   
> -static int b43_modparam_pio = 0;
> +static int b43_modparam_pio;
>   module_param_named(pio, b43_modparam_pio, int, 0644);
>   MODULE_PARM_DESC(pio, "Use PIO accesses by default: 0=DMA, 1=PIO");

Acked-by: Larry Finger <Larry.Finger@lwfinger.net>

Thanks.

Larry