Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <CAHmME9qrd25vfRYYvCWtPg+wVC5joEzzJiihCN+L4rqMfTL4Rg@mail.gmail.com>
 <20220719201108.264322-1-Jason@zx2c4.com> <xhsmhfsisgbam.mognet@vschneid.remote.csb>
In-Reply-To: <xhsmhfsisgbam.mognet@vschneid.remote.csb>
From:   "Jason A. Donenfeld" <Jason@zx2c4.com>
Date:   Fri, 22 Jul 2022 22:13:09 +0200
Message-ID: <CAHmME9pEvr_F2C9cG4qNSCc91a7YAAquW7Jqczcgn2fr_vA4Ow@mail.gmail.com>
Subject: Re: [PATCH v10] ath9k: let sleep be interrupted when unregistering hwrng
To:     Valentin Schneider <vschneid@redhat.com>
Cc:     linux-wireless <linux-wireless@vger.kernel.org>,
        Kalle Valo <kvalo@kernel.org>,
        Rui Salvaterra <rsalvaterra@gmail.com>,
        "Eric W . Biederman" <ebiederm@xmission.com>,
        stable <stable@vger.kernel.org>,
        Gregory Erwin <gregerwin256@gmail.com>,
        =?UTF-8?B?VG9rZSBIw7hpbGFuZC1Kw7hyZ2Vuc2Vu?= <toke@toke.dk>,
        Herbert Xu <herbert@gondor.apana.org.au>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi Valentin,

On Fri, Jul 22, 2022 at 10:09 PM Valentin Schneider <vschneid@redhat.com> wrote:
> I had initially convinced myself this would be somewhat involved, but
> writing the above I thought maybe not... The below is applied on top of
> your v10, would you be able to test whether it actually works?
> It does however mean patching up any sleeping hwrng (a quick search tells
> me there are more, e.g. npcm-rng does readb_poll_timeout())

I'm not able to test this easily, no (I don't own any hardware), and
I'm not going to put in the effort to rewrite/audit every sleeping
hwrng. That's not a good use of time, given the numerous other
problems the framework has (briefly discussed with Eric). Instead,
maybe at some point I'll look into overhauling all of this so that
none of this will be required anyway. So I think v10 is my final
submission on this.

But if you'd like to attempt more comprehensive changes throughout the
tree on all the drivers and do something large, I guess you can do
that independently (since you mentioned your thing works on top of
v10). And this way v10 still exists to fix the actual bug that's
currently reeking havoc. On the other hand, maybe don't bother, and we
can look into fixing the whole rats nest properly in some months when
I'm more motivated to jump into hwrng.

Jason