Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <6daefd60-dcbc-06e1-8091-ea225690edf8@amd.com>
Date:   Sat, 23 Jul 2022 07:09:11 -0500
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [PATCH 0/4] ath11k: Enable low power mode when WLAN is not active
Content-Language: en-US
From:   "Limonciello, Mario" <mario.limonciello@amd.com>
To:     Manikanta Pubbisetty <quic_mpubbise@quicinc.com>,
        ath11k@lists.infradead.org
Cc:     linux-wireless@vger.kernel.org
References: <20220720134959.15688-1-quic_mpubbise@quicinc.com>
 <ad99d238-dc1a-3233-fc6b-0cd49e428903@amd.com>
In-Reply-To: <ad99d238-dc1a-3233-fc6b-0cd49e428903@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cW9wR01aVDE4SXVycXdKT3ZsVlhWZ0ZqcTMvRmpCRm0yRGhJTUVpM0hyZnk3?=
 =?utf-8?B?eFlmVEs4d2l3dGdQVDcycFNJKzVtQ3hHcW9uOTFIelJjQndRVmVLODVQNDZs?=
 =?utf-8?B?UUozUDIzNm9GaUNhNmVKVSt6cmp4c0VTWHYvTmFEdUtIbkZxZVBqZDFkRUVq?=
 =?utf-8?B?MzU0NHJPREw1d0JCaHc5clBweDdHUm8vZ1RDME52N1RYK1ZLN1dxZ3I2UXpV?=
 =?utf-8?B?bStXbkxwYlJnL1hrLzFVSVhyb095dSt2cm1kUmFFSWliUzJVUERZQ2tlMTIv?=
 =?utf-8?B?TkhBb1BCUHBLNisxaW9JR0FTZ2RWUnE2bExvaDY2MTh0WDF1TVFmTkEzWjVY?=
 =?utf-8?B?Y1BMTDVVRzJSNStUaU5XMCtRKzFjTWNLWFF4MEVXNU1pMkdyT0lZVEMxR2Rr?=
 =?utf-8?B?K3hIb0RudVd5ckkrK25tUFZVT0RpWDdtT0M3UUl3azQ4Y3FBWlhWSk91OHdR?=
 =?utf-8?B?b2hCQmJvdFdJYndZTVFrZTQ2UGppaDB1Y3NKVkVxK04vV2phRHVsSThSMndQ?=
 =?utf-8?B?bTU4N05uMUh2VWJwaklIWXROQnFmQVZyQTVWS1U2Z0loQWJ6d0VGK1ExQUp1?=
 =?utf-8?B?MjlKQWYxK3FWbGpXTzU5V3BQVzlRUXM5bnVmOURHcm5WVlYxQnQzVTJ0SEpk?=
 =?utf-8?B?K3dBR0cvRUZ6bHcwV2tmWkVpZ2dCVVNhZ0U4aHN5ekw4MGpFSWNyT3l0QldW?=
 =?utf-8?B?M1YxKy9jS0t6UnFDaFJrSG8wSjFSZWFCVityMXJJMWYxam0rWGJMQ0xnZFpD?=
 =?utf-8?B?WE8rQnc5SytKYzJnVHhlaWVIK0cvYnpWbzhLVjRLMmdxYXZhZnlwR0F2ZGZn?=
 =?utf-8?B?aUpZVllWNkdUVDdFeVlNcWlIM2Z3QU92RmtFWWs4TGpJZ0hZdjgzUFFNQ0dC?=
 =?utf-8?B?YThORE9QZGtZSjI5ekxqOUFKWUFXbGJHa3FSSUhSK1BoMFBPMExyODRlMWNL?=
 =?utf-8?B?bzVrT0tpeGZsV3RlRENQRnAwT0cxcGwrdHV1dGl3RzNsT1FMV2pIRFdnV0Qy?=
 =?utf-8?B?RHVCN0FvcEYzWm9Cb1FXYkZ0WHZZaVNnamZpeWR1M0VBS3F2SEJlZVc0dHpj?=
 =?utf-8?B?SWFNS2hwaGMwZ1crbUo5UjNYZEI3M3FTMmtFM1NabDVSVEtoMnpUNDYzaFNt?=
 =?utf-8?B?bXpwOTRjcXozbFRXWFU0azVsdVpyaEJpVG94bStZUG9mZHJDUk9YKzFPV3R4?=
 =?utf-8?B?TFRTb3ZhV3B0cngvZ0RoZk1HWkpFaTJPVUpvMWhNNTBFLzBvQkpJRHRuSU1B?=
 =?utf-8?B?VTliM2pRQ2R1bHNoWjBITUhTZzFGMnBCKzk1akFNR1BXYVN4cWJWVUxWWDY2?=
 =?utf-8?B?Q2NqVURoTHF2b2w0cFVBS3diS1Jpa0VqbmVzYXRwcWRNbitjZzQ3YW92WUFQ?=
 =?utf-8?B?cGR3S2JEN0hBSTJrTTJzbWhGUjdFcWRwSGsrSlROUStGN0NTc2RHK0ZPWndn?=
 =?utf-8?B?Qk5NaFJJSmVjVnF3YmdibXFMRzRrVmhSZktXblpUWmVMVlJDN1FBNEVXd2dT?=
 =?utf-8?B?RUZtQk4zMGVLYTlWcktpemR3L3l0WWNrTjgrdld1VzY5QS9EM0lzRUx5VkJN?=
 =?utf-8?B?Vlg2N0FReS9pS1lLODhQSXBBNXlkWGZyNW4wWjVIMGlhUDU0VTZVRGhmMU02?=
 =?utf-8?B?RWoydlJHQS9vd1RvOUdqa0xBeHlZaUt4V1RNVTkvQ3F4bTRBUFhmVEdzeUVT?=
 =?utf-8?B?V09WTjIwaGNIZ1A1TWl0OE90ZjdOaGVpYk91UzgwUVRoak1ubVlWRWlpcDln?=
 =?utf-8?B?L1REbzJZM1l4QUZDbjVLaHN6UW5NSUROcjlhS3lMdkxxeU1uUE1BSzhUWHNw?=
 =?utf-8?B?WGVnbXJNMU0xU1NaOHJZVEZKSnN4MEYwTkU5N2poZFFJaWdYekMyaWFyeUgx?=
 =?utf-8?B?QmM0Wmw5TmY3OVRDU05yZnFHSWRyRWtKTHZnYWtISXoxampWWE1ZRWZ2M2pQ?=
 =?utf-8?B?dndqRnQ3eExQZjNXWjkxMytUckZZUnptYzlIM2ZkQ2NWRUJMZ1pkZGUxTXow?=
 =?utf-8?B?UDgyd2dxdFU5OURZbGV4T2E4eXZMOVlCMkFsOFVhditWRU1tbHcyM0lUc0RQ?=
 =?utf-8?B?dzd2MzFqOGlhZS9Qdm1MOTJPYzZHMVJnNkhHL3RUMGwySExCQWowcEdMREdE?=
 =?utf-8?B?cytNamtLOEFLWTk5NHYxYkhXNVNQeDNrZy92S0RPT1VVK1NjcmMzZXArMW5x?=
 =?utf-8?Q?creuKVVqCySgpscET8hbzZ52BBLWUPYX7SrwPKllm1Fp?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 871fbe43-56aa-4ea8-4715-08da6ca42839
X-MS-Exchange-CrossTenant-AuthSource: MN0PR12MB6101.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Jul 2022 12:09:13.3968
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 3UmHDJSLpMdH7+lBVkQwYN440hvJyoE5DLfcnxM5MDGniVp839XT2hu0P9La95skmDuexb6Vjnu/YsgAXRKOhQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR12MB4922
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-wireless.vger.kernel.org>
X-Mailing-List: linux-wireless@vger.kernel.org

On 7/22/2022 17:00, Limonciello, Mario wrote:
> On 7/20/2022 08:49, Manikanta Pubbisetty wrote:
>> Currently, WLAN chip is powered once during driver probe and is kept
>> ON (powered) always even when WLAN is not active; keeping the chip
>> powered ON all the time will consume extra power which is not
>> desirable on a battery operated device. Same is the case with non-WoW
>> suspend, chip will not be put into low power mode when the system is
>> suspended resulting in higher battery drain.
>>
>> Send QMI MODE OFF command to firmware during WiFi OFF to put device
>> into low power mode.
>>
>> Tested-on: WCN6750 hw1.0 AHB WLAN.MSL.1.0.1-00887-QCAMSLSWPLZ-1
>>
>> Manikanta Pubbisetty (4):
>>    ath11k: Fix double free issue during SRNG deinit
>>    ath11k: Move hardware initialization logic to start()
>>    ath11k: Enable low power mode when WLAN is not active
>>    ath11k: Fix failed to parse regulatory event print
>>
>>   drivers/net/wireless/ath/ath11k/core.c | 237 ++++++++++++++++++-------
>>   drivers/net/wireless/ath/ath11k/core.h |   8 +-
>>   drivers/net/wireless/ath/ath11k/hal.c  |   1 +
>>   drivers/net/wireless/ath/ath11k/mac.c  |  33 ++--
>>   drivers/net/wireless/ath/ath11k/reg.c  |   2 +
>>   5 files changed, 189 insertions(+), 92 deletions(-)
>>
> 
> This series looked potentially promising to me for a problem that I'm 
> seeing on a notebook failing to sleep where WLAN_WAKE is asserted on the 
> WCN6855 on resume even though WoW wasn't set at all.  This is 
> problematic as it causes a spurious wake while SUT is reading from the 
> EC since two IRQs are now active and the kernel wakes from that.
> Removing the WCN6855 from the system it doesn't happen.
> 
> I figured I'd give it a spin to see if it improved things.
> I applied the series on top of 5.19-rc7 and it applied cleanly but I get 
> timeouts on wlan card init (and of course suspend fails now too).
> 
> Here's the mhi/ath11k_pci snippets:
> 
> [    2.864110] ath11k_pci 0000:01:00.0: BAR 0: assigned [mem 
> 0xb4000000-0xb41fffff 64bit]
> [    2.864901] ath11k_pci 0000:01:00.0: MSI vectors: 32
> [    2.864912] ath11k_pci 0000:01:00.0: wcn6855 hw2.1
> [    3.106892] mhi mhi0: Requested to power ON
> [    3.107054] mhi mhi0: Power on setup success
> [    3.198178] mhi mhi0: Wait for device to enter SBL or Mission mode
> [    3.971019] ath11k_pci 0000:01:00.0: chip_id 0x2 chip_family 0xb 
> board_id 0xff soc_id 0x400c0210
> [    3.971025] ath11k_pci 0000:01:00.0: fw_version 0x11080bbb 
> fw_build_timestamp 2021-12-16 03:42 fw_build_id 
> WLAN.HSP.1.1-03003-QCAHSPSWPL_V1_V2_SILICONZ_LITE-2
> [    4.290328] ath11k_pci 0000:01:00.0 wlp1s0: renamed from wlan0
> [    4.308760] ath11k_pci 0000:01:00.0: Failed to set the requested 
> Country regulatory setting
> [    4.309028] ath11k_pci 0000:01:00.0: Failed to set the requested 
> Country regulatory setting
> [   14.386201] ath11k_pci 0000:01:00.0: qmi failed wlan ini request, err 
> = -110
> [   14.386210] ath11k_pci 0000:01:00.0: qmi failed to send wlan fw ini:-110
> [   14.386214] ath11k_pci 0000:01:00.0: failed to send firmware start: -110
> [   14.386243] ath11k_pci 0000:01:00.0: failed to start firmware: -110
> [   14.386266] ath11k_pci 0000:01:00.0: failed to setup device: -110
> [   14.386300] ath11k_pci 0000:01:00.0: failed to start device : -110
> 
> And so - on.
> Is it functionally dependent on other patches in linux-next or another 
> tree I won't see in 5.19?

I had a try with linux-next and your series but I reproduce the same 
failure I described above.

ee3a066e4f4e (HEAD) ath11k: Fix failed to parse regulatory event print
4f850f1e26dc ath11k: Enable low power mode when WLAN is not active
e320c8ef9841 ath11k: Move hardware initialization logic to start()
dbc26036c1ef ath11k: Fix double free issue during SRNG deinit
18c107a1f120 (tag: next-20220722, linux-next/master) Add linux-next 
specific files for 20220722