Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 25 Jul 2022 09:34:10 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Ammar Faizi <ammarfaizi2@gnuweeb.org>
Cc:     Kalle Valo <kvalo@kernel.org>, Kalle Valo <quic_kvalo@quicinc.com>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Johannes Berg <johannes.berg@intel.com>,
        Linux Wireless Mailing List <linux-wireless@vger.kernel.org>,
        netdev Mailing List <netdev@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        GNU/Weeb Mailing List <gwml@vger.gnuweeb.org>,
        llvm@lists.linux.dev, kbuild-all@lists.01.org,
        kernel test robot <lkp@intel.com>
Subject: Re: [PATCH] wifi: wil6210: debugfs: fix uninitialized variable use
 in `wil_write_file_wmi()`
Message-ID: <20220725063410.GO2316@kadam>
References: <202207250332.5ud26AGE-lkp@intel.com>
 <20220724202452.61846-1-ammar.faizi@intel.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220724202452.61846-1-ammar.faizi@intel.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?dU8W89Hu4oCQ2CiuSiHb3C4Bf2PnGmtWBzpDAwVhbdyq53kGzhQLn974g2Dt?=
 =?us-ascii?Q?4ZfIImfePy823pyyCOY8IVubKFoLn3RTPUJnSGgr+B5/7DfDclaUw1aqo23Q?=
 =?us-ascii?Q?VgPrpu4u6d21j39LI3wMoRCvgwYJqp/7JzNtNHvgq6uqLOU5rLF+RF9eu218?=
 =?us-ascii?Q?68UzLgHzPZ3508WestJC9PJNHy//5ABRfN6I9X/FFB4OmSmb5rSEs8kE727R?=
 =?us-ascii?Q?vCiuEW1gKXOGJKjudGwanbOylxQjyV/BmeWLoM1VF26K0V+QqjP56G8t1t2t?=
 =?us-ascii?Q?DBi3hSpK25MeJeVRfT+oiRP8R6w/2OYQJptsVymsQgBi067ZMV6kUsFcquPv?=
 =?us-ascii?Q?WJ98wtSNxndcxRJl3fsaqSejudjKqq+AkenxkjmH39RhdTQwWa7kA2amXCkS?=
 =?us-ascii?Q?ceWlcgM2C+rpggw7Wg/nILsrqWeWE6q0uHBbCHDX4E7m3TbD+QVUFUogVh6B?=
 =?us-ascii?Q?IFXeDq5GoQtgZuDIfbMT1432R7FUPyuW+a2bMQFhigq+THWnOirKq3ZdVUCM?=
 =?us-ascii?Q?T/4dkxa6I7WZCJ46P0TYf9aEMB0tqsnHGCAVW4BoplvT19sHB1MB/EyRwnC1?=
 =?us-ascii?Q?iYQOexlEM+6WihrR/csZmv6iNSVb+mRo6lkS2xxTf7vvkwFmOdh4TylxZTWm?=
 =?us-ascii?Q?q7rHY77pRDj8ZEr1WUS2r4ioSC5onRXnP+Ad8yZswJX+K0MHv1w32R3UrK8W?=
 =?us-ascii?Q?95ZiCojIA1dt8BR/mNHRNv0X8W2Tm0QbfsgjYiF4K6jXNy7ESKBbCeBMXpD5?=
 =?us-ascii?Q?VTalxWhfOFgvGYkxfoiTyyKI3+GJ4awShjnnOA9PItw0o19TUyz2L+jNa5Li?=
 =?us-ascii?Q?5C019nY1vzv0bUax+4QC3Ihb0bi+qaJbpbq7XhFa3QJKHpLUiJmeqNVail93?=
 =?us-ascii?Q?KRkTunRIu7kdqrKo1gNizH9/OnIxt/1d72UvqLPTaHEs0LtqPy/DQEcUElxr?=
 =?us-ascii?Q?IFQGdlwc8w5wd+48bG5I2PmcmJZKoWfbnDaStugq8hTt4sBnnc4r8CcEkknH?=
 =?us-ascii?Q?AKKQWPM7WU2tLLTPa0u6Q6WpHD2o0QF+ed9te/+J+Ebkudv41w9g/a7DQFLY?=
 =?us-ascii?Q?lKKI2uigQiKrCYi/du6sRgJljV7fxB1ezqA4AF5IeUDW840XWlgDXrE6EN2t?=
 =?us-ascii?Q?EW7v23vFsW37+Gqlt5GOBe6HqJzHY3tbgo8DVjAxAhoX51RKPfvqAdj9AFRd?=
 =?us-ascii?Q?1WjEasKJubsYGedFddZ0YijVUW0w0HXENbf7HaKl35IU8cZs8zcgBoiZoByp?=
 =?us-ascii?Q?vAoH/OgZYm7M18cQ5lTSfQVA11ouhnP6mP4f4Jv8c/Uj84LBWR6f2sJc9PIf?=
 =?us-ascii?Q?LQJyk7ThLAxAQZKm8gOl/1UABOIiMUFL/W2tzRmz2O+dEZEUKyr833+L8STl?=
 =?us-ascii?Q?FanauAa66t20radDHZajeSGGNmxfxEfYwFkJVzjLKasUYxnV31rd2vUjpjO6?=
 =?us-ascii?Q?WGRibayVt12OseJYQ8XHyHFzxSp7nSnJCbtdG/OGvGumCyEb1h7Ms9Zzu3+z?=
 =?us-ascii?Q?AkCqPnrjrF/kwubjKPv2MzeAYsjET11DOAm0/H+sqsuO4qH5sSGSDOgYRtkS?=
 =?us-ascii?Q?E/TLBVUS5bR2ujngvTMmegn89oooxMHGPfWEWimf?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3c32f5ae-f7b3-42fb-e762-08da6e07b6b1
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Jul 2022 06:34:23.8878
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: zurXpY+xR2+O3VCq12s6navRVOqVpjW96QAcc61RreTiV98CZ175WN3+HxA9nqEgqjnTR1OnByDNMchCLF6xC98kUR12UQkLA99sEdmDcPQ=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR10MB1313
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.883,Hydra:6.0.517,FMLib:17.11.122.1
 definitions=2022-07-23_02,2022-07-21_02,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 malwarescore=0 phishscore=0
 spamscore=0 mlxlogscore=999 suspectscore=0 bulkscore=0 adultscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2206140000
 definitions=main-2207250027
X-Proofpoint-ORIG-GUID: kz-mboZuM1_4JiFk8hT10DtbaM-CEOgl
X-Proofpoint-GUID: kz-mboZuM1_4JiFk8hT10DtbaM-CEOgl
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-wireless.vger.kernel.org>
X-Mailing-List: linux-wireless@vger.kernel.org

On Mon, Jul 25, 2022 at 03:26:18AM +0700, Ammar Faizi wrote:
> Commit 7a4836560a61 changes simple_write_to_buffer() with memdup_user()
> but it forgets to change the value to be returned that came from
> simple_write_to_buffer() call. It results in the following warning:
> 
>   warning: variable 'rc' is uninitialized when used here [-Wuninitialized]
>            return rc;
>                   ^~
> 
> Remove rc variable and just return the passed in length if the
> memdup_user() succeeds.
> 
> Cc: Dan Carpenter <dan.carpenter@oracle.com>
> Reported-by: kernel test robot <lkp@intel.com>
> Fixes: 7a4836560a6198d245d5732e26f94898b12eb760 ("wifi: wil6210: debugfs: fix info leak in wil_write_file_wmi()")
> Fixes: ff974e4083341383d3dd4079e52ed30f57f376f0 ("wil6210: debugfs interface to send raw WMI command")
> Signed-off-by: Ammar Faizi <ammarfaizi2@gnuweeb.org>

Oops.  Sorry!

Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>

regards,
dan carpenter