Received: by 2002:ac0:da4c:0:0:0:0:0 with SMTP id a12csp2625432imi; Mon, 25 Jul 2022 04:00:37 -0700 (PDT) X-Google-Smtp-Source: AGRyM1sjTVW1lPISxRfnJg58bASdFxi6sGyTUQWiSOZntcftgKRTUttz32Mg7H+2dV94rY0o8Fwl X-Received: by 2002:aa7:c752:0:b0:43b:a03d:d3d3 with SMTP id c18-20020aa7c752000000b0043ba03dd3d3mr12295438eds.401.1658746837029; Mon, 25 Jul 2022 04:00:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1658746837; cv=none; d=google.com; s=arc-20160816; b=mfWQDEkIecNmHb5PzeJjNhfSiORlmhRtS4XpPLBz5QecUtVt6Reg1wffnTFnRG+QHd BKVYvIgBrznujhnC3q1qkeWdAGQesG2igFdBksdt9mOK8XuiLZKsTnuGxeEEC6GPPZBV +A2nTSfhFBMDphslABxP61OV/kXWx7MWbOvV2ZDDtLG4BE/rG3DDfh50SBk8I3/eHV84 cC2MxgYdQIQaupZsXUQhCNh/Smr4/U/w38yhj0V59HHzRKMtgMFYIcWtR9HsZupEfZUq ZADYZduHGPuPDFFVtxrZq5eVZUjcGXZ+2NZM6Q7bHtD3dEaBDTjFpSLYXBNntXFHTxv+ k5wg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=F1Wh6MbofPDcjdJvO5IFaKO/tiY/mOSAXYz5Qaq5dP8=; b=Co0/P1PepZDRKT7mUVSZh/uPtk342ICH8zinjnEnqmcVOZCx7ErEiFvhKiOgKKX9iB 3DQ9von/G8ueSxeSTaUc3+6qzWbDElmh/9p8H6mXTjbg8BXr2A4s4y0qvNWFazBCAcBY fCZ3YZbnhIbDjfiDMsNIihQqWROYmSJ62vWvdB0ezn/AmqTQsFH/MzdJoJLTqJC727Oh 4Jo5ykx+XSYCXXiOfCGFfD7ru+z13B7rxPKOs2CKDApCMlBOznZep3JWqaF6WynPSdvi vcfocN9DR6XlSJQFvnKHU3NWt0ZAQdgsi0N7EfmNPVMFY5/0GFzlkM+ll0oLqWBM0aiW WnNg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=cNv7NE9N; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=collabora.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id o16-20020a056402439000b0043be994be69si4443714edc.587.2022.07.25.04.00.20; Mon, 25 Jul 2022 04:00:37 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=cNv7NE9N; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=collabora.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234771AbiGYKoy (ORCPT + 65 others); Mon, 25 Jul 2022 06:44:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34512 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234596AbiGYKox (ORCPT ); Mon, 25 Jul 2022 06:44:53 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [46.235.227.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 199F017A81 for ; Mon, 25 Jul 2022 03:44:53 -0700 (PDT) Received: from [192.168.1.100] (2-237-20-237.ip236.fastwebnet.it [2.237.20.237]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) (Authenticated sender: kholk11) by madras.collabora.co.uk (Postfix) with ESMTPSA id 9A1886601ABA; Mon, 25 Jul 2022 11:44:50 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1658745891; bh=fOWPnsIMKc3cDjDnNmAoOPpcjVUIo0Nn5r1oaX8r5HA=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=cNv7NE9Nyps8hTGkGbK8I5oDY2lg+ueWA/aVOx2E389XIk6How3h426jqjgpKXIgq HRbU3sN16lhDvUYfzSeac/ePi5GufH8AC56lkokjUFULVj2SLUq1tLdBDHeAx/m/Yt W1DlX5xEAmWZF/o6ovXLYFem6vGgSu12luYyWQ/AQSOhRI6jxf7LO3W8qcUWe69JKP N0dy8/6JZ/MImMAVB3P1lmLCnE6Gv8jKh7eUUR2elZz+oyydWdmRmvw1RVtI89cjwK P+mjXCZNOulA1ugdq0oI56dHKeCMQNYNX1t4eiRNLk8OHQMRfrj9CdvIlDkFp7Q53r PNtDwz5QA/r+w== Message-ID: <03bf9014-e47f-32fc-4ee1-5fc4a4d381e4@collabora.com> Date: Mon, 25 Jul 2022 12:44:48 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH 1/2] mt76: mt7921: add mt7921_mutex_acquire at mt7921_[start, stop]_ap Content-Language: en-US To: sean.wang@mediatek.com, nbd@nbd.name, lorenzo.bianconi@redhat.com Cc: Soul.Huang@mediatek.com, YN.Chen@mediatek.com, Leon.Yen@mediatek.com, Eric-SY.Chang@mediatek.com, Deren.Wu@mediatek.com, km.lin@mediatek.com, jenhao.yang@mediatek.com, robin.chiu@mediatek.com, Eddie.Chen@mediatek.com, ch.yeh@mediatek.com, posh.sun@mediatek.com, ted.huang@mediatek.com, Stella.Chang@mediatek.com, Tom.Chou@mediatek.com, steve.lee@mediatek.com, jsiuda@google.com, frankgor@google.com, kuabhs@google.com, druth@google.com, abhishekpandit@google.com, shawnku@google.com, linux-wireless@vger.kernel.org, linux-mediatek@lists.infradead.org References: From: AngeloGioacchino Del Regno In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Il 24/07/22 10:58, sean.wang@mediatek.com ha scritto: > From: Sean Wang > > Add mt7921_mutex_acquire at mt7921_[start, stop]_ap to fix the race > with the context holding dev->muxtex and the driver might access the > device in low power state. > > Fixes: 9d958b60ebc2 ("mt76: mt7921: fix command timeout in AP stop period") > Signed-off-by: Sean Wang Tested-by: AngeloGioacchino Del Regno (P.S.: I agree with Lorenzo's nits.)