Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <CAHmME9qrd25vfRYYvCWtPg+wVC5joEzzJiihCN+L4rqMfTL4Rg@mail.gmail.com>
 <20220719201108.264322-1-Jason@zx2c4.com> <xhsmhfsisgbam.mognet@vschneid.remote.csb>
 <CAHmME9pEvr_F2C9cG4qNSCc91a7YAAquW7Jqczcgn2fr_vA4Ow@mail.gmail.com> <xhsmhbktdfqrp.mognet@vschneid.remote.csb>
In-Reply-To: <xhsmhbktdfqrp.mognet@vschneid.remote.csb>
From:   "Jason A. Donenfeld" <Jason@zx2c4.com>
Date:   Mon, 25 Jul 2022 13:41:23 +0200
Message-ID: <CAHmME9rp0kCLKvXWfmRHi=p2PLYRszqQqQWZLHyofJ=9xZCtMA@mail.gmail.com>
Subject: Re: [PATCH v10] ath9k: let sleep be interrupted when unregistering hwrng
To:     Valentin Schneider <vschneid@redhat.com>
Cc:     linux-wireless <linux-wireless@vger.kernel.org>,
        Kalle Valo <kvalo@kernel.org>,
        Rui Salvaterra <rsalvaterra@gmail.com>,
        "Eric W . Biederman" <ebiederm@xmission.com>,
        stable <stable@vger.kernel.org>,
        Gregory Erwin <gregerwin256@gmail.com>,
        =?UTF-8?B?VG9rZSBIw7hpbGFuZC1Kw7hyZ2Vuc2Vu?= <toke@toke.dk>,
        Herbert Xu <herbert@gondor.apana.org.au>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi Valentin,

On Mon, Jul 25, 2022 at 12:09 PM Valentin Schneider <vschneid@redhat.com> wrote:
> > maybe at some point I'll look into overhauling all of this so that
> > none of this will be required anyway. So I think v10 is my final
> > submission on this.
>
> I think that's fair, I hope I didn't discourage you too much from
> contributing in that area.

While not strictly necessary because of Eric's ack, since you continue
to grow this thread that addresses an active bug people are suffering
from, it might be some very useful signaling if you too would provide
your Acked-by, so that Kalle picks this up and people's laptops work
again.

>
> Just to make sure I'm on the same page as you - is your patch solely for
> ath9k, or is it supposed to fix other drivers?

The intent here is ath9k, but in the process it of course fixes other
things too, and I'm quite pleased with the multiple-birds-one-stone
consequence.

> So if ath9k is widely used / a problem for lots of folks, we could just fix
> that one and leave the others TBD. What do you think?

No, that kind of band aid doesn't really sit well, especially as
you've proposed struct changes inside hwrng. I'm not going to do that.

As mentioned, v10 is my final submission here. If you'd like to Ack
it, please go ahead. If not, and if as a consequence Kalle doesn't
pick up the patch, perhaps you'll develop this yourself moving forward
and you'll also fix the longstanding problems with hwrng so that I
don't have to. In case it's not clear to you: I'm no longer interested
in any aspect of this discussion, I find the current patch
satisfactory of numerous goals, and I would appreciate this whole
thing being over. I am no longer available to work further on this
patch.

Thanks,
Jason