Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Valentin Schneider <vschneid@redhat.com>
To:     "Jason A. Donenfeld" <Jason@zx2c4.com>
Cc:     linux-wireless <linux-wireless@vger.kernel.org>,
        Kalle Valo <kvalo@kernel.org>,
        Rui Salvaterra <rsalvaterra@gmail.com>,
        "Eric W . Biederman" <ebiederm@xmission.com>,
        stable <stable@vger.kernel.org>,
        Gregory Erwin <gregerwin256@gmail.com>,
        Toke =?utf-8?Q?H=C3=B8iland-J?= =?utf-8?Q?=C3=B8rgensen?= 
        <toke@toke.dk>, Herbert Xu <herbert@gondor.apana.org.au>
Subject: Re: [PATCH v10] ath9k: let sleep be interrupted when unregistering
 hwrng
In-Reply-To: <CAHmME9rp0kCLKvXWfmRHi=p2PLYRszqQqQWZLHyofJ=9xZCtMA@mail.gmail.com>
References: <CAHmME9qrd25vfRYYvCWtPg+wVC5joEzzJiihCN+L4rqMfTL4Rg@mail.gmail.com>
 <20220719201108.264322-1-Jason@zx2c4.com>
 <xhsmhfsisgbam.mognet@vschneid.remote.csb>
 <CAHmME9pEvr_F2C9cG4qNSCc91a7YAAquW7Jqczcgn2fr_vA4Ow@mail.gmail.com>
 <xhsmhbktdfqrp.mognet@vschneid.remote.csb>
 <CAHmME9rp0kCLKvXWfmRHi=p2PLYRszqQqQWZLHyofJ=9xZCtMA@mail.gmail.com>
Date:   Mon, 25 Jul 2022 18:56:58 +0100
Message-ID: <xhsmhv8rldqj9.mognet@vschneid.remote.csb>
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk

On 25/07/22 13:41, Jason A. Donenfeld wrote:
> Hi Valentin,
>
> On Mon, Jul 25, 2022 at 12:09 PM Valentin Schneider <vschneid@redhat.com> wrote:
>> > maybe at some point I'll look into overhauling all of this so that
>> > none of this will be required anyway. So I think v10 is my final
>> > submission on this.
>>
>> I think that's fair, I hope I didn't discourage you too much from
>> contributing in that area.
>
> While not strictly necessary because of Eric's ack, since you continue
> to grow this thread that addresses an active bug people are suffering
> from, it might be some very useful signaling if you too would provide
> your Acked-by, so that Kalle picks this up and people's laptops work
> again.
>

I don't think the __set_notify_signal() approach is functionally wrong, but
I also believe it isn't the proper tool for the job (for reasons I wrote
previously).

I won't ack it, but I won't nack it either if others find it satisfactory.