Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 26 Jul 2022 18:39:16 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Johannes Berg <johannes@sipsolutions.net>
Cc:     linux-wireless@vger.kernel.org
Subject: Re: [bug report] wifi: nl80211/mac80211: clarify link ID in control
 port TX
Message-ID: <20220726153915.GP2316@kadam>
References: <Yt/16E0ufa0D0Ziq@kili>
 <5cdc7a91910a803ef531ae04ba330541476c0f18.camel@sipsolutions.net>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <5cdc7a91910a803ef531ae04ba330541476c0f18.camel@sipsolutions.net>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?tVtRiKqQnVCk9v82ISm+r+xLu4eCiB/BM0EeRhpEu1DqegrXx72+tYpnjNi+?=
 =?us-ascii?Q?enPIez8Wwi6V8stI4vi0SB0KtzqC6jgR43VDcyULkDdLVphoU/f8n3KulNge?=
 =?us-ascii?Q?o79FgdlAEwl1Ygv30gpkv19hdli7jMzb6/R+2HvQfXgRzLqrwZ81+ciEm3sZ?=
 =?us-ascii?Q?znk+XIXWAwDZpgrsu1qAYZ1CJLmwRE9NwEOojG9myAs5/Hxrad6wScFEo2k9?=
 =?us-ascii?Q?GETXdQ5wz3BB1U0Fjcpcxn2xfD4lwh8P7oC8azg3Q82LaT4YwhG0PRJ8Amo/?=
 =?us-ascii?Q?NJXg6Ooqdhu22WGARB6J91YNQ0lSDcjiUVmE+VlCpmux0+5N0fmYcbDWHRvA?=
 =?us-ascii?Q?b9iMiFIhpThYLYHvM3ongCOQScY7LaQtVSg6bed2EUTAz8a5d8r0bqBjWvJ9?=
 =?us-ascii?Q?vKfJaHoXQJdT8e/fFGXT9gVfjr6OQu0/lincuhd97pSRLtXqWUrP38isPOP7?=
 =?us-ascii?Q?gQ2Hjv5dKI07zc1ks/3XmgtObGCKtVHzQNL/IdvmAEiLKC56Wtam8L9Sh25P?=
 =?us-ascii?Q?jVRk7qmp+e1W/bXXYsZpWzVJajsC9wrWdDMNNrf30qYO6waN8KV27tLr8kgJ?=
 =?us-ascii?Q?2f7xQJn/gO7Zu/dz6New3cPWrynOk7Cqe3IzyUrlqh1URdhDd87HsEiaRoKm?=
 =?us-ascii?Q?yOKtT19cdTHajgkemVETvrH/1aKAMAvgp0FnB/VQJw5W4RAx+OQywnVu3cM6?=
 =?us-ascii?Q?pD9NEOXxlPTlMBhKK3g45ToKfwV73UIrK7vQUmZXyas12lGJQpmWujvKRbRX?=
 =?us-ascii?Q?XHDV96LXn3RjEspnxNc0MK/JLNTZeI0eRvAnuPShDOQAeLtzLo3VF1dhT01W?=
 =?us-ascii?Q?r0/Q8Cxk+UV9xpPIxMfUa8zDSGIPdqFQWOQI+3cfvJXaiAbL+NhiUAYroYIm?=
 =?us-ascii?Q?N0m+4Hx6HMmM+4R9oWMU73HwmBX8Jd3sdLiAn/DtHmlgGc9dx6A+cLFsZpr4?=
 =?us-ascii?Q?Trc7CqiG9d4gCkNgVm1GpsabUzlbzpRmtyGm30tOfGjHhlGmX+FwkKSzsnRF?=
 =?us-ascii?Q?Lv12h80qOkKjA+adk2yGLl9jl4mtVa37TyRG50CTuBvZhLXXEDI2+iKCV8D7?=
 =?us-ascii?Q?5uv3Wr09HTMGMqcWxoxr7wjMcyAmnYetkPmkyofpMKIPfwcDr2U2p6oco+/r?=
 =?us-ascii?Q?FvDPW4clkO4rHasz3shHQnUE1mcanirQgrUe2ntN9iurDzcmYUJzCH7RMgby?=
 =?us-ascii?Q?rZ904OajsMQJKe35g3sYOGlYK2ELUYc7/viWx7zi63j2P6zyaCuCICmfRojR?=
 =?us-ascii?Q?SW7DEbId4VxRVXd5yKLeP2mxU3/APQYjt3eX5K0b25zdjlL2A7LdF57poWp+?=
 =?us-ascii?Q?IVP0OciiYU80bM3IhW7PzjNFye7PNU9jVHSGcWQjnQi6Ux097e6/nQYkJDZT?=
 =?us-ascii?Q?f3aOV0ct5WuRQ07s1K8LBZ3QgITNdEiWuro8PNpOJ1c846a72zMjUBXjh4Ce?=
 =?us-ascii?Q?Hl8N+Qb0Gvy5abMf6eqqrxIHJ47yUSn7fE1a7fwYl2OChRJI7hD4/iX3Mfti?=
 =?us-ascii?Q?GCJWse1xD6lc+SKU9IqUg2d0JTlvuKry4QfljpzDmXFNxv6WSiJhUtJghk3Y?=
 =?us-ascii?Q?RHZw4wW1pKmfAIcCz6ZbRGjnp19xxGUoO/NP7aal0ikuWsnVBtFUoBexXYmj?=
 =?us-ascii?Q?/w=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 85b99dde-ba0f-4bbb-4765-08da6f1d0880
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jul 2022 15:39:31.8392
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Ypv+6xy+aU8ETVWk7L0EFBRv6CmCPfe6eCvWJcwAKWFst5dFrcq/5tCY+6vpV2cKnKlCZZi4N2e0Vn5eAGJbKF7L796NLvQyiPXSo3zno04=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7PR10MB2755
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.883,Hydra:6.0.517,FMLib:17.11.122.1
 definitions=2022-07-26_04,2022-07-26_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=686 malwarescore=0
 suspectscore=0 mlxscore=0 bulkscore=0 adultscore=0 spamscore=0
 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2206140000 definitions=main-2207260060
X-Proofpoint-GUID: U03s4NKnmVmNAmVTYVGF08UCAfdHntJX
X-Proofpoint-ORIG-GUID: U03s4NKnmVmNAmVTYVGF08UCAfdHntJX
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-wireless.vger.kernel.org>
X-Mailing-List: linux-wireless@vger.kernel.org

On Tue, Jul 26, 2022 at 04:42:41PM +0200, Johannes Berg wrote:
> Hi Dan,
> 
> 
> On Tue, 2022-07-26 at 17:10 +0300, Dan Carpenter wrote:
> >     5885         rcu_read_lock();
> >     5886         err = ieee80211_lookup_ra_sta(sdata, skb, &sta);
> > 
> > For sdata->vif.type == NL80211_IFTYPE_MESH_POINT then "sta" can be NULL.
> > Smatch doesn't know the value of sdata->vif.type at this point, and even
> > if it did, then it doesn't split the return states up with enough
> > granularity for that to make a difference.
> 
> Right, but that wouldn't matter anyway?
> 
> >     5887         if (err) {
> >     5888                 rcu_read_unlock();
> >     5889                 return err;
> >     5890         }
> >     5891 
> >     5892         if (!IS_ERR(sta)) {
> 
> Since this is all independent of the interface type.
> 
> >     5893                 u16 queue = __ieee80211_select_queue(sdata, sta, skb);
> >     5894 
> >     5895                 skb_set_queue_mapping(skb, queue);
> >     5896                 skb_get_hash(skb);
> >     5897 
> >     5898                 /*
> >     5899                  * for MLO STA, the SA should be the AP MLD address, but
> >     5900                  * the link ID has been selected already
> >     5901                  */
> > --> 5902                 if (sta->sta.mlo)
> > 
> > Which Smatch complains about here.
> 
> Makes sense, should be "if (sta && sta->sta.mlo)" then I suppose. I'm on
> vacation now, so if you want to send a patch as a reminder that'd be
> nice.

Sure.  I can do that.  Enjoy your vacation!

regards,
dan carpenter