Received: by 2002:ac0:e34a:0:0:0:0:0 with SMTP id g10csp348988imn; Thu, 28 Jul 2022 02:33:17 -0700 (PDT) X-Google-Smtp-Source: AGRyM1sl2hTigblJJZT4Kxsdj/HX7Mm0FGyXNtqy2ooeoEhiQtdzXKuPDVXNJy7tuLomdcIeXyTc X-Received: by 2002:a17:90a:9409:b0:1f0:e171:f2bd with SMTP id r9-20020a17090a940900b001f0e171f2bdmr8959878pjo.245.1659000797365; Thu, 28 Jul 2022 02:33:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1659000797; cv=none; d=google.com; s=arc-20160816; b=ENWiujQcRd8FagHiPL8JIpwQ5or9obRp6CzdygGmr+826u+Eufebnt0baglMpQdL6A JEnzwKJA/z24l0KRK8jax5azuRVG3jY6aNYZNtOvxWeIGn0K7GkC8SxP7WTAUh62hs+a vK3UXLBzCUgG3/XfLq4I/yaGeVVXDiqi/1bfkvVdSY+MTIKGesXfz9W7orB9l6XE0DBy oBXXSH9RW2IyGtmzQQhHjcENGIhIyTzPhtqa8F2fNerutbvKrsE9fT9Tq5vhf1J00sWp 3xGUV2A4mAVAIRUKGrRBHn3Q+DYHhQYdPY6bbZPP4rIjVaUhZtEkrLcKBF00/BI5AJPS tRug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:user-agent:message-id:in-reply-to :date:references:subject:cc:to:from:dkim-signature; bh=/UdWkDtW4ot0X9BK0q6R3KM0RQPui2ursCmHi8JUhjQ=; b=1C6DGA97XzOPbffuHczQUDzHc9t92FgccsvNYQjSenPGzMevOzYtaVy0AWDKEt4aRt p0J5Z8kYx8B838p9ATK6J2YamD5Az144HOUG3IdjmA8q274b5a6KbCFiDiKBcxJmoH7V ASLlUmxN1Eedsw+TeAamBDJro36wGbKt2nLKMD+XgR5o8d5BsNnoyA7qbXaLM1owxswI tJUWk8ptDhBhnRFHze9G/yT75N4P/v6SFgEudY3Wpnt/owyFXdPKnKSokjblDPK4GDRe RDDGy7/4MKpUfORR0BLyCdlmSp0G8wmTWX1AfWIeNVxz2GZzW9258mz6deiJTDWcyI9A UnAQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ZBRM8udO; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id l70-20020a638849000000b0040cb4676a8bsi507810pgd.732.2022.07.28.02.33.03; Thu, 28 Jul 2022 02:33:17 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ZBRM8udO; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235163AbiG1Jbb (ORCPT + 65 others); Thu, 28 Jul 2022 05:31:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39242 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233656AbiG1Jba (ORCPT ); Thu, 28 Jul 2022 05:31:30 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 258EF54CBC for ; Thu, 28 Jul 2022 02:31:29 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id CDB7DB8237F for ; Thu, 28 Jul 2022 09:31:27 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B42FDC433C1; Thu, 28 Jul 2022 09:31:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1659000686; bh=TrCHxnM69uRRwgBH2fmg9CyksUE35VTBbCCaviWPdC8=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=ZBRM8udOt7Uc4OdXy/ixliiBNaM1YXxk2ZrAlLdUi9JZbHwf/aE9UKBRDf2r1E+sC CkAKU24AtUdrPs8dEEEebm904vpK/p3ZInBkOHQ0P3bFYlViU3QmnyMjqc99M8K/y/ k3DKvjMhA9cEpiZtvxyIoja6thwscDj61vGQ2EN7E3YZMumCFEWTUbJtfiCBNHR0qG tluEJioTqIGwPYn8Ge6OTPDbtokMVZlp1kY648Qk2celU3/n+kF2BPFJGn+0Neg1Yl PZKtqW+aIcWaWgRKCulQjO9DnmNCYy2ytDxSEUVG6LPIrIYJoNsHB2kAScNcCZ+Vi8 N8+nxwxtMmwZQ== From: Kalle Valo To: aspriel@gmail.com Cc: arend.vanspriel@broadcom.com, linux-wireless@vger.kernel.org Subject: Re: [PATCH 2/7] brcmfmac: add firmware vendor info in driver data References: <20220613091915.18884-1-arend.vanspriel@broadcom.com> Date: Thu, 28 Jul 2022 12:31:23 +0300 In-Reply-To: (aspriel's message of "Mon, 13 Jun 2022 05:19:24 -0400") Message-ID: <871qu5por8.fsf@kernel.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org aspriel@gmail.com writes: > In order to determine the vendor that released a firmware image for > a specific device, the device table now sets the vendor identifier > and it is stored in struct brcmf_bus::fwvid during probe. > > Reviewed-by: Hante Meuleman > Reviewed-by: Pieter-Paul Giesberts > Reviewed-by: Franky Lin > Signed-off-by: Arend van Spriel The patchwork page for this patch looks odd, but didn't investigate in detail. Never seen that kind of parsing problems before: https://patchwork.kernel.org/project/linux-wireless/patch/CAJ65rDwH9SYhsTKM_4c6e0EN6qfp16kGVsVtSs0d+TNou=DF5g@mail.gmail.com/ -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches