Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Kalle Valo <kvalo@kernel.org>
To:     aspriel@gmail.com
Cc:     arend.vanspriel@broadcom.com, linux-wireless@vger.kernel.org
Subject: Re: [PATCH 3/7] brcmfmac: add support for vendor-specific firmware api
References: <20220613091915.18884-1-arend.vanspriel@broadcom.com>
        <CAJ65rDxy3ERmDAV1BYH_BCUM3_GnzotWpp7yYO6OtA_CZVgbzw@mail.gmail.com>
Date:   Thu, 28 Jul 2022 12:36:21 +0300
In-Reply-To: <CAJ65rDxy3ERmDAV1BYH_BCUM3_GnzotWpp7yYO6OtA_CZVgbzw@mail.gmail.com>
        (aspriel's message of "Mon, 13 Jun 2022 05:19:26 -0400")
Message-ID: <87sfmlo9yi.fsf@kernel.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk

aspriel@gmail.com writes:

> The driver is being used by multiple vendors who develop the firmware
> api independently. So far the firmware api as used by the driver has
> not diverged (yet). This change adds framework for supporting multiple
> firmware apis. The vendor-specific support code has to provide a number
> of callback operations. Right now it is only attach and detach callbacks
> so no real functionality as the api is still common. This code only
> adds WCC variant anyway, which is selected for all devices right now.
>
> Reviewed-by: Hante Meuleman <hante.meuleman@broadcom.com>
> Reviewed-by: Pieter-Paul Giesberts <pieter-paul.giesberts@broadcom.com>
> Reviewed-by: Franky Lin <franky.lin@broadcom.com>
> Signed-off-by: Arend van Spriel <arend.vanspriel@broadcom.com>

[...]

> --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/Kconfig
> +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/Kconfig
> @@ -8,6 +8,22 @@ config BRCMFMAC
>  	  interface support. If you choose to build a module, it'll be called
>  	  brcmfmac.ko.
>
> +config BRCMFMAC_VENDOR_MODULES
> +	bool "Use vendor-specific modules"
> +	depends on BRCMFMAC = m
> +	help
> +	  This option will build separate modules for the vendor-specific
> +	  firmware support. If not selected the vendor-specific support
> +	  will be build in brcmfmac.ko.
> +
> +config BRCMFMAC_VENDOR_WCC
> +	bool "Broadcom WCC"
> +	default y
> +	depends on BRCMFMAC
> +        help
> +          This option will allow the driver to communicate with devices
> +          shipped by Broadcom WCC division.
> +

I'm not really a fan of these Kconfig options, I would rather have them
always enabled. Why do we need these options, what would be the use case
when user disables these?

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches