Received: by 2002:ac0:e34a:0:0:0:0:0 with SMTP id g10csp355425imn; Thu, 28 Jul 2022 02:50:38 -0700 (PDT) X-Google-Smtp-Source: AGRyM1sdSeZ09NKNjXx/0ZlmD0paTEvzQLDb06xBchxjq4HThXsBPgrjJ8elwQLGgKrLDDwUvBRd X-Received: by 2002:a17:907:6d04:b0:72e:e204:a70b with SMTP id sa4-20020a1709076d0400b0072ee204a70bmr20529046ejc.432.1659001838059; Thu, 28 Jul 2022 02:50:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1659001838; cv=none; d=google.com; s=arc-20160816; b=oCMi23oP5lUEwhdOXMBzHevV5K/MUjxCT0ezTSUx+y4+EqaV5mW2pUoK+x2Pv+VhZ/ R9DwUIsXv5X2n2UzrjgLB06XQjzTB/5UtasyODvZIwAi+xOiM1omTVsquuPs+UCXfakf iUYuzRrhQ31k58NElgvY8IPuKQHkUycetdjOf0sU3NLwIgQoaNknDOEboY2dl/M08cWC 5w/kQqdMY5bdihr12wMM4uFl6QjWKcobJWu0roZtdimIgScpRXs8rv8GFjEw0Q2PCiok Sm6mO1Nuf+yTay6Ltp9DGsSCvBkRmE8LFivo3Tr93x9bKAxj712SG5n1Md0BFC5v71AT ghGQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:user-agent:message-id:in-reply-to :date:references:subject:cc:to:from:dkim-signature; bh=uqOqsVWKt9zksy+PoGDVKMHMLxZ9ZwTzkvoP4UiGbqM=; b=Wq9reenuUydQ7mkw4OT+0fUDkuPqPZPq6bUWo9bEkSRx1B+DeLIaz/tUkBsY7IalGb MH9D/67FbwSYzHTTQ9HuUZPY2C7wMdWAscsDud0j+Mc9wvjMtuXBv1BJDjSvs2HdIw3L sTs+NgQzuxVm1O9DWk9PPqCT8YGkerBcWDkqF7PhbCMi5ZxnlRG7n3MZRTwT8/IODXRr 8PESOj5iWVFAxUnepBa9VxyRg7ATjRAJqlr1A6i+iKdaAhv3zMCvpWThGoOqUQi8ytTv IXxfK3wXzsAN02tI1hAsCQfKOIzawHxlRYkS+5ygQKXhmcoRtef2feElRYmt0QVHGFbb qvGA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=PAfGQozZ; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id wt4-20020a170906ee8400b00726b4533cd1si325678ejb.170.2022.07.28.02.50.21; Thu, 28 Jul 2022 02:50:38 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=PAfGQozZ; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235626AbiG1Jj7 (ORCPT + 65 others); Thu, 28 Jul 2022 05:39:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45098 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234722AbiG1Jj6 (ORCPT ); Thu, 28 Jul 2022 05:39:58 -0400 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B92156583D for ; Thu, 28 Jul 2022 02:39:57 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id E842ECE2454 for ; Thu, 28 Jul 2022 09:39:55 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3E5AAC433D6; Thu, 28 Jul 2022 09:39:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1659001194; bh=qXUVGAu6hglYXNpvMNBsrp9DHVGY7weJHUgB4TfEgXs=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=PAfGQozZUH1RF44yXPAZK+8nc+YtOf8tgZedZnvnItWxP77ZSca4afB9odIMSmLLH zyVzTWrz2qSzlRuPU/n6DJWn7BGNnXhL9ZVBWectwEUJBBfYAEo0ShuvGLRYpU6wpr p+Jtp3y0cqi9ps+IB5nAJ3ihBbdNmS23A+OO/8vG5FD6o7/82qNZbWmwRJeLagQId2 I5+UCbZAaK9OQ4S5qQDECOyeYRkv9nwRh6Act2ZYC/FkkQ6EX+uTc/KDRfJdZwvrSD 7nlExQ5trq5lV87giNZPh9ACO/xVpPOPTQ7OUPM5jHwC/OKk71cVrkJK/egXNu2opK kvFA1LuNU0E7g== From: Kalle Valo To: aspriel@gmail.com Cc: arend.vanspriel@broadcom.com, linux-wireless@vger.kernel.org Subject: Re: [PATCH 7/7] brcmfmac: introduce BRCMFMAC exported symbols namespace References: <20220613091915.18884-1-arend.vanspriel@broadcom.com> Date: Thu, 28 Jul 2022 12:39:51 +0300 In-Reply-To: (aspriel's message of "Mon, 13 Jun 2022 05:19:29 -0400") Message-ID: <87fsilo9so.fsf@kernel.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org aspriel@gmail.com writes: > Instead of using EXPORT_SYMBOL() use namespace variant and only if > build vendor-specific code as separate module. The commit log should always answer to the question "why?". -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches