Received: by 2002:ac0:e34a:0:0:0:0:0 with SMTP id g10csp357732imn; Thu, 28 Jul 2022 02:57:06 -0700 (PDT) X-Google-Smtp-Source: AGRyM1s7lJo/H1TlT0sNNNYPBC5rGpHo1v65H1q+QeMRKPMDj3WIK8dXwXXdmZwk+s7ItBbnsGQW X-Received: by 2002:a63:d006:0:b0:419:b272:9e6d with SMTP id z6-20020a63d006000000b00419b2729e6dmr22001121pgf.608.1659002226323; Thu, 28 Jul 2022 02:57:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1659002226; cv=none; d=google.com; s=arc-20160816; b=wIXOo5o8KjWd0LmpnFCixlYbzbG1DzB/BVX2FG0hNf8+/PJUsIA/Qzms3tU5nK1hLM 2XJrCvJoBgRBOgoL6rNa0odaWeULKGNCcNT3YHIu2ZOCef7K9SmYpb2Sx7qsFFJLpd3L Z/0TuHjODd/WdDwBgsdCwHHrccQW2CVqNmd0MSVi3XMgzvmwHRJSu20gD6V33gBoBskf JGgxozI1K14V8KSU8CRJMIi9W5uiBUoeI4Jn+Ewx74y6fgcnJyg0OBORp+nUawOcarOF WtaC8Ti/YJxEZDjU5wtSbSvbV01ZOF6dseNeOq6TXRYsvuEw330B3G2GsAPxrpGsZ5b9 CeeQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:date:message-id:user-agent:cc:to:references :in-reply-to:from:subject:content-transfer-encoding:mime-version :dkim-signature; bh=zKP7Ktb+cZ4Ao06oN8v/TKBz4iKnX8gI1Rw2X4q9jlU=; b=o+8NR369BAe4aADsl+E64nxEOecjB3xQkRW9U4u81fRzDllWhSdapxnXd7subtf9vA uM27bu0STUMDWh445YzJEDHU63dE2pledK2RXU0n1gx12YH2BScOanM9MeaF8fYfXWk2 PBH0fbuNqJROxfPqpW4G+bSmjARkg4eRDS5gqI6WmDK1NzXuuFHjUKBm7sP7jq4HnLkJ PTojlCB1N63DOoDP5hS2PSYyyYKGFKF64in5+jD+0Z23LZxOyxUg2k1HHhuvceLZCkEF 67ZidWIca7oTKCY/8PQc91f0aLGlMahwgFdcRDBW8CYByG27lcQYJmueaZb1roW8OHg6 LDEg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=fpfnMaVr; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id j23-20020a63ec17000000b00412a00de71fsi560955pgh.552.2022.07.28.02.56.54; Thu, 28 Jul 2022 02:57:06 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=fpfnMaVr; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235617AbiG1J4F (ORCPT + 65 others); Thu, 28 Jul 2022 05:56:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57314 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235034AbiG1J4E (ORCPT ); Thu, 28 Jul 2022 05:56:04 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 539336390C; Thu, 28 Jul 2022 02:56:03 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id E417160CD4; Thu, 28 Jul 2022 09:56:02 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CB0E3C43470; Thu, 28 Jul 2022 09:55:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1659002162; bh=nwp57PiOXE/bBj5SQgoSWUC9ZuA/a8ca1u9c4yEW2zU=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=fpfnMaVr51ZVOR3XcN61gHVNcfEMHAd4JMy3bayfzLd3MroiuyTXWU6iWZay4+TnN /fs48i/OonxxamgVsllBJgHH0e01YJ+1Ld2HxSf3BmXfqeS2W5yjcsWFzqxKyMNZ5g K1TNReUIPCtQU4+uykDDasO2DAVBul57/cl9rvm8TIR8s8nNizLFSYbMl6ZJAoRD2/ jY1FEF0mT61VGarZWvHL5tOJ/ABemlP8tMOCEnCm4YuxjvfekXWJ0NkMnbKX4Besnt C7rhpDoLfFhlhph8gjubqwUG+g+bkYq1ZQOI+R4nPnL9NRyq5ltsjFX742ADC58kNa HYeJ9B/b40Ajg== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: wifi: brcmfmac: use strreplace() in brcmf_of_probe() From: Kalle Valo In-Reply-To: References: To: Dan Carpenter Cc: Arend van Spriel , Johannes Berg , Franky Lin , Hante Meuleman , Len Baker , Shawn Guo , Hector Martin , linux-wireless@vger.kernel.org, brcm80211-dev-list.pdl@broadcom.com, Linus Walleij , kernel-janitors@vger.kernel.org User-Agent: pwcli/0.1.1-git (https://github.com/kvalo/pwcli/) Python/3.7.3 Message-ID: <165900215794.25113.6597202255013388708.kvalo@kernel.org> Date: Thu, 28 Jul 2022 09:55:59 +0000 (UTC) X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Dan Carpenter wrote: > The for loop in brcmf_of_probe() would ideally end with something like > "i <= strlen(board_type)" instead of "i < board_type[i]". But > fortunately, the two are equivalent. > > Anyway, it's simpler to use strreplace() instead. > > Signed-off-by: Dan Carpenter > Suggested-by: Johannes Berg > Reviewed-by: Linus Walleij > Acked-by: Arend van Spriel Patch applied to wireless-next.git, thanks. bef11f1edc40 wifi: brcmfmac: use strreplace() in brcmf_of_probe() -- https://patchwork.kernel.org/project/linux-wireless/patch/YqrhsKcjEA7B2pC4@kili/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches