Received: by 2002:ac0:e34a:0:0:0:0:0 with SMTP id g10csp362291imn; Thu, 28 Jul 2022 03:06:07 -0700 (PDT) X-Google-Smtp-Source: AGRyM1tKSqGt67WhJFFpR60VDRcQuWi7KMcOv2ivme7LxM2tBrNt6+RE7g/Pz+lQkWb+oy/hm6Yh X-Received: by 2002:a17:90a:5aa3:b0:1f2:2bb7:aea9 with SMTP id n32-20020a17090a5aa300b001f22bb7aea9mr9231461pji.197.1659002767646; Thu, 28 Jul 2022 03:06:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1659002767; cv=none; d=google.com; s=arc-20160816; b=stuaVCLLyJXBYb5N4oMK7p+MxG3EJkP1VZ+Ha3bYvaf/0FZlRn9RK/NS159lz4PIMH f6nvS0x3GQqeWMxfy1UNCJiTTUj7aoe7uZhDjDU0MCHOY8Z80qjudKrT97uOjyv0u1/t k43Z0+SHue90XyRXtk7qSrrkaJdFNEfrAFt4te9y7L3C5Zu/kNO+CjKXGR23KLN+bNBV FdSANMYBDYAcDiX8D3j9iJSLpODnkvhSX1Cwd51PX3MsW9KmIsgYEOpzfYdcvUIgQL4b 3Y8ij102zbLoodC5/zUXB8KhfHkMhGvxEPuLMcH7d1bwOvbL0f0zhi3vorKxF5OyK2YR egpw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:date:message-id:user-agent:cc:to:references :in-reply-to:from:subject:content-transfer-encoding:mime-version :dkim-signature; bh=Sq69lGUxzYW9TFoLK+7kIizJ2A9BeT72KIr2KfSeTVc=; b=CrVYi7DgZ6WY+sD72Go2MDFk6LygMukoIDG3216gWhPa0E2l3A127C3wUJ5ObzF7Ux wtP4y0+ILSQPh8NmLL9lRj0F3EV+C1az+GVYtYyOCQ/Yr0kXP6FHKkV1ZMF7KYRDSxOZ 5Y0b94wIREAhObNiSFZtm/77F1n2SlR9OSJ+CCWgXrw7sA7dTsFRHBNaokPq2MnUeEio P5s0DsRq4lNaqKArct2xe4qs6k9rDE0yuBaJl7SHZ8wcL62THyL1lXqimwgl/gtHbccH cCQxgYFegfxCDnRF4INQVqhfAdLDKtX7SzWELg7YMhrDeLJlOu9+c66Dy562RZhFW5Cb 2JzA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=tQFi3+7a; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id v36-20020a634824000000b004148a134f59si555793pga.551.2022.07.28.03.05.54; Thu, 28 Jul 2022 03:06:07 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=tQFi3+7a; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235707AbiG1J5o (ORCPT + 65 others); Thu, 28 Jul 2022 05:57:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58096 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235034AbiG1J5m (ORCPT ); Thu, 28 Jul 2022 05:57:42 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 54A536390D; Thu, 28 Jul 2022 02:57:41 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 09D04B82393; Thu, 28 Jul 2022 09:57:40 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CBE1FC433C1; Thu, 28 Jul 2022 09:57:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1659002258; bh=pzgNl7GHZa2hl9UPO39duiMSklaGM6oa/uofX+is3PE=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=tQFi3+7aGm02mP0NWlBfgPD8D2Cl5Cicsw0GLPtCFCJ8vY5s9Vu+4Kr3m4JlEGLG6 3OQZLDfSRp+caucGWLumOJuqcP1VSyeXJRoktA0qWfUaxeuHp1/94fG+IvC3LtHpYg TPtfegQ4jaDBv8LWkrhSzyr2+Mj9d2hdPvPNqDLi5u24uDacXikafuiAZesHgT3ZZs pPOr5ZhzxkSOFMgBq7xmJh+1qJnlhPDuBCi2NITUTSbhioFlzCPLZsQVmC9EWvecuE 7gmeYprDyknjAglV9vSu8Tq+BTVCTpEDdWpCv07O+kOGutZoiVUDmP7Fk7gA3K6+Yk W+VysNOjb9mbg== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [v3] wifi: brcmfmac: Remove #ifdef guards for PM related functions From: Kalle Valo In-Reply-To: <20220627193701.31074-1-paul@crapouillou.net> References: <20220627193701.31074-1-paul@crapouillou.net> To: Paul Cercueil Cc: Arend van Spriel , Franky Lin , linux-wireless@vger.kernel.org, brcm80211-dev-list.pdl@broadcom.com, SHA-cyfmac-dev-list@infineon.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Paul Cercueil User-Agent: pwcli/0.1.1-git (https://github.com/kvalo/pwcli/) Python/3.7.3 Message-ID: <165900225429.25113.8345553765798520539.kvalo@kernel.org> Date: Thu, 28 Jul 2022 09:57:36 +0000 (UTC) X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Paul Cercueil wrote: > Use the new DEFINE_SIMPLE_DEV_PM_OPS() and pm_sleep_ptr() macros to > handle the .suspend/.resume callbacks. > > These macros allow the suspend and resume functions to be automatically > dropped by the compiler when CONFIG_SUSPEND is disabled, without having > to use #ifdef guards. > > Some other functions not directly called by the .suspend/.resume > callbacks, but still related to PM were also taken outside #ifdef > guards. > > The advantage is then that these functions are now always compiled > independently of any Kconfig option, and thanks to that bugs and > regressions are easier to catch. > > Signed-off-by: Paul Cercueil Patch applied to wireless-next.git, thanks. 02a186f1e96b wifi: brcmfmac: Remove #ifdef guards for PM related functions -- https://patchwork.kernel.org/project/linux-wireless/patch/20220627193701.31074-1-paul@crapouillou.net/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches