Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <428a96cf-1072-8bbd-937a-6e3558e9448e@gmail.com>
Date:   Fri, 29 Jul 2022 10:51:42 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [PATCH 0/7] brcmfmac: support devices from multiple vendors
Content-Language: en-US
To:     Kalle Valo <kvalo@kernel.org>
Cc:     arend.vanspriel@broadcom.com, linux-wireless@vger.kernel.org
References: <CAJ65rDxwRshw4Qwte9bU4K+xifcS0Yo7TjCKJ2aNPg4wBLeg5w@mail.gmail.com>
 <87wnbxoa37.fsf@kernel.org>
From:   Arend Van Spriel <aspriel@gmail.com>
In-Reply-To: <87wnbxoa37.fsf@kernel.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 7/28/2022 11:33 AM, Kalle Valo wrote:
> aspriel@gmail.com writes:
> 
>> The bcm43xx family of wifi chipsets found its way to different
>> groups inside and outside Broadcom. For the fullmac devices this
>> means that in those difference groups firmware is being developed
>> and the firmware api is bound to diverge. This series introduces
>> a design change to accomodate supporting multiple firmware api's.
>> The vender-specific support can be compiled in brcmfmac or
>> built as a separate module. Currently the vendor-specific support
>> does not have any real effect. At the momemt looking into SAE support
>> which appear to be different for Cypress devices so that might be a
>> first use-case. Meanwhile wanted to put this series out there and
>> get feedback on it. Some ideas were taken from iwlwifi which does
>> similar things for iwlmvm, iwldvm, etc.
>>
>> The patches apply to the main branch of the wireless-next repository.
>>
>> Arend van Spriel (7):
>>    brcmfmac: add function to unbind device to bus layer api
>>    brcmfmac: add firmware vendor info in driver data
>>    brcmfmac: add support for vendor-specific firmware api
>>    brcmfmac: add support for Cypress firmware api
>>    brcmfmac: add support Broadcom BCA firmware api
>>    brcmfmac: add vendor name in revinfo debugfs file
>>    brcmfmac: introduce BRCMFMAC exported symbols namespace
> 
> I think there's something wrong in mail formatting, tried to apply just
> for a test and it failed:
> 
> error: git diff header lacks filename information when removing 1 leading pathname component (line 7)
> error: could not build fake ancestor
> hint: Use 'git am --show-current-patch=diff' to see the failed patch
> Applying: brcmfmac: add function to unbind device to bus layer api
> Patch failed at 0001 brcmfmac: add function to unbind device to bus layer api

Hi Kalle,

Looks strange indeed. I will look into it and resend the whole series.

Gr. AvS