Received: by 2002:ac0:e350:0:0:0:0:0 with SMTP id g16csp284247imn; Fri, 29 Jul 2022 06:51:44 -0700 (PDT) X-Google-Smtp-Source: AGRyM1uOLeZri+WHFRK/S21Euknvg9byXHNMKCGgY3CWAqKDzdCGtJnXP+x5EDBBegW6esbmyppU X-Received: by 2002:a05:6402:3408:b0:43c:2dd3:d86b with SMTP id k8-20020a056402340800b0043c2dd3d86bmr3695368edc.108.1659102704471; Fri, 29 Jul 2022 06:51:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1659102704; cv=none; d=google.com; s=arc-20160816; b=uEaT9Qij8fSQonGK0XoXd69pjW895RNv7UQpTDS4x0Db4pT0WCrmKR+P9X6JvePlme xvcYz2sFswKvysjM24pawueIze755RM0mXGly7w36vKh8o700sCH+JTDQ/vYWMFzbBcc N1qt2wXxQo8yEId9yVh31Z861NR46mub7vLf/jeJvjyVlqUV790oHdkqQi6baFJ3rHC0 BB3y2HIFIIcFnVxuFP6F3ihgDcJMH5Tm9WfWeZL1MpFAeAhqaPszb9l3AQ1ujg8BxdsE kF3cEvPYNtZTJDwzClljAhKbmE0qnXRhyzH/fZqWPj1aehV48MQGslFhKehmaLbBATDG RxQQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:date:message-id:user-agent:cc:to:references :in-reply-to:from:subject:content-transfer-encoding:mime-version :dkim-signature; bh=RgGasbhNcnlIWqjNB/lhi+FLy/YIIY7sCWNvPRtAGQY=; b=zjtksBmuevZnLbt0wY8o++tFglEE/DMarBuKpUjEuRBLkrC0fJOgXzZ9Q4kNx3xQFf zN360+kaXvp9yPukWtCuxPMvDf2xLq3eC9dfpScEEzvjduH+iKg0cBzNK+LjeZYCU/VT 0JhqvzcWjsKas451vx8iwP4gdr0G3HA2U0bf36BEtnSXpX/MuU3wKRrx/hnnF93QeJ6K x2cR/T8kK7fphRiGj9L+qTLA3/KdaSUKeW3dU+I01SSpiDp639Njmj5D1OJO/jPNnRa6 reg+Ps+j6UzukzLLfeh4gSA1mENxhS1QjTa4gGEnOx8IFOvJ/TFM1tP3ptWyfzchYU/B 9l9g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=aKRD7FIo; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id f22-20020a50fc96000000b0042dc61e68d0si2936078edq.137.2022.07.29.06.51.25; Fri, 29 Jul 2022 06:51:44 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=aKRD7FIo; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236638AbiG2NgE (ORCPT + 65 others); Fri, 29 Jul 2022 09:36:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54132 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235451AbiG2NgD (ORCPT ); Fri, 29 Jul 2022 09:36:03 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0BCCD20BDD; Fri, 29 Jul 2022 06:36:03 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 984BF61F41; Fri, 29 Jul 2022 13:36:02 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B6318C433C1; Fri, 29 Jul 2022 13:35:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1659101762; bh=qFuiy5RGnMWAsrTSIlSP+Qm37HzZ4t25uoraBaL7fhA=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=aKRD7FIoJ96Jj4E7GObBJw+FPD1HuLDDafVTxh1cHhj4AwSuyu0fz0yhvsxcXoqs/ +PyjWVbMurJnZWcWTLLY7zPweqcfaATmiDIusft0kSdPMJtvHXh6ND9hX9huEI9Zmb 4CZXi104r3nxiCXPE77Y/9LqSfuiU0Netd3kNb7EkuxGosYtYDlMJruXMLxpkRKjuN JOPZvO3uv02vHmqCh3zXKtGLQLwtTD1aiPMlQorqIyFsPzyGERYF8Lchx+oGNRWnmp s7ENOnEcK1BDJTtijuY151TclJDNPNEjimz+EwzM1vP7zM+EeK6e1/Zm6S+H2tEfr5 u4mpTi5y/5gdw== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: wifi: rtw88: check the return value of alloc_workqueue() From: Kalle Valo In-Reply-To: <20220723063756.2956189-1-williamsukatube@163.com> References: <20220723063756.2956189-1-williamsukatube@163.com> To: williamsukatube@163.com Cc: tony0620emma@gmail.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, William Dean , Hacash Robot User-Agent: pwcli/0.1.1-git (https://github.com/kvalo/pwcli/) Python/3.7.3 Message-ID: <165910175801.2014.14758943115910688556.kvalo@kernel.org> Date: Fri, 29 Jul 2022 13:35:59 +0000 (UTC) X-Spam-Status: No, score=-7.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org williamsukatube@163.com wrote: > From: William Dean > > The function alloc_workqueue() in rtw_core_init() can fail, but > there is no check of its return value. To fix this bug, its return value > should be checked with new error handling code. > > Fixes: fe101716c7c9d ("rtw88: replace tx tasklet with work queue") > Reported-by: Hacash Robot > Signed-off-by: William Dean > Reviewed-by: Ping-Ke Shih Patch applied to wireless-next.git, thanks. 42bbf810e155 wifi: rtw88: check the return value of alloc_workqueue() -- https://patchwork.kernel.org/project/linux-wireless/patch/20220723063756.2956189-1-williamsukatube@163.com/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches