Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Kalle Valo <kvalo@kernel.org>
To:     Dennis Baurichter <dennisba@mail.uni-paderborn.de>
Cc:     Zachary Michaels <mikezackles@gmail.com>,
        linux-wireless@vger.kernel.org, Troy Volin <tmvolin@gmail.com>,
        Gregory Greenman <gregory.greenman@intel.com>
Subject: Re: [PATCH] iwlwifi: Make missed beacon timeout configurable
References: <20220226045047.643695-1-mikezackles@gmail.com>
        <c09a353b-8e52-6d9d-a3c6-743e4e6f444b@mail.uni-paderborn.de>
Date:   Wed, 03 Aug 2022 07:32:13 +0300
In-Reply-To: <c09a353b-8e52-6d9d-a3c6-743e4e6f444b@mail.uni-paderborn.de>
        (Dennis Baurichter's message of "Tue, 2 Aug 2022 20:50:31 +0200")
Message-ID: <871qtyj6b6.fsf@kernel.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk

Dennis Baurichter <dennisba@mail.uni-paderborn.de> writes:

> Hello,
>
> the below patch was sent to linux-wireless 5 months ago, but (as far
> as I can see on lore.kernel.org) didn't get a reply, so I guess it
> might have slipped through? May I ask to consider it for inclusion?
>
> As stated below, this is a workaround for frequent wifi disconnects
> described in https://bugzilla.kernel.org/show_bug.cgi?id=203709. As an
> example, on one laptop with Intel Dual Band Wireless AC 3160 these
> disconnects occured sporadically initially, but later became very
> frequent, e.g. around 100 disconnects within 5 hours (with the laptop
> 1m from the wifi access point). Setting the beacon_timeout parameter
> provided by the patch allowed me to completely "fix" / work around the
> problem, with no disconnects anymore. Many more examples can be found
> in the linked bug report.

The patch did get to patchwork and is assigned to Gregory:

https://patchwork.kernel.org/project/linux-wireless/patch/20220226045047.643695-1-mikezackles@gmail.com/

Gregory, please take a look. This looks to be a common problem.

Not really fond of a module parameter approach, I think it should be
automatic. Why not just increase the default beacon timeout value?

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches