Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 4 Aug 2022 10:03:21 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Johannes Berg <johannes@sipsolutions.net>,
        "Luis R. Rodriguez" <lrodriguez@atheros.com>
Cc:     "John W. Linville" <linville@tuxdriver.com>,
        linux-wireless@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: [PATCH] cfg80211 debugfs: fix return type in ht40allow_map_read()
Message-ID: <YutvOQeJm0UjLhwU@kili>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?jTey3YElo+0zsmBqSSu2PgZLg723IMYsCSanHUclL8sRFf4m7OtJAoN9vEvX?=
 =?us-ascii?Q?RohwNGHhi0+MJbSBlcDCjs98AuGAk86qrQWsS88BhD/SN/Elj0aomDAb6TD/?=
 =?us-ascii?Q?3U945z78GXoewZ+IoTg/8hcQOgMywGQAfX7h50sLHLy+SnNrr0G9GZntPC/k?=
 =?us-ascii?Q?mHcJoC8GDt143LJUHu5jmdPA4ejKepc4j01rLjR4qaalRBbm332l0Px58vHy?=
 =?us-ascii?Q?/kTzzKzvkK7cEj1W2pxi1yZKyPwliIWpT5DJGK11w6oUrnxbAleONc3w8Buj?=
 =?us-ascii?Q?KbINV0ov6pitRdWC8MCketjVw2a+W4+j2pgHMjfkl17u2rp3sJzXvW9GtSGl?=
 =?us-ascii?Q?XYHsZCcWT0ERGKSQMlWW1hgLv8k57al3Wtv+ddv+yvReRzZsuBX0Jjq4b9k8?=
 =?us-ascii?Q?nbWtI27YGOlfK2D4ilbitnQ5xtBx6Nh+usKOX8Kj8nZCSk60KQGnuF+15aUA?=
 =?us-ascii?Q?nTDNTCDd+A3eWekw+3MAvXMxMWT+mV53orPSYVOn57Dhj7cI5P3FBMDXkgDQ?=
 =?us-ascii?Q?J3kZqD823JxSp1AbjSk7r0fXfWXbkFEq4P/b94JHmWJtkfIEidRV7xa+5hw9?=
 =?us-ascii?Q?14ZSXf12B4y5TRCHRlMzTq4QpjfLloA8IdAlqm/9PKwBZAJf/mfR9G+OhQi+?=
 =?us-ascii?Q?bBaBJd3/HiQnHSJLRHxEzKA581RoRfUazdTu7pgiTmNCxfE0Z1HUzjrR/YxM?=
 =?us-ascii?Q?j9biMMlbv1gxeS18916pUVgCNoMTQ2yzORes8wy9Qa2jvgXa994Tf8d5fAcR?=
 =?us-ascii?Q?wP47xa01BuRX6zTqNo3eVr4nHMA2yWwVTqk3E2hpnueDG5rXU9lSBMW/cHvP?=
 =?us-ascii?Q?WFcedfmdtR6+nivMVxehNEMR8A1sWFgbDay5IFUAbR6YA2To3lorP2cykt85?=
 =?us-ascii?Q?M8Oz7c1QSJqYzB0zNxKK/pdlAzANkCbcJu4Fmx7qQ8Hz5L2PuhXAXcHyeZWu?=
 =?us-ascii?Q?S4KrW1k1Wb6vYqIm9jxyvnGr5wnE7Vl+O+sWMWQQ9etoghAiZSeOH3XUbVGE?=
 =?us-ascii?Q?lvQER+MDLD8/nMQIny/guO4B5E5NgrR1wTqfEM1/zA6nnFk3JXlXgEc63D6X?=
 =?us-ascii?Q?4UjeZVLiJ+g5bsMFnm/gzMwhCSOkppzF0SckeBlijL10i9Vq5ANRtQvLNr1h?=
 =?us-ascii?Q?hOJNeV3cmjMNYRH7t77F3Pu8b9hg1q43AQt947YPZCwHV7CMAp12lHyjZlsB?=
 =?us-ascii?Q?1ORWMNN655HzlaI+78tcNDstEqleUnR+hR6QzVds/rPPhAjoA3JarMmSiReM?=
 =?us-ascii?Q?L9FoJJu9xSoMBMfcfAeO4dS6sFx95m8VchRkPQ+q1OsbphRcxqLV98YiMQGg?=
 =?us-ascii?Q?7kfI90HOMoLujZN3uSfibUshpTzAtbm7ExwnLLh62zsYFRMbmcySZEcGZMzO?=
 =?us-ascii?Q?OrgpOyPpQb//MKlbzC49nJpHR/0nmBt0A2c3K22i/glOS8rvG6SudatjCNlS?=
 =?us-ascii?Q?+f5P8kLr1tgL63X87WsVfRL4t/oDrCWG9XdjHVdY1kt1OEY5HnlXlRPGZJZP?=
 =?us-ascii?Q?h7BaArqb0pJqLBlIyPF6iO35rss+1CJ+X9tkWEeOyry6Bo5rhFJmUiDH7VNy?=
 =?us-ascii?Q?qqyyF6HaIjiYQJjhVlRxmZSefxzhoS5BAatJjpw4ptNue4Qvpp6Ly/KpOOt+?=
 =?us-ascii?Q?HA=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9cab5f65-1a9c-4824-1c73-08da75e770d3
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Aug 2022 07:03:31.8687
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: DLnZIa8LauxWpuWpeekodKkncwDF4/CHqvFxPKAanImcbxT8faTfnl49E7tEZqge5K64zimGfRAL2uvqDIkEwsDgOmgv5Hy5Ufnthoghf/8=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR10MB4328
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.883,Hydra:6.0.517,FMLib:17.11.122.1
 definitions=2022-08-04_01,2022-08-02_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 mlxscore=0 suspectscore=0
 adultscore=0 bulkscore=0 malwarescore=0 mlxlogscore=999 phishscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2206140000
 definitions=main-2208040029
X-Proofpoint-ORIG-GUID: xtAM_B5rI46WcFOV6OD_-i7vMVDhjrzV
X-Proofpoint-GUID: xtAM_B5rI46WcFOV6OD_-i7vMVDhjrzV
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-wireless.vger.kernel.org>
X-Mailing-List: linux-wireless@vger.kernel.org

The return type is supposed to be ssize_t, which is signed long,
but "r" was declared as unsigned int.  This means that on 64 bit systems
we return positive values instead of negative error codes.

Fixes: 80a3511d70e8 ("cfg80211: add debugfs HT40 allow map")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
 net/wireless/debugfs.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/net/wireless/debugfs.c b/net/wireless/debugfs.c
index aab43469a2f0..0878b162890a 100644
--- a/net/wireless/debugfs.c
+++ b/net/wireless/debugfs.c
@@ -65,9 +65,10 @@ static ssize_t ht40allow_map_read(struct file *file,
 {
 	struct wiphy *wiphy = file->private_data;
 	char *buf;
-	unsigned int offset = 0, buf_size = PAGE_SIZE, i, r;
+	unsigned int offset = 0, buf_size = PAGE_SIZE, i;
 	enum nl80211_band band;
 	struct ieee80211_supported_band *sband;
+	ssize_t r;
 
 	buf = kzalloc(buf_size, GFP_KERNEL);
 	if (!buf)
-- 
2.35.1