Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sun, 7 Aug 2022 13:22:00 +0800
From:   kernel test robot <lkp@intel.com>
To:     Sriram R <quic_srirrama@quicinc.com>, johannes@sipsolutions.net,
        nbd@nbd.name
Cc:     kbuild-all@lists.01.org, linux-wireless@vger.kernel.org,
        Sriram R <quic_srirrama@quicinc.com>
Subject: Re: [PATCH v3] wifi: mac80211: Mesh Fast xmit support
Message-ID: <202208071332.oT3t8RiR-lkp@intel.com>
References: <20220806173805.32743-1-quic_srirrama@quicinc.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220806173805.32743-1-quic_srirrama@quicinc.com>
Precedence: bulk

Hi Sriram,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on wireless-next/main]
[also build test WARNING on wireless/main linus/master v5.19 next-20220805]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Sriram-R/wifi-mac80211-Mesh-Fast-xmit-support/20220807-014055
base:   https://git.kernel.org/pub/scm/linux/kernel/git/wireless/wireless-next.git main
config: m68k-randconfig-s043-20220807 (https://download.01.org/0day-ci/archive/20220807/202208071332.oT3t8RiR-lkp@intel.com/config)
compiler: m68k-linux-gcc (GCC) 12.1.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # apt-get install sparse
        # sparse version: v0.6.4-39-gce1a6720-dirty
        # https://github.com/intel-lab-lkp/linux/commit/ba549e3891af7b7e0a64c522618035d995483d54
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Sriram-R/wifi-mac80211-Mesh-Fast-xmit-support/20220807-014055
        git checkout ba549e3891af7b7e0a64c522618035d995483d54
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=m68k SHELL=/bin/bash net/mac80211/

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>

sparse warnings: (new ones prefixed by >>)
>> net/mac80211/tx.c:3614:13: sparse: sparse: incorrect type in assignment (different address spaces) @@     expected struct sta_info *sta @@     got struct sta_info [noderef] __rcu *[noderef] __rcu next_hop @@
   net/mac80211/tx.c:3614:13: sparse:     expected struct sta_info *sta
   net/mac80211/tx.c:3614:13: sparse:     got struct sta_info [noderef] __rcu *[noderef] __rcu next_hop
>> net/mac80211/tx.c:3615:13: sparse: sparse: incorrect type in assignment (different address spaces) @@     expected struct ieee80211_key *key @@     got struct ieee80211_key [noderef] __rcu *key @@
   net/mac80211/tx.c:3615:13: sparse:     expected struct ieee80211_key *key
   net/mac80211/tx.c:3615:13: sparse:     got struct ieee80211_key [noderef] __rcu *key
   net/mac80211/tx.c: note: in included file (through include/linux/bitops.h, include/linux/kernel.h):
   arch/m68k/include/asm/bitops.h:491:27: sparse: sparse: not addressable
   arch/m68k/include/asm/bitops.h:491:27: sparse: sparse: not addressable

vim +3614 net/mac80211/tx.c

  3613	
> 3614		sta = entry->mpath->next_hop;
> 3615		key = entry->key;
  3616	
  3617		__skb_queue_head_init(&tx.skbs);
  3618	
  3619		tx.flags = IEEE80211_TX_UNICAST;
  3620		tx.local = local;
  3621		tx.sdata = sdata;
  3622		tx.sta = sta;
  3623		tx.key = key;
  3624		tx.skb = skb;
  3625	
  3626		ieee80211_xmit_fast_finish(sdata, sta, entry->pn_offs,
  3627					   key, &tx);
  3628	
  3629		__skb_queue_tail(&tx.skbs, skb);
  3630		ieee80211_tx_frags(local, &sdata->vif, sta, &tx.skbs, false);
  3631		return true;
  3632	}
  3633	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp