Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: Re: wifi: cfg80211: Fix validating BSS pointers in
 __cfg80211_connect_result
From:   Kalle Valo <kvalo@kernel.org>
In-Reply-To: <20220805135259.4126630-1-quic_vjakkam@quicinc.com>
References: <20220805135259.4126630-1-quic_vjakkam@quicinc.com>
To:     Veerendranath Jakkam <quic_vjakkam@quicinc.com>
Cc:     <johannes@sipsolutions.net>, <linux-wireless@vger.kernel.org>
User-Agent: pwcli/0.1.1-git (https://github.com/kvalo/pwcli/) Python/3.7.3
Message-ID: <165994621338.4951.14995602960290467000.kvalo@kernel.org>
Date:   Mon,  8 Aug 2022 08:10:26 +0000 (UTC)
Precedence: bulk

Veerendranath Jakkam <quic_vjakkam@quicinc.com> wrote:

> Driver's SME is allowed to fill either BSSID or BSS pointers in struct
> cfg80211_connect_resp_params when indicating connect response but a
> check in __cfg80211_connect_result() is giving unnecessary warning when
> driver's SME fills only BSSID pointer and not BSS pointer in struct
> cfg80211_connect_resp_params.
> 
> In case of mac80211 with auth/assoc path, it is always expected to fill
> BSS pointers in struct cfg80211_connect_resp_params when calling
> __cfg80211_connect_result() since cfg80211 must have hold BSS pointers
> in cfg80211_mlme_assoc().
> 
> So, skip the check for the drivers which support cfg80211 connect
> callback, for example with brcmfmac is one such driver which had the
> warning:
> 
> WARNING: CPU: 5 PID: 514 at net/wireless/sme.c:786 __cfg80211_connect_result+0x2fc/0x5c0 [cfg80211]
> 
> Reported-by: Linus Torvalds <torvalds@linux-foundation.org>
> Fixes: efbabc116500 ("cfg80211: Indicate MLO connection info in connect and roam callbacks")
> Signed-off-by: Veerendranath Jakkam <quic_vjakkam@quicinc.com>
> [kvalo@kernel.org: add more info to the commit log]

Patch applied to wireless.git, thanks.

baa56dfe2cda wifi: cfg80211: Fix validating BSS pointers in __cfg80211_connect_result

-- 
https://patchwork.kernel.org/project/linux-wireless/patch/20220805135259.4126630-1-quic_vjakkam@quicinc.com/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches