Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: Re: [PATCH v3] wifi: rtlwifi: 8192de: correct checking of IQK reload
From:   Kalle Valo <kvalo@kernel.org>
In-Reply-To: <20220801113345.42016-1-pkshih@realtek.com>
References: <20220801113345.42016-1-pkshih@realtek.com>
To:     Ping-Ke Shih <pkshih@realtek.com>
Cc:     <linux-wireless@vger.kernel.org>
User-Agent: pwcli/0.1.1-git (https://github.com/kvalo/pwcli/) Python/3.7.3
Message-ID: <166002480066.8958.6976882122569958583.kvalo@kernel.org>
Date:   Tue,  9 Aug 2022 06:00:02 +0000 (UTC)
Precedence: bulk

Ping-Ke Shih <pkshih@realtek.com> wrote:

> Since IQK could spend time, we make a cache of IQK result matrix that looks
> like iqk_matrix[channel_idx].val[x][y], and we can reload the matrix if we
> have made a cache. To determine a cache is made, we check
> iqk_matrix[channel_idx].val[0][0].
> 
> The initial commit 7274a8c22980 ("rtlwifi: rtl8192de: Merge phy routines")
> make a mistake that checks incorrect iqk_matrix[channel_idx].val[0] that
> is always true, and this mistake is found by commit ee3db469dd31
> ("wifi: rtlwifi: remove always-true condition pointed out by GCC 12"), so
> I recall the vendor driver to find fix and apply the correctness.
> 
> Fixes: 7274a8c22980 ("rtlwifi: rtl8192de: Merge phy routines")
> Signed-off-by: Ping-Ke Shih <pkshih@realtek.com>

Patch applied to wireless-next.git, thanks.

93fbc1ebd978 wifi: rtlwifi: 8192de: correct checking of IQK reload

-- 
https://patchwork.kernel.org/project/linux-wireless/patch/20220801113345.42016-1-pkshih@realtek.com/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches