Received: by 2002:a05:6358:e9c4:b0:b2:91dc:71ab with SMTP id hc4csp6713119rwb; Tue, 9 Aug 2022 22:58:50 -0700 (PDT) X-Google-Smtp-Source: AA6agR5GxOtHEpIuWn+0ZjBZU5DV2VxTXSpIliVuM1qjKaPzo6aIZCspdwu0tKoHgVb18Vi0vCNP X-Received: by 2002:a17:902:b215:b0:168:da4b:c925 with SMTP id t21-20020a170902b21500b00168da4bc925mr25648907plr.155.1660111119675; Tue, 09 Aug 2022 22:58:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1660111119; cv=none; d=google.com; s=arc-20160816; b=P0MozH5kJkSfwvF2lpxYTfaZTxBitp/S6prKe5Es7SbtmXXJrF7Qs6INwkak8xvQX3 rVlwQ499tUtCS5SR48yCZ0OI9UVgN7Dcb3PI1zz1rMvGMnnL5uiB5K+9pUN/GcuW9F5Y dvo5HU8DHqmj2ffW8EeI+J4m8rltBYv4Db0p4lSqeQn1jUEtgyMclI9SYssBUrjshKNb cX+OUZQ9r0jRiSjGtFoYf6FYI94+AW1qgA5WbaGAs3ZEla2bMK3o5PDLAbmuR95P37oK v/wu5Tt4F9BpN3EFb8TsZBjhuUtMcyAiOnXfF+5chwz8ou+d/0qn4zcMG01yiFxf90dz GK0Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:message-id:in-reply-to:date:references:subject:cc:to :from:dkim-signature; bh=iDCJ4nYAdyjzNhIC0gH/r9LgQBgxUCZFpvt4K8GVlXc=; b=KFzf7/P3vKRWo6qbK34bAVkaCPUamqAoN8M3c8nFdrsAsashscUHl2KXOF/Qa2VMIZ wCAcJQSGddDF1WZkIwctnMe2lbegTbnnvPv4rGXlTaWl9purYY0sKYYzv9I75Ou/p6BO BEPMDJzGJEcKM0y228O8q4EqyImCeNeDUs3/lEnMmI/D7AnPb7R9lxxE2WfNAbnkd4+z PSgYzMZqel/xIKDpTfVXL0Re8jbvPXvMN18761o6MI07ytpidH7K/XP5L+VrCt/O3Gdo Y/9Y04jfNLMlBKVdSDcaxSXEYx9f8hPeQpdm3imeEfAvvTYZkyu9VcSO5efcUm4g00wk Zjmw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=fzRn+ofH; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id m12-20020a170902f64c00b0016d4e5ca5fbsi9328957plg.308.2022.08.09.22.58.24; Tue, 09 Aug 2022 22:58:39 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=fzRn+ofH; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230417AbiHJFkr (ORCPT + 65 others); Wed, 10 Aug 2022 01:40:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46758 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229605AbiHJFkq (ORCPT ); Wed, 10 Aug 2022 01:40:46 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AB6DB6FA16; Tue, 9 Aug 2022 22:40:45 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 33EDF613EA; Wed, 10 Aug 2022 05:40:45 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0613EC433C1; Wed, 10 Aug 2022 05:40:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1660110044; bh=2gJbWzpALWoqhREzI/65nFaQ3yxD3pDPr1VTzYjHy+s=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=fzRn+ofHWrjxCo1fS/haXsAksgnUchkHQXx3AWr9zJzAyBuKjio6BFnQ1Trx67/mW 6RKlZ1NjDR4rTIa8iZX0m4UTJogmmtyB+noNhIiUYCFS7v0xVI58MzEQumVheyVU+K Ldp5On1v8KPvLNFSwEOo+a9EsbUAZFTCM3lUrjfJftRxOnj7r21BXsZ8KVuZEqH+Ry 8OgZHDYq25/V+skynaRWH7VtfTw5F27il2qeGur4XytxH8fku4sn2/hXRa5W40j1+q swthC80o85VMRczLv6ZiqUA+R6kSDxiUBxL+qyG8AOKOjEnCWpO8pms+P5nCBPPv0x SXv/k6FdcPnpg== From: Kalle Valo To: Alvin =?utf-8?Q?=C5=A0ipraga?= Cc: Arend van Spriel , Franky Lin , Hante Meuleman , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Alvin =?utf-8?Q?=C5=A0ipraga?= , linux-wireless@vger.kernel.org, brcm80211-dev-list.pdl@broadcom.com, SHA-cyfmac-dev-list@infineon.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH -next 0/2] brcmfmac: AP STA concurrency patches from Cypress/Infineon References: <20220722122956.841786-1-alvin@pqrs.dk> Date: Wed, 10 Aug 2022 08:40:36 +0300 In-Reply-To: <20220722122956.841786-1-alvin@pqrs.dk> ("Alvin \=\?utf-8\?Q\?\=C5\=A0ipraga\=22's\?\= message of "Fri, 22 Jul 2022 14:29:53 +0200") Message-ID: <87o7wshd0r.fsf@kernel.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-7.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Alvin =C5=A0ipraga writes: > From: Alvin =C5=A0ipraga > > We are using these two patches from Infineon (formerly Cypress) to > enable AP+STA mode on our CYW89359-based platform. They come from the > FMAC driver release package distributed by Infineon. > > The key thing here is that apsta needs to be set to 1 in order for AP > mode to work concurrently with STA mode. I cannot speak for other > chipsets so a review from the Broadcom side would be welcome here. > > For the ARP/ND offload being disabled in AP mode, I am of the view that > this is correct, but while Arend has given his Reviewed-by on it > previously, it was part of a different series [1], so I am sending > without in order to jog some memories. > > [1] https://lore.kernel.org/linux-wireless/20201020022812.37064-3-wright.= feng@cypress.com/#t > > Soontak Lee (1): > brcmfmac: Support multiple AP interfaces and fix STA disconnection > issue > > Ting-Ying Li (1): > brcmfmac: don't allow arp/nd offload to be enabled if ap mode exists Arend, Franky & Hante: could you please take a look at this patchset? Also I hope that people from Infineon could comment. --=20 https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatc= hes