Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Siddh Raman Pant <code@siddh.me>
To:     syzbot+b6c9fe29aefe68e4ad34@syzkaller.appspotmail.com
Cc:     davem@davemloft.net, johannes@sipsolutions.net, kuba@kernel.org,
        linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org,
        netdev@vger.kernel.org, syzkaller-bugs@googlegroups.com
Message-ID: <20220810113551.344792-1-code@siddh.me>
Subject: Re: WARNING in ieee80211_ibss_csa_beacon
Date:   Wed, 10 Aug 2022 17:05:51 +0530
In-Reply-To: <0000000000008c848805b123f174@google.com>
References: <0000000000008c848805b123f174@google.com>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=utf8
Precedence: bulk

When we are not connected to a channel, sending channel "switch"
announcement doesn't make any sense.

#syz test https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.gi=
t master

--- a/net/mac80211/ibss.c
+++ b/net/mac80211/ibss.c
@@ -530,6 +530,10 @@ int ieee80211_ibss_finish_csa(struct ieee80211_sub_if_=
data *sdata)
=20
 =09sdata_assert_lock(sdata);
=20
+=09/* When not connected/joined, sending CSA doesn't make sense. */
+=09if (sdata->u.ibss.state !=3D IEEE80211_IBSS_MLME_JOINED)
+=09=09return -ENOLINK;
+
 =09/* update cfg80211 bss information with the new channel */
 =09if (!is_zero_ether_addr(ifibss->bssid)) {
 =09=09cbss =3D cfg80211_get_bss(sdata->local->hw.wiphy,
--=20
2.35.1