Received: by 2002:a05:6359:322:b0:b3:69d0:12d8 with SMTP id ef34csp80621rwb; Wed, 10 Aug 2022 05:16:05 -0700 (PDT) X-Google-Smtp-Source: AA6agR5gQ4qNKBddNRk9X2e/rPVSi7P2fsflqWpxNKGHWIO69pWS4p9U7Dq56hoyeaBLz3ILBSeR X-Received: by 2002:a05:6402:1681:b0:43d:2e92:63d with SMTP id a1-20020a056402168100b0043d2e92063dmr26640404edv.253.1660133765384; Wed, 10 Aug 2022 05:16:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1660133765; cv=none; d=google.com; s=arc-20160816; b=ozCrg0qkux1nm+EEtV6LXtCLR0mw5aWXyp02eVLCP0q7Wji1giuQ3332YrGhXnPA0s kWQVKCpjkompNlwPftflJv2GST1KbSHgW0M4YxNZ09TPMllOIiGbCg6TB8GcGCMP3wgy OZMwsud6YJcJmD4xnu8X4m2nR90Ge9E+bhYbftLyY445VlK19msxPhUcN7s43mlcr+to bBIyjwDwHY68gbdJ7utpdRnH6pQBFfDS/vSByyGmJvqUxc30y3y7E5/5ZnAbEnsGCiFE S8umxxV0qgWF0WehuV0VKIYQLpMyMcILlVf44DEUhCFraHrroZhGb3uzbswnTZo5ZY1M Ht7A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:user-agent:references:in-reply-to :subject:cc:to:from:date:content-transfer-encoding:mime-version :dkim-signature; bh=+IAqyaBmdCqar9LA4rA4MEkwkKAIVuGKn7A+r+hkxyY=; b=mw2omGMrxYO5rGAVCIF/GrfV8qN/aGnNVoEBp7hbIupkF1y0rbvPnvdS+RRuI11ESM 6C8TZ8ZmrHT5qHRuyG/fLSivugURYzD90qJzdoYc+GyK9J82mm8drUtJgOHwNFMZXlz5 r8yYaK/DwP6yL2VlXfjElgQcLORm4gFnxScxgz6Wmwl2Z7syFqUPzf/fujQuBuWH92rb fBtyzbhT1EuQNYHZwM+fp0KudZsRAhXU2wvuK9+ALSekd/idXHe/tLcMTspQBKHITliP oKrvUIIvx/K/WGo/HK5UHi/2q2YKvgQHV0bWtGPa2o31CKwTE1bSshOniuLlPAqj6ddK 0J0A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@walle.cc header.s=mail2016061301 header.b=t1pGvNdp; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id l8-20020a50cbc8000000b0043c2dd3d889si10215254edi.428.2022.08.10.05.15.44; Wed, 10 Aug 2022 05:16:05 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@walle.cc header.s=mail2016061301 header.b=t1pGvNdp; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231721AbiHJMH7 (ORCPT + 65 others); Wed, 10 Aug 2022 08:07:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37672 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230282AbiHJMH6 (ORCPT ); Wed, 10 Aug 2022 08:07:58 -0400 Received: from ssl.serverraum.org (ssl.serverraum.org [IPv6:2a01:4f8:151:8464::1:2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4AFC013D59 for ; Wed, 10 Aug 2022 05:07:54 -0700 (PDT) Received: from ssl.serverraum.org (web.serverraum.org [172.16.0.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ssl.serverraum.org (Postfix) with ESMTPSA id 73BAB221D4; Wed, 10 Aug 2022 14:07:52 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=walle.cc; s=mail2016061301; t=1660133272; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+IAqyaBmdCqar9LA4rA4MEkwkKAIVuGKn7A+r+hkxyY=; b=t1pGvNdp/hT/8P5hIqAzHLf1EN9jMaWYhRzF54ep93oeVMNu4nnqWghKmb7G+oYHRfIwmg gpzBI5c+/BP1qmp1E934lvZs8kOmjiglXNxAfe82dBjPwcl1mwPOdklUqPt0t8yRlEyLQ7 w/X6T6R8uchdVoEE4AcM/FkgN55v8Do= MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Wed, 10 Aug 2022 14:07:52 +0200 From: Michael Walle To: Ajay.Kathat@microchip.com Cc: linux-wireless@vger.kernel.org, Claudiu.Beznea@microchip.com, Sripad.Balwadgi@microchip.com, mwalle@kernel.org Subject: Re: [PATCH v3] wifi: wilc1000: fix DMA on stack objects In-Reply-To: <20220809075749.62752-1-ajay.kathat@microchip.com> References: <20220809075749.62752-1-ajay.kathat@microchip.com> User-Agent: Roundcube Webmail/1.4.13 Message-ID: X-Sender: michael@walle.cc X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Am 2022-08-09 09:57, schrieb Ajay.Kathat@microchip.com: > Sometimes 'wilc_sdio_cmd53' is called with addresses pointing to an > object on the stack. Use dynamically allocated memory for cmd53 instead > of stack address which is not DMA'able. > > Fixes: 5625f965d764 ("wilc1000: move wilc driver out of staging") > Reported-by: Michael Walle > Suggested-by: Michael Walle > Signed-off-by: Ajay Singh Thanks! Reviewed-by: Michael Walle Tested-by: Michael Walle -michael