Received: by 2002:a05:6358:4e97:b0:b3:742d:4702 with SMTP id ce23csp156111rwb; Wed, 10 Aug 2022 21:56:06 -0700 (PDT) X-Google-Smtp-Source: AA6agR6PAOvJfm6FXXnXv0Sc4JXpOmGzo6SJDDporHQVBofQkFEvXT7e5PAIZY0jvE8JyrJ6WJfe X-Received: by 2002:a05:6402:293:b0:43d:3936:66b0 with SMTP id l19-20020a056402029300b0043d393666b0mr28816690edv.404.1660193766472; Wed, 10 Aug 2022 21:56:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1660193766; cv=none; d=google.com; s=arc-20160816; b=CFleZMf2vuQYJdvMvcWaVMxIGiPyACnfDhCxukzJPZWw+yEJ971nkh0aNBySpDmhlM 1ve1Pv7EjKLXGIFrtdpRRn+lAxXMBX3ybY+AYYL04RLnNTV2mTKZ4UF9N1yANwAjX5wt lmfIxQQiTvTjALY+D9CzuGT7kUW4idnFpsAEbvD73MiizJbotqXRDtqS38onPo5uj0AG Cdb00HtYXiNivNUGdSrDwXeFEQnPpVxtxV+26lLZIHPiav4ByZV502eQwGBMGyPX/bFD Vg4+qcEWke1QRFdN2sqtx/e0xAXSDnAbtxWT5pQbl/qVDwAvNBlfS1CwauRdNF8PidOd /1Xg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:user-agent:message-id:in-reply-to :date:references:subject:cc:to:from:dkim-signature; bh=dOrhoIAmieNlKa2Y0dKmh1nWsGuskPXK3py8WQpnQXs=; b=BKC+sARjr4AO9TDgJ3Ds7X4eH/dz+NUhtf4fIgYf7d1+xQo/IVwfZ7sur+vAVn3t/A ZfC7F6SpCXD7I2FHMLgXEubw1b4xgFL5GekiPnT+4iwDAWkkuQAQr2YyTQxlRHv891oL lcaEz2RPHY3F+FmUgR65W1yhM0cKVXRmIaLv24/62tT1hiPuM2deHSWux+TNoRbkBPG6 Ee/vBg/SW9aVUJ3b5CA6TAxTeTNPpcoUSo7aA0dWFlX3pvPHgkjGpN4pLytMX1qh1/2I 9Fgu/Q6xaU3aoeAIbe9VPdT7ZY8pX6n9V1OVWxf67Tlyc/1kbqjedLBUPmKdu77KRc8O P2gA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=WFOVVX2f; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id cs9-20020a170906dc8900b007331866eb20si2760462ejc.303.2022.08.10.21.55.45; Wed, 10 Aug 2022 21:56:06 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=WFOVVX2f; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233839AbiHKEzM (ORCPT + 65 others); Thu, 11 Aug 2022 00:55:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51346 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229617AbiHKEzK (ORCPT ); Thu, 11 Aug 2022 00:55:10 -0400 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 35E2266A52 for ; Wed, 10 Aug 2022 21:55:10 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id 94EA7CE1847 for ; Thu, 11 Aug 2022 04:55:08 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 98B8DC433C1; Thu, 11 Aug 2022 04:55:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1660193706; bh=/R2TqnSbJxIKcKa+IbinmolWAkYLruxSVtFn4OWCcyY=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=WFOVVX2frp7skqJVZdYNdgVfcnyS4xe11ThfefQRrJia8Jj5IExfC3jnYibQgP8E8 cprFCleAL77SAeIyvAoSV3QXFVCc4sg3iqH5TAbzAofE69QN6bXj6ldVqPWeqBItIA E1U+uC3hWpWcyx1NzAnCUCG/HIdXt1MgTNRKOfHxtnE0BMKnxP+jVkFiX2M/K8rGbH R5CFjUswiAILe4AqqtIqSoKlXw9mkA2PbctQl+S88cKSWWhnm+WYYCKn/0T5etPDxo eVIAGRV0+b14IbXit4+0RG4qzENJn5HyMJqTEBYdZitBNqERRcHYbkcpmWhyzxsOKL Nz5mRE1CdezAQ== From: Kalle Valo To: Michael Walle Cc: Ajay.Kathat@microchip.com, linux-wireless@vger.kernel.org, Claudiu.Beznea@microchip.com, Sripad.Balwadgi@microchip.com, mwalle@kernel.org Subject: Re: [PATCH v3] wifi: wilc1000: fix DMA on stack objects References: <20220809075749.62752-1-ajay.kathat@microchip.com> Date: Thu, 11 Aug 2022 07:55:01 +0300 In-Reply-To: (Michael Walle's message of "Wed, 10 Aug 2022 14:07:52 +0200") Message-ID: <87k07fgz16.fsf@kernel.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-7.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Michael Walle writes: > Am 2022-08-09 09:57, schrieb Ajay.Kathat@microchip.com: >> Sometimes 'wilc_sdio_cmd53' is called with addresses pointing to an >> object on the stack. Use dynamically allocated memory for cmd53 instead >> of stack address which is not DMA'able. >> >> Fixes: 5625f965d764 ("wilc1000: move wilc driver out of staging") >> Reported-by: Michael Walle >> Suggested-by: Michael Walle >> Signed-off-by: Ajay Singh > > Thanks! > > Reviewed-by: Michael Walle > Tested-by: Michael Walle Thanks Michael. My plan is to take this to the wireless tree, seems important enough fix. -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches