Received: by 2002:a05:6358:4e97:b0:b3:742d:4702 with SMTP id ce23csp188939rwb; Fri, 12 Aug 2022 17:29:38 -0700 (PDT) X-Google-Smtp-Source: AA6agR7PxNyh4GrHol3Puc7OO8mjvF29e3OkruOK1ZtCPf43u6quPyc0s3LENzTGbSLtQ0Q+4JOl X-Received: by 2002:a05:6402:51c6:b0:43d:dd3a:196e with SMTP id r6-20020a05640251c600b0043ddd3a196emr5503393edd.213.1660350578383; Fri, 12 Aug 2022 17:29:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1660350578; cv=none; d=google.com; s=arc-20160816; b=00I7bqRQpSd6pDS78nMpwhuAyrHU9mxkjxCrVCcMKYT5HEk5QMmhthgfryp5DfpRep GvOAdpYKpaHRyhU0UC7D0REaM1gDaD8Nl9V2pSu3hhiwQuPUIVGGVTCjwlH0DfO1f25u 0olGwVfsl8JL3o/m423HlL7y496fu4Yh7oIK1WxFPTf9P925lk0rzWAZPGkgxh06gEns KL3InXIf9nGb7DBwXWE7cay6ZGY9UflhHJa+KFUDBve3l3ZH/UUFyhTEWpyOVBoUGv3X gf3vYPtENLIvs+S0kko6kOCGM6aguhm7ob7ljSdDRcpZdCUoTIFuJYLvUbZqlodt1279 5NkQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=o3uxq8sbqmYpTOvEn1/zROV8kbcgKT4IDV/8Na86RJo=; b=qRds1fyl5zfmGH23yY0Y5eNGwjA21a//woQkOU9sRjJTW4XGZf/lL4xbzjuO2B8FhO oNmn3BOAtHmiFsYeiGAuzPvJAJlo3AsvN31K+jFGM0eA+xgH+plIEJKrBD3Dt+7snxot 9T7qQhwA2JbokMzV3Qyq3vJ1p45FXRwXAZ9umOqqVmUkfi2Ag/L8rvQkxbdu+2ZQ+M3T vE5ca98lWuxbmYvdnN1ckMs2ljNg1M4OK/rNxrv3AvPmtc7qPCan745tSHSN1Smv8ZCi /xN7BaSkiBU3aVWodU/Sjn/QZHnemfnvff5fUF2F7amoGJ8lsf3rIEtCAzOpIkh6H8Xj ld3g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=XmQF06xD; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id dm16-20020a170907949000b007306dbac8c6si2879885ejc.28.2022.08.12.17.29.02; Fri, 12 Aug 2022 17:29:38 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=XmQF06xD; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231308AbiHMAQW (ORCPT + 65 others); Fri, 12 Aug 2022 20:16:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43150 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229617AbiHMAQV (ORCPT ); Fri, 12 Aug 2022 20:16:21 -0400 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 619EB96FDC for ; Fri, 12 Aug 2022 17:16:20 -0700 (PDT) Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 27D00AXe006934; Sat, 13 Aug 2022 00:16:13 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=qcppdkim1; bh=o3uxq8sbqmYpTOvEn1/zROV8kbcgKT4IDV/8Na86RJo=; b=XmQF06xDB4xwyph8yZZ3ixEpQDaFINBxuejivkk1ZW7CyehB/jSOkYhWwLLIB4PBnY0E axeN6NDgWCesy7S2IgYahPxXpFBnVxSc1+iKYVWZSZpvQjpv8evWFaGYKG4Ea2Xj7qwC Ca1995aJmHmlg1Cux4cngb9se+Dq10yjOl3pKgJELZKHCS44TDX0mjtvVIx8JtoElxkY RuYM5lX9sLgKkc6QZoZoBnpSaH52VlspaSFyARb/7WkiUebaIsAM8h8zR91wru/7e8Fo DKoTrGSVWQeJl7hc1wv7DUCNGUstHXsZNglgW1WVNIo/nbyumNfDXB3PK0omHsBs05eE WQ== Received: from nalasppmta03.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3hwahwksb9-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sat, 13 Aug 2022 00:16:13 +0000 Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA03.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 27D0GC8t009398 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sat, 13 Aug 2022 00:16:12 GMT Received: from [10.110.64.247] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.22; Fri, 12 Aug 2022 17:16:12 -0700 Message-ID: Date: Fri, 12 Aug 2022 17:16:10 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [PATCH 06/50] wifi: ath12k: add core.h Content-Language: en-US To: Kalle Valo , CC: References: <20220812161003.27279-1-kvalo@kernel.org> <20220812161003.27279-7-kvalo@kernel.org> From: Jeff Johnson In-Reply-To: <20220812161003.27279-7-kvalo@kernel.org> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: 32S95HJ_uC-jcAa7vjitYaTnp9YFWcJi X-Proofpoint-ORIG-GUID: 32S95HJ_uC-jcAa7vjitYaTnp9YFWcJi X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.883,Hydra:6.0.517,FMLib:17.11.122.1 definitions=2022-08-12_10,2022-08-11_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 mlxscore=0 spamscore=0 suspectscore=0 clxscore=1011 bulkscore=0 adultscore=0 mlxlogscore=837 malwarescore=0 impostorscore=0 phishscore=0 priorityscore=1501 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2207270000 definitions=main-2208120067 X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_LOW, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org > +struct ath12k_skb_cb { > + dma_addr_t paddr; > + u8 flags; > + u32 cipher; > + struct ath12k *ar; > + struct ieee80211_vif *vif; > + dma_addr_t paddr_ext_desc; > +} __packed; Usage of __packed seems incorrect since this is not an ABI buffer, and packing will potentially result in some members being unaligned (ath11k has struct ath11k_skb_cb packed as well). Suggest removing __packed and using pahole to find the ideal layout since the only concern is that this does not exceed IEEE80211_TX_INFO_DRIVER_DATA_SIZE