Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Authenticated-By: 
From:   Ping-Ke Shih <pkshih@realtek.com>
To:     Kalle Valo <kvalo@kernel.org>,
        "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
CC:     "ath12k@lists.infradead.org" <ath12k@lists.infradead.org>
Subject: RE: [PATCH 12/50] wifi: ath12k: add dp.h
Thread-Topic: [PATCH 12/50] wifi: ath12k: add dp.h
Thread-Index: AQHYrmYhVT/+9aWmK0SqnIzaxO3tva2vM+VA
Date:   Mon, 15 Aug 2022 01:56:29 +0000
Message-ID: <0eabd6c1b3ca4d8a8152ad5b4f3efee6@realtek.com>
References: <20220812161003.27279-1-kvalo@kernel.org>
 <20220812161003.27279-13-kvalo@kernel.org>
In-Reply-To: <20220812161003.27279-13-kvalo@kernel.org>
Accept-Language: en-US, zh-TW
Content-Language: zh-TW
x-kse-attachmentfiltering-interceptor-info: no applicable attachment filtering
 rules found
x-kse-antivirus-interceptor-info: scan successful
x-kse-antivirus-info: =?us-ascii?Q?Clean,_bases:_2022/8/14_=3F=3F_10:00:00?=
x-kse-bulkmessagesfiltering-scan-result: protection disabled
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 8BIT
MIME-Version: 1.0
X-KSE-ServerInfo: RTEXH36504.realtek.com.tw, 9
X-KSE-AntiSpam-Interceptor-Info: fallback
X-KSE-Antivirus-Interceptor-Info: fallback
X-KSE-AntiSpam-Interceptor-Info: fallback
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE,
        SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-wireless.vger.kernel.org>
X-Mailing-List: linux-wireless@vger.kernel.org


> -----Original Message-----
> From: Kalle Valo <kvalo@kernel.org>
> Sent: Saturday, August 13, 2022 12:09 AM
> To: linux-wireless@vger.kernel.org
> Cc: ath12k@lists.infradead.org
> Subject: [PATCH 12/50] wifi: ath12k: add dp.h
> 
> From: Kalle Valo <quic_kvalo@quicinc.com>
> 
> (Patches split into one patch per file for easier review, but the final
> commit will be one big patch. See the cover letter for more info.)
> 
> Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com>
> ---
>  drivers/net/wireless/ath/ath12k/dp.h | 2017 ++++++++++++++++++++++++++++++++++
>  1 file changed, 2017 insertions(+)
> 
> diff --git a/drivers/net/wireless/ath/ath12k/dp.h b/drivers/net/wireless/ath/ath12k/dp.h
> new file mode 100644
> index 000000000000..cf9610dffbb8
> --- /dev/null
> +++ b/drivers/net/wireless/ath/ath12k/dp.h

[...]

> +
> +struct htt_srng_setup_cmd {
> +	u32 info0;
> +	u32 ring_base_addr_lo;
> +	u32 ring_base_addr_hi;
> +	u32 info1;
> +	u32 ring_head_off32_remote_addr_lo;
> +	u32 ring_head_off32_remote_addr_hi;
> +	u32 ring_tail_off32_remote_addr_lo;
> +	u32 ring_tail_off32_remote_addr_hi;
> +	u32 ring_msi_addr_lo;
> +	u32 ring_msi_addr_hi;
> +	u32 msi_data;
> +	u32 intr_info;
> +	u32 info2;
> +} __packed;
> +

Should they be '__le32' instead of 'u32'?

This struct is used to fill data of ath12k_htc_send(), and the fields of
htc header are __le32: 

struct ath12k_htc_hdr {
	__le32 htc_info;
	__le32 ctrl_info;
} __packed __aligned(4);

If above is correct, some struct(s) related to ath12k_htc_send() have similar problems: 
struct htt_ver_req_cmd
struct htt_ppdu_stats_cfg_cmd
struct htt_rx_ring_selection_cfg_cmd
struct htt_ext_stats_cfg_cmd
struct htt_tx_ring_selection_cfg_cmd  (miss __packed)

--
Ping-Ke