Received: by 2002:a05:6358:4e97:b0:b3:742d:4702 with SMTP id ce23csp3507666rwb; Tue, 16 Aug 2022 04:27:20 -0700 (PDT) X-Google-Smtp-Source: AA6agR6csegDWOHSlb5gIWs8cbsWgr/f7bXHRrdEufdsMAUApjMcxEGZQCKxSxO+AT5byzMquW17 X-Received: by 2002:a17:907:168e:b0:731:4ba0:d5e9 with SMTP id hc14-20020a170907168e00b007314ba0d5e9mr13521817ejc.204.1660649239900; Tue, 16 Aug 2022 04:27:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1660649239; cv=none; d=google.com; s=arc-20160816; b=KAD4TxFtiokE3T3k34wHX9jbiI5PN49r2c0t36lnOzPdXMAxYo3dG0XUhSgt02wetm Pk+l1Qpb9EMnRQLq18yGfWpX4qoHGa937kCRfEyvG28YiItZ0WooGpJ0YGM0x/1sUmu1 aj00vcPeAImIEwR6NPxXG3Nuwda6oymRXtAHgfHdPyzluhpnwsswEM6K9a3rYAKDSL5p 5MpaKrn4dC4CQb2jAMIwAueoLH/Crn4HoitOBzILk3sglTlEpOGvc1woZPKeXhgIM6f6 plAPytcU4CFHOOUfCggBPrhbC18geK4Gn6suHzWwEqEXaAnxD/rtl+7/Ieg6pOXpBN5t ljZg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:references :cc:to:from:content-language:subject:user-agent:mime-version:date :message-id; bh=ukGRxl+DRw/k+ThPDtK3krmU0XaFVBicngGT+vdu/jU=; b=zr2t3Kk/YaboB10prCVvHkZhBr4JJNB9cBIxHlA386Cg+MW/asHVK4D88QicNUmCNL jhnsin18geCXBIE6TxUE6tutMqTjsT1m3rxMJKkHM6SxodddUGcZZIzHoDNsmwY4azFN zB8au399hd0F5+EMbBjxhUUi/wr/hBaEB8HtwoIPLHdp6M7nMpefyKzGK4xteA25S4is 8Admsj+ix4FVkxPYSiSrEsyaZlCiUmBeBbhty7ney4wJOh8Dk3k84BtFkcdXi6ZG8YJP J6Lknyxh8vonK+nUZD8XJj6AkHYwt6ymDygClKTtfHAHWSb73fX+vMUMIvLXuj6/R9SF ieuw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id qk18-20020a1709077f9200b0072fb108db55si10146700ejc.895.2022.08.16.04.27.00; Tue, 16 Aug 2022 04:27:19 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-wireless-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234177AbiHPLRf (ORCPT + 65 others); Tue, 16 Aug 2022 07:17:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34744 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234815AbiHPLRS (ORCPT ); Tue, 16 Aug 2022 07:17:18 -0400 Received: from www262.sakura.ne.jp (www262.sakura.ne.jp [202.181.97.72]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1425751A30 for ; Tue, 16 Aug 2022 02:52:41 -0700 (PDT) Received: from fsav413.sakura.ne.jp (fsav413.sakura.ne.jp [133.242.250.112]) by www262.sakura.ne.jp (8.15.2/8.15.2) with ESMTP id 27G9qRYd039633; Tue, 16 Aug 2022 18:52:27 +0900 (JST) (envelope-from penguin-kernel@I-love.SAKURA.ne.jp) Received: from www262.sakura.ne.jp (202.181.97.72) by fsav413.sakura.ne.jp (F-Secure/fsigk_smtp/550/fsav413.sakura.ne.jp); Tue, 16 Aug 2022 18:52:27 +0900 (JST) X-Virus-Status: clean(F-Secure/fsigk_smtp/550/fsav413.sakura.ne.jp) Received: from [192.168.1.9] (M106072142033.v4.enabler.ne.jp [106.72.142.33]) (authenticated bits=0) by www262.sakura.ne.jp (8.15.2/8.15.2) with ESMTPSA id 27G9qQJG039630 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NO); Tue, 16 Aug 2022 18:52:27 +0900 (JST) (envelope-from penguin-kernel@I-love.SAKURA.ne.jp) Message-ID: Date: Tue, 16 Aug 2022 18:52:23 +0900 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 6.3; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.1.2 Subject: Re: [PATCH] ath9k: avoid uninit memory read in ath9k_htc_rx_msg() Content-Language: en-US From: Tetsuo Handa To: Toke Hoiland-Jorgensen , Kalle Valo Cc: linux-wireless , ath9k-devel@qca.qualcomm.com References: <000000000000c98a7f05ac744f53@google.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,NICE_REPLY_A, SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On 2022/07/30 21:13, Tetsuo Handa wrote: > We have two choices. One is to workaround by adding __GFP_ZERO so that > ath9k_htc_rx_msg() sees 0 if pkt_len is invalid. The other is to let > ath9k_htc_rx_msg() validate pkt_len before accessing. Which choice do we want to go?