Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <3b09b751-54c1-d684-7d5c-8f736cd80707@quicinc.com>
Date:   Fri, 19 Aug 2022 11:56:23 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.12.0
Subject: Re: [PATCH 33/50] wifi: ath12k: add mhi.c
Content-Language: en-US
From:   Jeff Johnson <quic_jjohnson@quicinc.com>
To:     Kalle Valo <kvalo@kernel.org>, <linux-wireless@vger.kernel.org>
CC:     <ath12k@lists.infradead.org>
References: <20220812161003.27279-1-kvalo@kernel.org>
 <20220812161003.27279-34-kvalo@kernel.org>
 <05841a52-3d2f-8704-b885-4b02e7a439e0@quicinc.com>
In-Reply-To: <05841a52-3d2f-8704-b885-4b02e7a439e0@quicinc.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 8/18/2022 3:25 PM, Jeff Johnson wrote:
 > On 8/12/2022 9:09 AM, Kalle Valo wrote:
 >> +static struct mhi_event_config ath12k_mhi_events_qcn9274[] = {
 >
 > seems this should be const
 > but for some reason struct mhi_controller_config has:
 >      struct mhi_event_config *event_cfg;
 >
 > (not const) so this can't be const :(
 >
 > perhaps someone can propose a MHI interface change?
 > especially since internally to MHI in parse_ev_cfg() we have:
 >      const struct mhi_event_config *event_cfg;
 >      [...]
 >      for (i = 0; i < num; i++) {
 >          event_cfg = &config->event_cfg[i];
 >
 > so it is treated as const

I submitted a patch for this

<https://lore.kernel.org/mhi/20220819184245.28035-1-quic_jjohnson@quicinc.com/>