Received-SPF: pass (google.com: domain of linux-wireless-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII;
 format=flowed
Content-Transfer-Encoding: 7bit
Date:   Mon, 22 Aug 2022 09:27:04 +0200
From:   Michael Walle <michael@walle.cc>
To:     Kalle Valo <kvalo@kernel.org>
Cc:     Ajay.Kathat@microchip.com, linux-wireless@vger.kernel.org,
        Claudiu.Beznea@microchip.com, Sripad.Balwadgi@microchip.com,
        mwalle@kernel.org
Subject: Re: [PATCH v3] wifi: wilc1000: fix DMA on stack objects
In-Reply-To: <87k07fgz16.fsf@kernel.org>
References: <20220809075749.62752-1-ajay.kathat@microchip.com>
 <b1e606e7a36fb900bbc664bbd585ff6a@walle.cc> <87k07fgz16.fsf@kernel.org>
User-Agent: Roundcube Webmail/1.4.13
Message-ID: <bbbaf29f1767a7f90851505cd4a24ce6@walle.cc>
Precedence: bulk

Hi Kalle,

Am 2022-08-11 06:55, schrieb Kalle Valo:
> Michael Walle <michael@walle.cc> writes:
> 
>> Am 2022-08-09 09:57, schrieb Ajay.Kathat@microchip.com:
>>> Sometimes 'wilc_sdio_cmd53' is called with addresses pointing to an
>>> object on the stack. Use dynamically allocated memory for cmd53 
>>> instead
>>> of stack address which is not DMA'able.
>>> 
>>> Fixes: 5625f965d764 ("wilc1000: move wilc driver out of staging")
>>> Reported-by: Michael Walle <mwalle@kernel.org>
>>> Suggested-by: Michael Walle <mwalle@kernel.org>
>>> Signed-off-by: Ajay Singh <ajay.kathat@microchip.com>
>> 
>> Thanks!
>> 
>> Reviewed-by: Michael Walle <mwalle@kernel.org>
>> Tested-by: Michael Walle <mwalle@kernel.org>
> 
> Thanks Michael. My plan is to take this to the wireless tree, seems
> important enough fix.

Do you already have any plan, when you will pick this?

-michael